Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

2017-05-09 Thread Tanu Kaskinen
On Tue, 2017-05-09 at 16:59 +0200, Georg Chini wrote: > On 07.05.2017 13:23, Tanu Kaskinen wrote: > > On Sun, 2017-05-07 at 12:37 +0200, Georg Chini wrote: > > > Another similar point, while reading the code of > > > module-switch-on-connect, i > > > found a possible issue: > > > When a new sink tu

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

2017-05-09 Thread Georg Chini
On 07.05.2017 13:23, Tanu Kaskinen wrote: On Sun, 2017-05-07 at 12:37 +0200, Georg Chini wrote: On 07.05.2017 11:16, Tanu Kaskinen wrote: On Sat, 2017-05-06 at 22:15 +0200, Georg Chini wrote: On 06.05.2017 22:06, Tanu Kaskinen wrote: I made a strange interpretation, because what you really me

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

2017-05-08 Thread Georg Chini
On 07.05.2017 09:33, Tanu Kaskinen wrote: On Sat, 2017-05-06 at 22:38 +0200, Georg Chini wrote: On 06.05.2017 22:15, Georg Chini wrote: On 06.05.2017 22:06, Tanu Kaskinen wrote: On Sat, 2017-05-06 at 20:06 +0200, Georg Chini wrote: On 06.05.2017 18:36, Tanu Kaskinen wrote: On Fri, 2017-05-05

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

2017-05-07 Thread Georg Chini
On 07.05.2017 13:44, Tanu Kaskinen wrote: On Sun, 2017-05-07 at 12:32 +0200, Georg Chini wrote: On 07.05.2017 09:33, Tanu Kaskinen wrote: On Sat, 2017-05-06 at 22:38 +0200, Georg Chini wrote: On 06.05.2017 22:15, Georg Chini wrote: On 06.05.2017 22:06, Tanu Kaskinen wrote: I made a strange i

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

2017-05-07 Thread Tanu Kaskinen
On Sun, 2017-05-07 at 12:32 +0200, Georg Chini wrote: > On 07.05.2017 09:33, Tanu Kaskinen wrote: > > On Sat, 2017-05-06 at 22:38 +0200, Georg Chini wrote: > > > On 06.05.2017 22:15, Georg Chini wrote: > > > > On 06.05.2017 22:06, Tanu Kaskinen wrote: > > > > > I made a strange interpretation, beca

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

2017-05-07 Thread Tanu Kaskinen
On Sun, 2017-05-07 at 12:37 +0200, Georg Chini wrote: > On 07.05.2017 11:16, Tanu Kaskinen wrote: > > On Sat, 2017-05-06 at 22:15 +0200, Georg Chini wrote: > > > On 06.05.2017 22:06, Tanu Kaskinen wrote: > > > > I made a strange interpretation, because what you really meant seemed > > > > even more

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

2017-05-07 Thread Georg Chini
On 07.05.2017 11:16, Tanu Kaskinen wrote: On Sat, 2017-05-06 at 22:15 +0200, Georg Chini wrote: On 06.05.2017 22:06, Tanu Kaskinen wrote: I made a strange interpretation, because what you really meant seemed even more crazy. I forgot that module-switch-on-connect only moves streams if they are

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

2017-05-07 Thread Georg Chini
On 07.05.2017 09:33, Tanu Kaskinen wrote: On Sat, 2017-05-06 at 22:38 +0200, Georg Chini wrote: On 06.05.2017 22:15, Georg Chini wrote: On 06.05.2017 22:06, Tanu Kaskinen wrote: On Sat, 2017-05-06 at 20:06 +0200, Georg Chini wrote: On 06.05.2017 18:36, Tanu Kaskinen wrote: On Fri, 2017-05-05

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

2017-05-07 Thread Tanu Kaskinen
On Sat, 2017-05-06 at 22:15 +0200, Georg Chini wrote: > On 06.05.2017 22:06, Tanu Kaskinen wrote: > > I made a strange interpretation, because what you really meant seemed > > even more crazy. I forgot that module-switch-on-connect only moves > > streams if they are routed to the default sink, and

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

2017-05-07 Thread Tanu Kaskinen
On Sat, 2017-05-06 at 22:38 +0200, Georg Chini wrote: > On 06.05.2017 22:15, Georg Chini wrote: > > On 06.05.2017 22:06, Tanu Kaskinen wrote: > > > On Sat, 2017-05-06 at 20:06 +0200, Georg Chini wrote: > > > > On 06.05.2017 18:36, Tanu Kaskinen wrote: > > > > > On Fri, 2017-05-05 at 16:21 +0200, Ge

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

2017-05-06 Thread Georg Chini
On 06.05.2017 22:15, Georg Chini wrote: On 06.05.2017 22:06, Tanu Kaskinen wrote: On Sat, 2017-05-06 at 20:06 +0200, Georg Chini wrote: On 06.05.2017 18:36, Tanu Kaskinen wrote: On Fri, 2017-05-05 at 16:21 +0200, Georg Chini wrote: I agree with you that my patch is wrong, but I think there is

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

2017-05-06 Thread Georg Chini
On 06.05.2017 22:06, Tanu Kaskinen wrote: On Sat, 2017-05-06 at 20:06 +0200, Georg Chini wrote: On 06.05.2017 18:36, Tanu Kaskinen wrote: On Fri, 2017-05-05 at 16:21 +0200, Georg Chini wrote: I agree with you that my patch is wrong, but I think there is a simpler solution than your patch. The

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

2017-05-06 Thread Tanu Kaskinen
On Sat, 2017-05-06 at 20:06 +0200, Georg Chini wrote: > On 06.05.2017 18:36, Tanu Kaskinen wrote: > > On Fri, 2017-05-05 at 16:21 +0200, Georg Chini wrote: > > > I agree with you that my patch is wrong, but I think there is a simpler > > > solution than your patch. The reason why the move is trigge

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

2017-05-06 Thread Georg Chini
On 06.05.2017 18:36, Tanu Kaskinen wrote: On Fri, 2017-05-05 at 16:21 +0200, Georg Chini wrote: On 04.05.2017 20:11, Tanu Kaskinen wrote: On Wed, 2017-05-03 at 22:19 +0200, Georg Chini wrote: On 03.05.2017 21:58, Tanu Kaskinen wrote: On Tue, 2017-05-02 at 07:12 +0200, Georg Chini wrote: On 0

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

2017-05-06 Thread Tanu Kaskinen
On Fri, 2017-05-05 at 16:21 +0200, Georg Chini wrote: > On 04.05.2017 20:11, Tanu Kaskinen wrote: > > On Wed, 2017-05-03 at 22:19 +0200, Georg Chini wrote: > > > On 03.05.2017 21:58, Tanu Kaskinen wrote: > > > > On Tue, 2017-05-02 at 07:12 +0200, Georg Chini wrote: > > > > > On 01.05.2017 22:10, Ta

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

2017-05-05 Thread Georg Chini
On 04.05.2017 20:11, Tanu Kaskinen wrote: On Wed, 2017-05-03 at 22:19 +0200, Georg Chini wrote: On 03.05.2017 21:58, Tanu Kaskinen wrote: On Tue, 2017-05-02 at 07:12 +0200, Georg Chini wrote: On 01.05.2017 22:10, Tanu Kaskinen wrote: On Mon, 2017-04-24 at 19:33 +0200, Georg Chini wrote: Ther

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

2017-05-04 Thread Tanu Kaskinen
On Wed, 2017-05-03 at 22:19 +0200, Georg Chini wrote: > On 03.05.2017 21:58, Tanu Kaskinen wrote: > > On Tue, 2017-05-02 at 07:12 +0200, Georg Chini wrote: > > > On 01.05.2017 22:10, Tanu Kaskinen wrote: > > > > On Mon, 2017-04-24 at 19:33 +0200, Georg Chini wrote: > > > > > There are several place

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

2017-05-03 Thread Georg Chini
On 03.05.2017 21:58, Tanu Kaskinen wrote: On Tue, 2017-05-02 at 07:12 +0200, Georg Chini wrote: On 01.05.2017 22:10, Tanu Kaskinen wrote: On Mon, 2017-04-24 at 19:33 +0200, Georg Chini wrote: There are several places in module-echo-cancel where a segfault is possible when the master sink or so

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

2017-05-03 Thread Tanu Kaskinen
On Tue, 2017-05-02 at 07:12 +0200, Georg Chini wrote: > On 01.05.2017 22:10, Tanu Kaskinen wrote: > > On Mon, 2017-04-24 at 19:33 +0200, Georg Chini wrote: > > > There are several places in module-echo-cancel where a segfault is > > > possible when the master sink or source is invalid. > > > > I d

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

2017-05-01 Thread Georg Chini
On 01.05.2017 22:10, Tanu Kaskinen wrote: On Mon, 2017-04-24 at 19:33 +0200, Georg Chini wrote: There are several places in module-echo-cancel where a segfault is possible when the master sink or source is invalid. I don't think the rewind, volume and mute callbacks are ever called during strea

Re: [pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

2017-05-01 Thread Tanu Kaskinen
On Mon, 2017-04-24 at 19:33 +0200, Georg Chini wrote: > There are several places in module-echo-cancel where a segfault is > possible when the master sink or source is invalid. I don't think the rewind, volume and mute callbacks are ever called during stream moves, at least with the current code b

[pulseaudio-discuss] [PATCH] echo-cancel: Avoid segfaults due to invalid master sink or source

2017-04-24 Thread Georg Chini
There are several places in module-echo-cancel where a segfault is possible when the master sink or source is invalid. This patch checks for the validity of master source or sink and lets the functions just return if it is invalid. Other virtual sinks and sources will be fixed in a separate patch