Re: [pulseaudio-discuss] [PATCH] make speex optional, make Adrian AEC optional

2011-12-09 Thread Maarten Bosmans
2011/12/8 Arun Raghavan : > 3. We should check to make sure that at least one canceller is selected > at configure time Or just skip building module-echo-cancel alltogether in that case. Maarten ___ pulseaudio-discuss mailing list pulseaudio-discuss@lis

Re: [pulseaudio-discuss] [PATCH] make speex optional, make Adrian AEC optional

2011-12-08 Thread Peter Meerwald
> Your patch contains the following : > PA_ECHO_CANCELLER_SPEEX = 0, > +#ifdef HAVE_SPEEX > +PA_ECHO_CANCELLER_SPEEX, > +#endif > +#ifdef HAVE_ADRIAN_EC > PA_ECHO_CANCELLER_ADRIAN, > This will lead to a bug if Speex is disabled and Adrian > or WRT is enabled, since ec_table will cont

Re: [pulseaudio-discuss] [PATCH] make speex optional, make Adrian AEC optional

2011-12-08 Thread Dalleau, Frederic
Hi Peter, Your patch contains the following : PA_ECHO_CANCELLER_SPEEX = 0, +#ifdef HAVE_SPEEX +PA_ECHO_CANCELLER_SPEEX, +#endif +#ifdef HAVE_ADRIAN_EC PA_ECHO_CANCELLER_ADRIAN, This will lead to a bug if Speex is disabled and Adrian or WRT is enabled, since ec_table will contain Adr

Re: [pulseaudio-discuss] [PATCH] make speex optional, make Adrian AEC optional

2011-12-08 Thread Arun Raghavan
Hi, On Wed, 2011-12-07 at 15:20 +0100, Peter Meerwald wrote: > Hello, > > attached patch makes > - the speex library optional (i.e. the speex resampler and the speex > acoustic echo canceller, AEC) > - the Adrian AEC implementation in the module-echo-cancel optional > > reducing dependencies

[pulseaudio-discuss] [PATCH] make speex optional, make Adrian AEC optional

2011-12-07 Thread Peter Meerwald
Hello, attached patch makes - the speex library optional (i.e. the speex resampler and the speex acoustic echo canceller, AEC) - the Adrian AEC implementation in the module-echo-cancel optional reducing dependencies and unneeded code is desirable in embedded scenarios note that the patch chan