[pulseaudio-discuss] [PATCH] module-virtual-sink: Speed up draining

2014-10-02 Thread David Henningsson
The drain speed increase done a while ago, only worked when directly connected to ALSA sinks. Playing through an module-virtual-sink would cause slower drains. This fix has two parts: 1) We now refuse to process handed out silence. This has the effect that it tells ALSAs sink input that we're

Re: [pulseaudio-discuss] [PATCH] module-virtual-sink: Speed up draining

2014-10-02 Thread Alexander E. Patrakov
02.10.2014 19:58, David Henningsson wrote: The drain speed increase done a while ago, only worked when directly connected to ALSA sinks. Playing through an module-virtual-sink would cause slower drains. This fix has two parts: 1) We now refuse to process handed out silence. This has the effect

Re: [pulseaudio-discuss] [PATCH] module-virtual-sink: Speed up draining

2014-10-02 Thread Heero Yui
Thank, you !! I will try it as soon as possible (v3.99, then I will update it.) Thank you again. HY 2014-10-02 15:58 GMT+02:00 David Henningsson < david.hennings...@canonical.com>: > The drain speed increase done a while ago, only worked when directly > connected > to ALSA sinks. Playing throu

Re: [pulseaudio-discuss] [PATCH] module-virtual-sink: Speed up draining

2014-10-02 Thread Alexander E. Patrakov
02.10.2014 21:21, Alexander E. Patrakov wrote: I have looked at the patch, but came to the conclusion that I cannot provide a good review now. Forgot to express one more point clearly: due to not doing any processing, module-virtual-sink is not a good model to test fixes on. This just leads t

Re: [pulseaudio-discuss] [PATCH] module-virtual-sink: Speed up draining

2014-10-02 Thread David Henningsson
On 2014-10-02 17:21, Alexander E. Patrakov wrote: 02.10.2014 19:58, David Henningsson wrote: The drain speed increase done a while ago, only worked when directly connected to ALSA sinks. Playing through an module-virtual-sink would cause slower drains. This fix has two parts: 1) We now refu

Re: [pulseaudio-discuss] [PATCH] module-virtual-sink: Speed up draining

2014-10-02 Thread Alexander E. Patrakov
03.10.2014 06:25, David Henningsson wrote: I'm not sure what you actually mean, since you say that your response is not serious, but there are certainly many cases where underrun before and after filter do happen simultaneously (a simple gain filter, e g), and even more when things happen simulta

Re: [pulseaudio-discuss] [PATCH] module-virtual-sink: Speed up draining

2014-10-03 Thread Heero Yui
In my case when I activate the patch, I can not generate output audio signal when AEC is active.. ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] [PATCH] module-virtual-sink: Speed up draining

2014-10-19 Thread Tanu Kaskinen
On Thu, 2014-10-02 at 15:58 +0200, David Henningsson wrote: > The drain speed increase done a while ago, only worked when directly connected > to ALSA sinks. Playing through an module-virtual-sink would cause slower > drains. What about other virtual sinks? Shouldn't the same fix be applied to th

Re: [pulseaudio-discuss] [PATCH] module-virtual-sink: Speed up draining

2014-10-19 Thread David Henningsson
On 2014-10-19 12:57, Tanu Kaskinen wrote: On Thu, 2014-10-02 at 15:58 +0200, David Henningsson wrote: The drain speed increase done a while ago, only worked when directly connected to ALSA sinks. Playing through an module-virtual-sink would cause slower drains. What about other virtual sinks

Re: [pulseaudio-discuss] [PATCH] module-virtual-sink: Speed up draining

2014-10-19 Thread Alexander E. Patrakov
02.10.2014 19:58, David Henningsson wrote: @@ -216,6 +216,10 @@ static int sink_input_pop_cb(pa_sink_input *i, size_t nbytes, pa_memchunk *chunk pa_memchunk nchunk; pa_sink_render(u->sink, nbytes, &nchunk); +if (nchunk.memblock == u->sink->silence.memblock) { +