On Wed, 01 Nov 2017 13:50:02 +0200, Tanu Kaskinen wrote:
> Thanks! I applied your patch now.
Hi Tanu,
Thanks ! and thanks for your patches on top of it :)
--
Colin
___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
https://
On Tue, 2017-10-31 at 16:20 +0100, Colin Leroy wrote:
> On Mon, 30 Oct 2017 16:15:52 +0200, Tanu Kaskinen wrote:
> > Why does the PavuApplication need to be wrapped in a RefPtr?
>
> To build :)
> This is apparently inherent to overloading Gtk::Application as I get
> compilation errors without it.
On Mon, 30 Oct 2017 16:15:52 +0200, Tanu Kaskinen wrote:
Hi Tanu,
Here's an updated patch and more precise replies to your comments.
> The division of responsibilities isn't always very clean, but I don't
> have ideas for simple fixes for that. I think PavuApplication should
> create the UI and
On 30 October 2017 at 16h15, Tanu Kaskinen wrote:
Hi,
> This is a weird function. [...]
> I think it would be better if this function was only called when the
> caller really wants to apply the heuristics.
I'll update the patch to do that.
Below are answers to the rest of your questions:
> > +
On Thu, 2017-10-26 at 22:28 +0200, Colin Leroy wrote:
> From 2120613fa5bd68ebbdd0e9428357030736fce013 Mon Sep 17 00:00:00 2001
> From: Colin Leroy
> Date: Thu, 26 Oct 2017 22:20:36 +0200
> Subject: [PATCH] Implement single-launch with Gtk::Application
>
> This introduces a new file for clarity. O
Aand, I sent the wrong patch. Here's the correct one.
--
Colin
From 2120613fa5bd68ebbdd0e9428357030736fce013 Mon Sep 17 00:00:00 2001
From: Colin Leroy
Date: Thu, 26 Oct 2017 22:20:36 +0200
Subject: [PATCH] Implement single-launch with Gtk::Application
This introduces a new file for clarit
Hi,
Following my last mail on the subject and having received only positive
reaction, I've implemented single-launch with Gtk::Application.
This introduces a new file for clarity. Options handling changes so
that --tab changes the tab if the window is already opened. Other
options are only used a
