Re: [pulseaudio-discuss] [PATCH] pulse: Fix hole handling in pa_stream_peek().

2012-11-07 Thread Tanu Kaskinen
On Wed, 2012-11-07 at 14:21 +0100, David Henningsson wrote: > On 11/07/2012 09:36 AM, Tanu Kaskinen wrote: > > Previously, if there was a hole in a recording stream, > > pa_stream_peek() would crash. Holes could be handled silently inside > > pa_stream_peek() by generating silence (wouldn't work fo

Re: [pulseaudio-discuss] [PATCH] pulse: Fix hole handling in pa_stream_peek().

2012-11-07 Thread David Henningsson
On 11/07/2012 09:36 AM, Tanu Kaskinen wrote: Previously, if there was a hole in a recording stream, pa_stream_peek() would crash. Holes could be handled silently inside pa_stream_peek() by generating silence (wouldn't work for compressed streams, though) or by skipping any holes. However, I think

[pulseaudio-discuss] [PATCH] pulse: Fix hole handling in pa_stream_peek().

2012-11-07 Thread Tanu Kaskinen
Previously, if there was a hole in a recording stream, pa_stream_peek() would crash. Holes could be handled silently inside pa_stream_peek() by generating silence (wouldn't work for compressed streams, though) or by skipping any holes. However, I think it's better to let the caller decide how the h