[pulseaudio-discuss] [PATCH] raop: Don't use incompatible default sample spec parameters

2014-08-19 Thread Tanu Kaskinen
Since the RAOP sink supports only some formats and channel counts, we shouldn't blindly use pa_core.default_sample_spec. This patch changes things so that we default to PA_SAMPLE_S16NE and 2 channels, and only take the sample rate from pa_core.default_sample_spec. --- src/modules/raop/module-raop-

Re: [pulseaudio-discuss] [PATCH] raop: Don't use incompatible default sample spec parameters

2014-08-19 Thread Tanu Kaskinen
On Tue, 2014-08-19 at 14:08 +0300, Tanu Kaskinen wrote: > Since the RAOP sink supports only some formats and channel counts, we > shouldn't blindly use pa_core.default_sample_spec. This patch changes > things so that we default to PA_SAMPLE_S16NE and 2 channels, and only > take the sample rate from

Re: [pulseaudio-discuss] [PATCH] raop: Don't use incompatible default sample spec parameters

2014-08-19 Thread Colin Guthrie
Tanu Kaskinen wrote on 19/08/14 12:12: > On Tue, 2014-08-19 at 14:08 +0300, Tanu Kaskinen wrote: >> Since the RAOP sink supports only some formats and channel counts, we >> shouldn't blindly use pa_core.default_sample_spec. This patch changes >> things so that we default to PA_SAMPLE_S16NE and 2 ch

Re: [pulseaudio-discuss] [PATCH] raop: Don't use incompatible default sample spec parameters

2014-08-24 Thread Tanu Kaskinen
On Tue, 2014-08-19 at 12:37 +0100, Colin Guthrie wrote: > Tanu Kaskinen wrote on 19/08/14 12:12: > > On Tue, 2014-08-19 at 14:08 +0300, Tanu Kaskinen wrote: > >> Since the RAOP sink supports only some formats and channel counts, we > >> shouldn't blindly use pa_core.default_sample_spec. This patch

Re: [pulseaudio-discuss] [PATCH] raop: Don't use incompatible default sample spec parameters

2014-08-25 Thread Felipe Sateler
On Sun, Aug 24, 2014 at 5:09 AM, Tanu Kaskinen wrote: > On Tue, 2014-08-19 at 12:37 +0100, Colin Guthrie wrote: >> Tanu Kaskinen wrote on 19/08/14 12:12: >> > On Tue, 2014-08-19 at 14:08 +0300, Tanu Kaskinen wrote: >> >> Since the RAOP sink supports only some formats and channel counts, we >> >> s