Re: [pulseaudio-discuss] [PATCH] reserve-monitor: Don't trigger on our own events

2013-01-15 Thread Ian Malone
On 15 January 2013 07:41, Brendan Jones wrote: > On 01/13/2013 03:02 PM, Ian Malone wrote: >> >> On 11 January 2013 14:57, David Henningsson >> wrote: >>> >>> On 01/11/2013 02:37 PM, Brendan Jones wrote: On 01/11/2013 02:04 PM, David Henningsson wrote: > > > This fixes

Re: [pulseaudio-discuss] [PATCH] reserve-monitor: Don't trigger on our own events

2013-01-14 Thread Brendan Jones
On 01/13/2013 03:02 PM, Ian Malone wrote: On 11 January 2013 14:57, David Henningsson wrote: On 01/11/2013 02:37 PM, Brendan Jones wrote: On 01/11/2013 02:04 PM, David Henningsson wrote: This fixes a bug where pulseaudio would give up the device (due to a request from JACK), but then immedi

Re: [pulseaudio-discuss] [PATCH] reserve-monitor: Don't trigger on our own events

2013-01-13 Thread Ian Malone
On 11 January 2013 14:57, David Henningsson wrote: > On 01/11/2013 02:37 PM, Brendan Jones wrote: >> >> On 01/11/2013 02:04 PM, David Henningsson wrote: >>> >>> This fixes a bug where pulseaudio would give up the device (due to >>> a request from JACK), but then immediately grab it again because >

Re: [pulseaudio-discuss] [PATCH] reserve-monitor: Don't trigger on our own events

2013-01-12 Thread David Henningsson
On 01/12/2013 05:49 PM, Tanu Kaskinen wrote: On Sat, 2013-01-12 at 17:36 +0100, David Henningsson wrote: On 01/12/2013 04:46 PM, Tanu Kaskinen wrote: Good point. So, there are two bugs: m->busy isn't initialized properly, and change_cb() is sometimes called even when m->busy doesn't change. W

Re: [pulseaudio-discuss] [PATCH] reserve-monitor: Don't trigger on our own events

2013-01-12 Thread Tanu Kaskinen
On Sat, 2013-01-12 at 17:36 +0100, David Henningsson wrote: > On 01/12/2013 04:46 PM, Tanu Kaskinen wrote: > > Good point. So, there are two bugs: m->busy isn't initialized properly, > > and change_cb() is sometimes called even when m->busy doesn't change. > > Well, I figured that it would be - ma

Re: [pulseaudio-discuss] [PATCH] reserve-monitor: Don't trigger on our own events

2013-01-12 Thread David Henningsson
On 01/12/2013 04:46 PM, Tanu Kaskinen wrote: On Sat, 2013-01-12 at 10:10 +0100, David Henningsson wrote: On 01/11/2013 08:18 PM, Tanu Kaskinen wrote: On Fri, 2013-01-11 at 14:04 +0100, David Henningsson wrote: This fixes a bug where pulseaudio would give up the device (due to a request from JA

Re: [pulseaudio-discuss] [PATCH] reserve-monitor: Don't trigger on our own events

2013-01-12 Thread Tanu Kaskinen
On Sat, 2013-01-12 at 10:10 +0100, David Henningsson wrote: > On 01/11/2013 08:18 PM, Tanu Kaskinen wrote: > > On Fri, 2013-01-11 at 14:04 +0100, David Henningsson wrote: > >> This fixes a bug where pulseaudio would give up the device (due to > >> a request from JACK), but then immediately grab it

Re: [pulseaudio-discuss] [PATCH] reserve-monitor: Don't trigger on our own events

2013-01-12 Thread David Henningsson
On 01/11/2013 08:18 PM, Tanu Kaskinen wrote: On Fri, 2013-01-11 at 14:04 +0100, David Henningsson wrote: This fixes a bug where pulseaudio would give up the device (due to a request from JACK), but then immediately grab it again because the monitor callback fired, telling that the device is now

Re: [pulseaudio-discuss] [PATCH] reserve-monitor: Don't trigger on our own events

2013-01-11 Thread Tanu Kaskinen
On Fri, 2013-01-11 at 14:39 +, Ian Malone wrote: > On 11 January 2013 13:37, Brendan Jones wrote: > > On 01/11/2013 02:04 PM, David Henningsson wrote: > >> > >> This fixes a bug where pulseaudio would give up the device (due to > >> a request from JACK), but then immediately grab it again beca

Re: [pulseaudio-discuss] [PATCH] reserve-monitor: Don't trigger on our own events

2013-01-11 Thread Tanu Kaskinen
On Fri, 2013-01-11 at 14:04 +0100, David Henningsson wrote: > This fixes a bug where pulseaudio would give up the device (due to > a request from JACK), but then immediately grab it again because > the monitor callback fired, telling that the device is now available. > > (Note: the protocol does n

Re: [pulseaudio-discuss] [PATCH] reserve-monitor: Don't trigger on our own events

2013-01-11 Thread David Henningsson
On 01/11/2013 02:37 PM, Brendan Jones wrote: On 01/11/2013 02:04 PM, David Henningsson wrote: This fixes a bug where pulseaudio would give up the device (due to a request from JACK), but then immediately grab it again because the monitor callback fired, telling that the device is now available.

Re: [pulseaudio-discuss] [PATCH] reserve-monitor: Don't trigger on our own events

2013-01-11 Thread Ian Malone
On 11 January 2013 13:37, Brendan Jones wrote: > On 01/11/2013 02:04 PM, David Henningsson wrote: >> >> This fixes a bug where pulseaudio would give up the device (due to >> a request from JACK), but then immediately grab it again because >> the monitor callback fired, telling that the device is n

Re: [pulseaudio-discuss] [PATCH] reserve-monitor: Don't trigger on our own events

2013-01-11 Thread Brendan Jones
On 01/11/2013 02:04 PM, David Henningsson wrote: This fixes a bug where pulseaudio would give up the device (due to a request from JACK), but then immediately grab it again because the monitor callback fired, telling that the device is now available. (Note: the protocol does not specify a timeou

[pulseaudio-discuss] [PATCH] reserve-monitor: Don't trigger on our own events

2013-01-11 Thread David Henningsson
This fixes a bug where pulseaudio would give up the device (due to a request from JACK), but then immediately grab it again because the monitor callback fired, telling that the device is now available. (Note: the protocol does not specify a timeout, i e if pulseaudio is requested to give its devic