Re: [pulseaudio-discuss] [PATCH] sink, source: Rework reconfiguration logic to apply to more than rate

2017-10-20 Thread Tanu Kaskinen
On Mon, 2017-10-16 at 14:33 +0530, Arun Raghavan wrote: > This rejigs the update_rate() logic to encompass changes to the sample > spec as a whole, as well as passthrough status. As a result, > sinks/sources provide a reconfigure() method which allows > reconfiguration as required. > > The behavio

[pulseaudio-discuss] [PATCH] sink, source: Rework reconfiguration logic to apply to more than rate

2017-10-16 Thread Arun Raghavan
This rejigs the update_rate() logic to encompass changes to the sample spec as a whole, as well as passthrough status. As a result, sinks/sources provide a reconfigure() method which allows reconfiguration as required. The behaviour itself is currently unchanged -- alsa-sink/-source do not actuall

Re: [pulseaudio-discuss] [PATCH] sink, source: Rework reconfiguration logic to apply to more than rate

2017-10-16 Thread Arun Raghavan
On Sun, 15 Oct 2017, at 09:45 PM, Tanu Kaskinen wrote: > On Sun, 2017-09-03 at 16:58 +0530, Arun Raghavan wrote: > > @@ -1447,52 +1449,57 @@ int pa_sink_update_rate(pa_sink *s, uint32_t rate, > > bool passthrough) { > > } > > } > > > > -if (PA_UNLIKELY(!pa_sample_rate_valid(rat

Re: [pulseaudio-discuss] [PATCH] sink, source: Rework reconfiguration logic to apply to more than rate

2017-10-15 Thread Tanu Kaskinen
On Sun, 2017-09-03 at 16:58 +0530, Arun Raghavan wrote: > @@ -1447,52 +1449,57 @@ int pa_sink_update_rate(pa_sink *s, uint32_t rate, > bool passthrough) { > } > } > > -if (PA_UNLIKELY(!pa_sample_rate_valid(rate))) > +if (PA_UNLIKELY(!pa_sample_spec_valid(spec))) >

[pulseaudio-discuss] [PATCH] sink, source: Rework reconfiguration logic to apply to more than rate

2017-09-03 Thread Arun Raghavan
This rejigs the update_rate() logic to encompass changes to the sample spec as a whole, as well as passthrough status. As a result, sinks/sources provide a reconfigure() method which allows reconfiguration as required. The behaviour itself is currently unchanged -- alsa-sink/-source do not actuall