05.12.2014 02:06, David Henningsson wrote:
In case PA_MEMPOOL_DISABLE is set, pa_memblock_new_pool can return
NULL. It does not make sense to set up a srbchannel without a shared
memory pool, so just fail in this case.

The patch indeed avoids the assertion failure. Thanks!


Reported-by: Alexander Patrakov <patra...@gmail.com>
Signed-off-by: David Henningsson <david.hennings...@canonical.com>
---
  src/pulsecore/srbchannel.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/src/pulsecore/srbchannel.c b/src/pulsecore/srbchannel.c
index a0f916e..8872a89 100644
--- a/src/pulsecore/srbchannel.c
+++ b/src/pulsecore/srbchannel.c
@@ -231,6 +231,9 @@ pa_srbchannel* pa_srbchannel_new(pa_mainloop_api *m, 
pa_mempool *p) {
      pa_srbchannel* sr = pa_xmalloc0(sizeof(pa_srbchannel));
      sr->mainloop = m;
      sr->memblock = pa_memblock_new_pool(p, -1);
+    if (!sr->memblock)
+        goto fail;
+
      srh = pa_memblock_acquire(sr->memblock);
      pa_zero(*srh);



--
Alexander E. Patrakov
_______________________________________________
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

Reply via email to