Re: [pulseaudio-discuss] [PATCH 2/3] sink: Add some comments about the rewind handling during stream moves.

2011-09-30 Thread Tanu Kaskinen
On Fri, 2011-09-30 at 00:36 +0300, Maarten Bosmans wrote: Warning bikeshed ahead. 2011/9/29 Tanu Kaskinen tanu.kaski...@digia.com: --- src/pulsecore/sink.c | 58 ++ 1 files changed, 58 insertions(+), 0 deletions(-) diff --git

Re: [pulseaudio-discuss] [PATCH 2/3] sink: Add some comments about the rewind handling during stream moves.

2011-09-30 Thread Arun Raghavan
On Fri, 2011-09-30 at 12:32 +0300, Tanu Kaskinen wrote: [...] I'm not against making the comments wider. What width would you be happy with? 100? I propose that something like the following is added to the CodingStyle document so that there won't be any bikeshedding in the future regarding

Re: [pulseaudio-discuss] [PATCH 2/3] sink: Add some comments about the rewind handling during stream moves.

2011-09-30 Thread Tanu Kaskinen
On Fri, 2011-09-30 at 13:31 +0300, Colin Guthrie wrote: 'Twas brillig, and Arun Raghavan at 30/09/11 10:35 did gyre and gimble: On Fri, 2011-09-30 at 12:32 +0300, Tanu Kaskinen wrote: [...] I'm not against making the comments wider. What width would you be happy with? 100? I propose that

[pulseaudio-discuss] [PATCH 2/3] sink: Add some comments about the rewind handling during stream moves.

2011-09-29 Thread Tanu Kaskinen
--- src/pulsecore/sink.c | 58 ++ 1 files changed, 58 insertions(+), 0 deletions(-) diff --git a/src/pulsecore/sink.c b/src/pulsecore/sink.c index a2642b4..53cab32 100644 --- a/src/pulsecore/sink.c +++ b/src/pulsecore/sink.c @@ -2403,6 +2403,46

Re: [pulseaudio-discuss] [PATCH 2/3] sink: Add some comments about the rewind handling during stream moves.

2011-09-29 Thread Maarten Bosmans
Warning bikeshed ahead. 2011/9/29 Tanu Kaskinen tanu.kaski...@digia.com: ---  src/pulsecore/sink.c |   58 ++  1 files changed, 58 insertions(+), 0 deletions(-) diff --git a/src/pulsecore/sink.c b/src/pulsecore/sink.c index a2642b4..53cab32