[pulseaudio-discuss] [PATCH 2/4] Enabled libsoxr resampler backend.

2014-11-11 Thread Andrey Semashev
Also fixed a bug in sample_format_more_precise for 32-bit integer sample formats. --- src/pulsecore/resampler.c | 32 ++-- src/pulsecore/resampler.h | 5 + 2 files changed, 35 insertions(+), 2 deletions(-) diff --git a/src/pulsecore/resampler.c b/src/pulsecore/re

[pulseaudio-discuss] [PATCH 2/4] Enabled libsoxr resampler backend.

2014-11-14 Thread Andrey Semashev
Added ID and names for the resampler presets and also corrected the working sample rate deduction to take the new resampler into account. Removed duplicate condition checks from the deduction code. --- src/pulsecore/resampler.c | 25 - src/pulsecore/resampler.h | 4

[pulseaudio-discuss] [PATCH 2/4] Enabled libsoxr resampler backend.

2015-01-07 Thread Andrey Semashev
Added ID and names for the resampler presets and also corrected the working sample rate deduction to take the new resampler into account. Removed duplicate condition checks from the deduction code. --- src/pulsecore/resampler.c | 23 ++- src/pulsecore/resampler.h | 4 2

[pulseaudio-discuss] [PATCH 2/4] Enabled libsoxr resampler backend.

2015-01-08 Thread Andrey Semashev
Added ID and names for the resampler presets and also updated the working sample rate deduction to take the new resampler into account. --- src/pulsecore/resampler.c | 30 ++ src/pulsecore/resampler.h | 4 2 files changed, 30 insertions(+), 4 deletions(-) diff -

[pulseaudio-discuss] [PATCH 2/4] Enabled libsoxr resampler backend.

2015-01-14 Thread Andrey Semashev
Added ID and names for the resampler presets and also updated the working sample rate deduction to take the new resampler into account. The initial libsoxr backend version does not variable rate resampling, so it is disabled in this case. --- src/pulsecore/resampler.c | 33 +

Re: [pulseaudio-discuss] [PATCH 2/4] Enabled libsoxr resampler backend.

2014-11-12 Thread Peter Meerwald
> Also fixed a bug in sample_format_more_precise for 32-bit integer sample > formats. can you please split out the bug fix as a separate patch? it can be readily applied thanks, p. > --- > src/pulsecore/resampler.c | 32 ++-- > src/pulsecore/resampler.h | 5 +

Re: [pulseaudio-discuss] [PATCH 2/4] Enabled libsoxr resampler backend.

2014-11-12 Thread Andrey Semashev
On Wed, Nov 12, 2014 at 1:03 PM, Peter Meerwald wrote: > >> Also fixed a bug in sample_format_more_precise for 32-bit integer sample >> formats. > > can you please split out the bug fix as a separate patch? > it can be readily applied Ok, will do. ___

Re: [pulseaudio-discuss] [PATCH 2/4] Enabled libsoxr resampler backend.

2015-01-07 Thread David Henningsson
On 2015-01-07 15:08, Andrey Semashev wrote: Added ID and names for the resampler presets and also corrected the working sample rate deduction to take the new resampler into account. Removed duplicate condition checks from the deduction code. --- src/pulsecore/resampler.c | 23 ++

Re: [pulseaudio-discuss] [PATCH 2/4] Enabled libsoxr resampler backend.

2015-01-07 Thread Andrey Semashev
On Wednesday 07 January 2015 15:41:14 David Henningsson wrote: > On 2015-01-07 15:08, Andrey Semashev wrote: > > Added ID and names for the resampler presets and also corrected the > > working sample rate deduction to take the new resampler into account. > > Removed duplicate condition checks from

Re: [pulseaudio-discuss] [PATCH 2/4] Enabled libsoxr resampler backend.

2015-01-07 Thread Peter Meerwald
Hello, > On Wednesday 07 January 2015 15:41:14 David Henningsson wrote: > > On 2015-01-07 15:08, Andrey Semashev wrote: > > > Added ID and names for the resampler presets and also corrected the > > > working sample rate deduction to take the new resampler into account. > > > Removed duplicate cond

Re: [pulseaudio-discuss] [PATCH 2/4] Enabled libsoxr resampler backend.

2015-01-07 Thread Andrey Semashev
On Wed, Jan 7, 2015 at 7:39 PM, Peter Meerwald wrote: >> > > >> > > case PA_RESAMPLER_PEAKS: >> > > -if (a == PA_SAMPLE_S16NE || b == PA_SAMPLE_S16NE) >> > > -work_format = PA_SAMPLE_S16NE; >> > >> > Were the rows above removed on purpose? I suppose the behavi

Re: [pulseaudio-discuss] [PATCH 2/4] Enabled libsoxr resampler backend.

2015-01-12 Thread Peter Meerwald
> Added ID and names for the resampler presets and also updated the working > sample rate deduction to take the new resampler into account. what to do with PA_RESAMPLER_VARIABLE_RATE? resampler_soxr_update_rates() just recreates the context, I guess this will lead to crackling sound (not teste

Re: [pulseaudio-discuss] [PATCH 2/4] Enabled libsoxr resampler backend.

2015-01-13 Thread Peter Meerwald
Hello, On Mon, 12 Jan 2015, Andrey Semashev wrote: re-posting to list, hope that is OK > On Monday 12 January 2015 17:36:19 you wrote: > > > Added ID and names for the resampler presets and also updated the working > > > sample rate deduction to take the new resampler into account. > > what to d

Re: [pulseaudio-discuss] [PATCH 2/4] Enabled libsoxr resampler backend.

2015-01-13 Thread Andrey Semashev
On Tuesday 13 January 2015 17:32:55 you wrote: > Hello, > > On Mon, 12 Jan 2015, Andrey Semashev wrote: > > re-posting to list, hope that is OK > > > On Monday 12 January 2015 17:36:19 you wrote: > > > > Added ID and names for the resampler presets and also updated the > > > > working > > > > sa