Since both cards and sinks can hold references to a port, it makes
sense to reference count them. Although no current implementation
actually has sinks with ports but without a card, it felt wrong
to make it harder to make such an implementation in the future.
Signed-off-by: David Henningsson
On Tue, Nov 08, 2011 at 09:54:01AM +0100, David Henningsson wrote:
On 11/08/2011 09:31 AM, Maarten Bosmans wrote:
That's exactly why you should compile without asserts enable for
production builds.
I'm afraid that approach won't work for Ubuntu - there are way too
many cases where we
Since both cards and sinks can hold references to a port, it makes
sense to reference count them. Although no current implementation
actually has sinks with ports but without a card, it felt wrong
to make it harder to make such an implementation in the future.
Signed-off-by: David Henningsson
On 11/09/2011 01:15 AM, Colin Guthrie wrote:
'Twas brillig, and David Henningsson at 08/11/11 20:17 did gyre and gimble:
In my opinion assertions are proper error handling when the error in
question is a programming error in our own code.
Eh, I'd say proper error handling is to fix our own
'Twas brillig, and David Henningsson at 09/11/11 09:42 did gyre and gimble:
So; I think we've discussed the general case enough, back to where we
started:
I think this is cleaner and gives better error handling:
void foo_free(foo* f)
{
if (!f)
return;
/* Possibly more
On 11/03/2011 07:33 PM, Tanu Kaskinen wrote:
This looks good too. I'd really like the pa_device_port_hashmap_free()
function behavior change to match all other *_free() functions, though.
I do acknowledge the consistency argument, but I think we're over-using
asserts in this project in
2011/11/8 David Henningsson david.hennings...@canonical.com:
On 11/03/2011 07:33 PM, Tanu Kaskinen wrote:
This looks good too. I'd really like the pa_device_port_hashmap_free()
function behavior change to match all other *_free() functions, though.
I do acknowledge the consistency argument,
On Tue, 2011-11-08 at 09:00 +0100, David Henningsson wrote:
On 11/03/2011 07:33 PM, Tanu Kaskinen wrote:
This looks good too. I'd really like the pa_device_port_hashmap_free()
function behavior change to match all other *_free() functions, though.
I do acknowledge the consistency argument,
On 11/08/2011 06:41 PM, Tanu Kaskinen wrote:
On Tue, 2011-11-08 at 09:00 +0100, David Henningsson wrote:
On 11/03/2011 07:33 PM, Tanu Kaskinen wrote:
This looks good too. I'd really like the pa_device_port_hashmap_free()
function behavior change to match all other *_free() functions, though.
This looks good too. I'd really like the pa_device_port_hashmap_free()
function behavior change to match all other *_free() functions, though.
--
Tanu
On Thu, 2011-10-27 at 16:45 +0200, David Henningsson wrote:
Since both cards and sinks can hold references to a port, it makes
sense to
10 matches
Mail list logo
