Re: [pulseaudio-discuss] [PATCH PA1.1 1/2] alsa-sink: add missing header

2012-05-31 Thread Paul Menzel
Dear Eero, Am Donnerstag, den 31.05.2012, 09:42 +0300 schrieb eero.nurkk...@offcode.fi: > Quoting Paul Menzel: > >> #include > >> +#include > > > > Is sorting headers in these blocks useful? > I missed the point about sorting - would you rather want the signal.h > on top of stdio.h maybe? ye

Re: [pulseaudio-discuss] [PATCH PA1.1 1/2] alsa-sink: add missing header

2012-05-30 Thread eero . nurkkala
Quoting Paul Menzel : #include +#include Is sorting headers in these blocks useful? Hi, I missed the point about sorting - would you rather want the signal.h on top of stdio.h maybe? #include It would be great if you could resend as [PATCH v2]. You could also make the commit summar

Re: [pulseaudio-discuss] [PATCH PA1.1 1/2] alsa-sink: add missing header

2012-05-30 Thread Paul Menzel
Dear Eero, thank you for you patch. Am Donnerstag, den 31.05.2012, 07:57 +0300 schrieb eero.nurkk...@offcode.fi: > From: Eero Nurkkala > > Compilation with -DDEBUG_TIMING fails due to a missing header: > > modules/alsa/alsa-sink.c: In function 'check_left_to_play': > modules/alsa/alsa-sink.c:

[pulseaudio-discuss] [PATCH PA1.1 1/2] alsa-sink: add missing header

2012-05-30 Thread eero . nurkkala
From: Eero Nurkkala Compilation with -DDEBUG_TIMING fails due to a missing header: modules/alsa/alsa-sink.c: In function 'check_left_to_play': modules/alsa/alsa-sink.c:453:9: warning: implicit declaration of function 'raise' [-Wimplicit-function-declaration] modules/alsa/alsa-sink.c:453:9: error