Re: [pulseaudio-discuss] [PATCH v2 08/12] pulsecore: Specially mark global mempools

2016-02-16 Thread Ahmed S. Darwish
On Tue, Feb 16, 2016 at 03:17:11PM +0100, David Henningsson wrote: > I probably would just have added a "bool global" directly to > pa_mempool_new instead of creating two extra functions. But this > is probably just a matter of taste. Looks good. > > Reviewed-by: David Henningsson > Thanks; will

Re: [pulseaudio-discuss] [PATCH v2 08/12] pulsecore: Specially mark global mempools

2016-02-16 Thread David Henningsson
I probably would just have added a "bool global" directly to pa_mempool_new instead of creating two extra functions. But this is probably just a matter of taste. Looks good. Reviewed-by: David Henningsson On 2016-02-12 01:18, Ahmed S. Darwish wrote: Color global mempools with a special mark.

[pulseaudio-discuss] [PATCH v2 08/12] pulsecore: Specially mark global mempools

2016-02-11 Thread Ahmed S. Darwish
Color global mempools with a special mark. Almost all pools are now created on a per client basis except the pa_core's mempool, which is shared between all clients. This special marking is needed for handling memfd-backed pools. To avoid fd leaks, memfd pools are registered with the connection ps