Re: [pulseaudio-discuss] [PATCH v2 3/5] replace sink/source SET_STATE handlers with callbacks

2018-03-16 Thread Georg Chini
On 13.03.2018 18:40, Tanu Kaskinen wrote: There are no behaviour changes, the code from almost all the SET_STATE handlers is moved with minimal changes to the newly introduced set_state_in_io_thread() callback. The only exception is module-tunnel, which has to call pa_sink_render() after

Re: [pulseaudio-discuss] [PATCH v2 3/5] replace sink/source SET_STATE handlers with callbacks

2018-03-14 Thread Tanu Kaskinen
On Wed, 2018-03-14 at 01:23 +0300, Raman Shyshniou wrote: > Hello, > > 13.03.2018 20:40, Tanu Kaskinen пишет: > > diff --git a/src/modules/alsa/alsa-sink.c b/src/modules/alsa/alsa-sink.c > > ... > > +/* Called from the IO thread. */ > > +static int sink_set_state_in_io_thread_cb(pa_sink *s,

Re: [pulseaudio-discuss] [PATCH v2 3/5] replace sink/source SET_STATE handlers with callbacks

2018-03-13 Thread Raman Shyshniou
Hello, 13.03.2018 20:40, Tanu Kaskinen пишет: diff --git a/src/modules/alsa/alsa-sink.c b/src/modules/alsa/alsa-sink.c ... +/* Called from the IO thread. */ +static int sink_set_state_in_io_thread_cb(pa_sink *s, pa_sink_state_t new_state) { ... +switch (new_state) { + +case

[pulseaudio-discuss] [PATCH v2 3/5] replace sink/source SET_STATE handlers with callbacks

2018-03-13 Thread Tanu Kaskinen
There are no behaviour changes, the code from almost all the SET_STATE handlers is moved with minimal changes to the newly introduced set_state_in_io_thread() callback. The only exception is module-tunnel, which has to call pa_sink_render() after pa_sink.thread_info.state has been updated. The