Hi Tanu,
On Wed, May 30, 2012 at 6:06 PM, Tanu Kaskinen wrote:
> Ok. Given what I wrote in the previous mail (i.e. you don't need to
> modify pa_sink_input_new(), you only need to initialize the sample spec
> to be valid to avoid the assertion crash), do you agree that it still
> makes sense to
On Wed, 2012-05-30 at 18:01 +0300, Dalleau, Frederic wrote:
> Tanu,
>
> On Wed, May 30, 2012 at 4:03 PM, Tanu Kaskinen wrote:
> > On Wed, 2012-05-30 at 11:36 +0300, Dalleau, Frederic wrote:
> >> At first I considered that loading module loopback with specifying
> >> anything is not really a frequ
Tanu,
On Wed, May 30, 2012 at 4:03 PM, Tanu Kaskinen wrote:
> On Wed, 2012-05-30 at 11:36 +0300, Dalleau, Frederic wrote:
>> At first I considered that loading module loopback with specifying
>> anything is not really a frequent use case. That make a lot of changes
>> to add this feature I think.
On Wed, 2012-05-30 at 11:36 +0300, Dalleau, Frederic wrote:
> PA_SINK_INPUT_FIX_FORMAT doesn't seem to work as expected.
> If I set this flag without defining the sample_spec, I get an assertion
> in pa_sink_input_new when pa_format_info_from_sample_spec is called.
You can probably get around that
Hi Tanu,
Thanks for this review !
On Tue, May 29, 2012 at 2:24 PM, Tanu Kaskinen wrote:
> > +sink = pa_namereg_get_default_sink(m->core);
>
> This still overrides the routing modules, right?
>
> I guess this is done, because otherwise you don't know how to initialize
> ss and map? I thi
On Tue, 2012-04-03 at 17:18 +0200, Frédéric Dalleau wrote:
> At module-loopback load, if no sink is given, the default sink is used. If the
> stream has a media.role property, the property cannot be used because a the
> source or sink is forced to default. Both module-intended-roles and
> module-de
At module-loopback load, if no sink is given, the default sink is used. If the
stream has a media.role property, the property cannot be used because a the
source or sink is forced to default. Both module-intended-roles and
module-device-manager are affected. The same apply to sources.
With this pa
