Re: [pulseaudio-discuss] [PATCH v3 1/3] bluetooth: ofono: Use Acquire method if available

2017-07-21 Thread Tanu Kaskinen
On Fri, 2017-07-21 at 22:24 +0200, Georg Chini wrote: > On 21.07.2017 20:26, Tanu Kaskinen wrote: > > On Fri, 2017-07-21 at 20:58 +0300, Tanu Kaskinen wrote: > > > On Thu, 2017-07-20 at 18:50 +0200, Georg Chini wrote: > > > > On 20.07.2017 16:23, Tanu Kaskinen wrote: > > > > > On Tue, 2017-07-18 at

Re: [pulseaudio-discuss] [PATCH v3 1/3] bluetooth: ofono: Use Acquire method if available

2017-07-21 Thread Georg Chini
On 21.07.2017 20:26, Tanu Kaskinen wrote: On Fri, 2017-07-21 at 20:58 +0300, Tanu Kaskinen wrote: On Thu, 2017-07-20 at 18:50 +0200, Georg Chini wrote: On 20.07.2017 16:23, Tanu Kaskinen wrote: On Tue, 2017-07-18 at 20:16 +0200, Georg Chini wrote: On 17.07.2017 19:44, Tanu Kaskinen wrote: On

Re: [pulseaudio-discuss] [PATCH v3 1/3] bluetooth: ofono: Use Acquire method if available

2017-07-21 Thread Tanu Kaskinen
On Fri, 2017-07-21 at 20:58 +0300, Tanu Kaskinen wrote: > On Thu, 2017-07-20 at 18:50 +0200, Georg Chini wrote: > > On 20.07.2017 16:23, Tanu Kaskinen wrote: > > > On Tue, 2017-07-18 at 20:16 +0200, Georg Chini wrote: > > > > On 17.07.2017 19:44, Tanu Kaskinen wrote: > > > > > On Sun, 2017-07-16 at

Re: [pulseaudio-discuss] [PATCH v3 1/3] bluetooth: ofono: Use Acquire method if available

2017-07-21 Thread Tanu Kaskinen
On Thu, 2017-07-20 at 18:50 +0200, Georg Chini wrote: > On 20.07.2017 16:23, Tanu Kaskinen wrote: > > On Tue, 2017-07-18 at 20:16 +0200, Georg Chini wrote: > > > On 17.07.2017 19:44, Tanu Kaskinen wrote: > > > > On Sun, 2017-07-16 at 14:35 +0200, Georg Chini wrote: > > > > > On 04.07.2017 15:38, Ta

Re: [pulseaudio-discuss] [PATCH v3 1/3] bluetooth: ofono: Use Acquire method if available

2017-07-20 Thread Georg Chini
On 20.07.2017 16:23, Tanu Kaskinen wrote: On Tue, 2017-07-18 at 20:16 +0200, Georg Chini wrote: On 17.07.2017 19:44, Tanu Kaskinen wrote: On Sun, 2017-07-16 at 14:35 +0200, Georg Chini wrote: On 04.07.2017 15:38, Tanu Kaskinen wrote: It looks racy indeed, so some check should be added as you

Re: [pulseaudio-discuss] [PATCH v3 1/3] bluetooth: ofono: Use Acquire method if available

2017-07-20 Thread Tanu Kaskinen
On Tue, 2017-07-18 at 20:16 +0200, Georg Chini wrote: > On 17.07.2017 19:44, Tanu Kaskinen wrote: > > On Sun, 2017-07-16 at 14:35 +0200, Georg Chini wrote: > > > On 04.07.2017 15:38, Tanu Kaskinen wrote: > > > > It looks racy indeed, so some check should be added as you say. When > > > > shutting d

Re: [pulseaudio-discuss] [PATCH v3 1/3] bluetooth: ofono: Use Acquire method if available

2017-07-18 Thread Georg Chini
On 17.07.2017 19:44, Tanu Kaskinen wrote: On Sun, 2017-07-16 at 14:35 +0200, Georg Chini wrote: On 04.07.2017 15:38, Tanu Kaskinen wrote: On Mon, 2017-07-03 at 21:01 +0300, Luiz Augusto von Dentz wrote: Hi Georg, On Mon, Jul 3, 2017 at 8:32 PM, Georg Chini wrote: On 03.07.2017 17:51, Luiz A

Re: [pulseaudio-discuss] [PATCH v3 1/3] bluetooth: ofono: Use Acquire method if available

2017-07-17 Thread Tanu Kaskinen
On Sun, 2017-07-16 at 14:35 +0200, Georg Chini wrote: > On 04.07.2017 15:38, Tanu Kaskinen wrote: > > On Mon, 2017-07-03 at 21:01 +0300, Luiz Augusto von Dentz wrote: > > > Hi Georg, > > > > > > On Mon, Jul 3, 2017 at 8:32 PM, Georg Chini wrote: > > > > On 03.07.2017 17:51, Luiz Augusto von Dentz

Re: [pulseaudio-discuss] [PATCH v3 1/3] bluetooth: ofono: Use Acquire method if available

2017-07-16 Thread Georg Chini
On 04.07.2017 15:38, Tanu Kaskinen wrote: On Mon, 2017-07-03 at 21:01 +0300, Luiz Augusto von Dentz wrote: Hi Georg, On Mon, Jul 3, 2017 at 8:32 PM, Georg Chini wrote: On 03.07.2017 17:51, Luiz Augusto von Dentz wrote: Hi Tanu, On Mon, Jul 3, 2017 at 5:05 PM, Tanu Kaskinen wrote: On Mon,

Re: [pulseaudio-discuss] [PATCH v3 1/3] bluetooth: ofono: Use Acquire method if available

2017-07-04 Thread Tanu Kaskinen
On Mon, 2017-07-03 at 21:01 +0300, Luiz Augusto von Dentz wrote: > Hi Georg, > > On Mon, Jul 3, 2017 at 8:32 PM, Georg Chini wrote: > > On 03.07.2017 17:51, Luiz Augusto von Dentz wrote: > > > > > > Hi Tanu, > > > > > > On Mon, Jul 3, 2017 at 5:05 PM, Tanu Kaskinen wrote: > > > > > > > > On M

Re: [pulseaudio-discuss] [PATCH v3 1/3] bluetooth: ofono: Use Acquire method if available

2017-07-03 Thread Luiz Augusto von Dentz
Hi Georg, On Mon, Jul 3, 2017 at 8:32 PM, Georg Chini wrote: > On 03.07.2017 17:51, Luiz Augusto von Dentz wrote: >> >> Hi Tanu, >> >> On Mon, Jul 3, 2017 at 5:05 PM, Tanu Kaskinen wrote: >>> >>> On Mon, 2017-07-03 at 16:09 +0300, Luiz Augusto von Dentz wrote: Hi Tanu, On Mon

Re: [pulseaudio-discuss] [PATCH v3 1/3] bluetooth: ofono: Use Acquire method if available

2017-07-03 Thread Georg Chini
On 03.07.2017 17:51, Luiz Augusto von Dentz wrote: Hi Tanu, On Mon, Jul 3, 2017 at 5:05 PM, Tanu Kaskinen wrote: On Mon, 2017-07-03 at 16:09 +0300, Luiz Augusto von Dentz wrote: Hi Tanu, On Mon, Jun 19, 2017 at 4:29 PM, Tanu Kaskinen wrote: On Thu, 2017-05-25 at 11:36 +0300, Luiz Augusto v

Re: [pulseaudio-discuss] [PATCH v3 1/3] bluetooth: ofono: Use Acquire method if available

2017-07-03 Thread Luiz Augusto von Dentz
Hi Tanu, On Mon, Jul 3, 2017 at 5:05 PM, Tanu Kaskinen wrote: > On Mon, 2017-07-03 at 16:09 +0300, Luiz Augusto von Dentz wrote: >> Hi Tanu, >> >> On Mon, Jun 19, 2017 at 4:29 PM, Tanu Kaskinen wrote: >> > On Thu, 2017-05-25 at 11:36 +0300, Luiz Augusto von Dentz wrote: >> > > +pa_assert_se(

Re: [pulseaudio-discuss] [PATCH v3 1/3] bluetooth: ofono: Use Acquire method if available

2017-07-03 Thread Tanu Kaskinen
On Mon, 2017-07-03 at 16:09 +0300, Luiz Augusto von Dentz wrote: > Hi Tanu, > > On Mon, Jun 19, 2017 at 4:29 PM, Tanu Kaskinen wrote: > > On Thu, 2017-05-25 at 11:36 +0300, Luiz Augusto von Dentz wrote: > > > +pa_assert_se(m = dbus_message_new_method_call(t->owner, t->path, > > > "org.ofono.

Re: [pulseaudio-discuss] [PATCH v3 1/3] bluetooth: ofono: Use Acquire method if available

2017-07-03 Thread Luiz Augusto von Dentz
Hi Tanu, On Mon, Jun 19, 2017 at 4:29 PM, Tanu Kaskinen wrote: > On Thu, 2017-05-25 at 11:36 +0300, Luiz Augusto von Dentz wrote: >> From: Luiz Augusto von Dentz >> >> Attempt to use Acquire method if available. > > After reading the commit message, I don't know what problem this patch > tries t

Re: [pulseaudio-discuss] [PATCH v3 1/3] bluetooth: ofono: Use Acquire method if available

2017-06-19 Thread Tanu Kaskinen
On Thu, 2017-05-25 at 11:36 +0300, Luiz Augusto von Dentz wrote: > From: Luiz Augusto von Dentz > > Attempt to use Acquire method if available. After reading the commit message, I don't know what problem this patch tries to fix. Please write a more informative commit message. Also, which oFono v

[pulseaudio-discuss] [PATCH v3 1/3] bluetooth: ofono: Use Acquire method if available

2017-05-25 Thread Luiz Augusto von Dentz
From: Luiz Augusto von Dentz Attempt to use Acquire method if available. --- src/modules/bluetooth/backend-ofono.c | 59 +-- 1 file changed, 43 insertions(+), 16 deletions(-) diff --git a/src/modules/bluetooth/backend-ofono.c b/src/modules/bluetooth/backend-ofon