Re: [pulseaudio-discuss] [PATCH v3 3/6] core-util: Make pa_parse_volume() more strict

2015-04-29 Thread Tanu Kaskinen
On Tue, 2015-04-28 at 09:32 +0200, David Henningsson wrote: On 2015-04-27 13:34, Tanu Kaskinen wrote: Previously pa_parse_volume() clamped the value to fit in the valid range, but I think it's better to reject values outside the valid range. It looks like pa_parse_volume is only used

Re: [pulseaudio-discuss] [PATCH v3 3/6] core-util: Make pa_parse_volume() more strict

2015-04-28 Thread David Henningsson
On 2015-04-27 13:34, Tanu Kaskinen wrote: Previously pa_parse_volume() clamped the value to fit in the valid range, but I think it's better to reject values outside the valid range. It looks like pa_parse_volume is only used from module-role-ducking (via pa_modargs_get_value_volume) so I

[pulseaudio-discuss] [PATCH v3 3/6] core-util: Make pa_parse_volume() more strict

2015-04-27 Thread Tanu Kaskinen
Previously pa_parse_volume() clamped the value to fit in the valid range, but I think it's better to reject values outside the valid range. This also changes the percentage parsing to allow non-integer values. --- src/pulsecore/core-util.c | 42 ++ 1 file