Re: [pulseaudio-discuss] [PATCH v4 5/7] bluetooth: Modular API for A2DP codecs

2019-02-03 Thread Pali Rohár
Hi! I fixed some problems in V6. About naming conventions: I have not changed nothing right now. But because function names and parameters does not change code itself, it can be done later if more people agree that it is needed to change. Basically for testing functionality it does not matter if

Re: [pulseaudio-discuss] [PATCH v4 5/7] bluetooth: Modular API for A2DP codecs

2019-02-03 Thread Pali Rohár
On Sunday 27 January 2019 10:59:42 Pali Rohár wrote: > On Thursday 24 January 2019 18:17:08 Pali Rohár wrote: > > On Thursday 24 January 2019 18:54:18 Luiz Augusto von Dentz wrote: > > > > > > +set_params(sbc_info); > > > > > > + > > > > > > +PA_ONCE_BEGIN { > > > > > > +pa_log_debu

Re: [pulseaudio-discuss] [PATCH v4 5/7] bluetooth: Modular API for A2DP codecs

2019-01-27 Thread Pali Rohár
On Thursday 24 January 2019 18:17:08 Pali Rohár wrote: > On Thursday 24 January 2019 18:54:18 Luiz Augusto von Dentz wrote: > > > > > +set_params(sbc_info); > > > > > + > > > > > +PA_ONCE_BEGIN { > > > > > +pa_log_debug("Using SBC codec implementation: %s", > > > > > pa_strnull(sbc

Re: [pulseaudio-discuss] [PATCH v4 5/7] bluetooth: Modular API for A2DP codecs

2019-01-27 Thread Pali Rohár
On Thursday 24 January 2019 17:00:41 Pali Rohár wrote: > On Thursday 24 January 2019 16:03:17 Luiz Augusto von Dentz wrote: > > > @@ -553,14 +626,53 @@ pa_bluetooth_device* > > > pa_bluetooth_discovery_get_device_by_address(pa_bluetooth_d > > > return NULL; > > > } > > > > > > +static char *

Re: [pulseaudio-discuss] [PATCH v4 5/7] bluetooth: Modular API for A2DP codecs

2019-01-24 Thread Pali Rohár
On Thursday 24 January 2019 18:54:18 Luiz Augusto von Dentz wrote: > Hi Pali, > > On Thu, Jan 24, 2019 at 6:00 PM Pali Rohár wrote: > > > > Hi! > > > > On Thursday 24 January 2019 16:03:17 Luiz Augusto von Dentz wrote: > > > On Tue, Jan 15, 2019 at 1:24 AM Pali Rohár wrote: > > > > +typedef stru

Re: [pulseaudio-discuss] [PATCH v4 5/7] bluetooth: Modular API for A2DP codecs

2019-01-24 Thread Luiz Augusto von Dentz
Hi Pali, On Thu, Jan 24, 2019 at 6:00 PM Pali Rohár wrote: > > Hi! > > On Thursday 24 January 2019 16:03:17 Luiz Augusto von Dentz wrote: > > On Tue, Jan 15, 2019 at 1:24 AM Pali Rohár wrote: > > > +typedef struct pa_a2dp_codec_capabilities { > > > +uint8_t size; > > > +uint8_t buffer[];

Re: [pulseaudio-discuss] [PATCH v4 5/7] bluetooth: Modular API for A2DP codecs

2019-01-24 Thread Pali Rohár
Hi! On Thursday 24 January 2019 16:03:17 Luiz Augusto von Dentz wrote: > On Tue, Jan 15, 2019 at 1:24 AM Pali Rohár wrote: > > +typedef struct pa_a2dp_codec_capabilities { > > +uint8_t size; > > +uint8_t buffer[]; /* max size is 254 bytes */ > > +} pa_a2dp_codec_capabilities; > > + > > +t