Re: [pulseaudio-discuss] [PATCH v7 04/13] bluetooth: Modular API for A2DP codecs

2019-04-06 Thread Pali Rohár
Tanu, I think I addressed all review comments in V8 version. Please look at V8. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: PGP signature ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org

Re: [pulseaudio-discuss] [PATCH v7 04/13] bluetooth: Modular API for A2DP codecs

2019-04-05 Thread Pali Rohár
On Friday 05 April 2019 17:14:33 Tanu Kaskinen wrote: > On Fri, 2019-04-05 at 12:36 +0200, Pali Rohár wrote: > > On Thursday 04 April 2019 18:19:32 Tanu Kaskinen wrote: > > > On Sat, 2019-02-23 at 10:45 +0100, Pali Rohár wrote: > > > > + > > > > +/* Initialize codec, returns codec info data

Re: [pulseaudio-discuss] [PATCH v7 04/13] bluetooth: Modular API for A2DP codecs

2019-04-05 Thread Tanu Kaskinen
On Fri, 2019-04-05 at 12:36 +0200, Pali Rohár wrote: > On Thursday 04 April 2019 18:19:32 Tanu Kaskinen wrote: > > On Sat, 2019-02-23 at 10:45 +0100, Pali Rohár wrote: > > > + > > > +/* Initialize codec, returns codec info data and set sample_spec, > > > for_encoding is true when codec_info

Re: [pulseaudio-discuss] [PATCH v7 04/13] bluetooth: Modular API for A2DP codecs

2019-04-05 Thread Pali Rohár
On Thursday 04 April 2019 18:19:32 Tanu Kaskinen wrote: > On Sat, 2019-02-23 at 10:45 +0100, Pali Rohár wrote: > > +typedef struct pa_a2dp_codec { > > +/* Unique name of the codec, lowercase and without whitespaces, used > > for constructing identifier, D-Bus paths, ... */ > > +const char

Re: [pulseaudio-discuss] [PATCH v7 04/13] bluetooth: Modular API for A2DP codecs

2019-04-04 Thread Tanu Kaskinen
On Sat, 2019-02-23 at 10:45 +0100, Pali Rohár wrote: > This patch introduce new modular API for bluetooth A2DP codecs. Its > benefits are: > > * bluez5-util and module-bluez5-device does not contain any codec specific > code, they are codec independent. > > * For adding new A2DP codec it is

[pulseaudio-discuss] [PATCH v7 04/13] bluetooth: Modular API for A2DP codecs

2019-02-23 Thread Pali Rohár
This patch introduce new modular API for bluetooth A2DP codecs. Its benefits are: * bluez5-util and module-bluez5-device does not contain any codec specific code, they are codec independent. * For adding new A2DP codec it is needed just to adjust one table in a2dp-codec-util.c file. All