Re: [pulseaudio-discuss] Suggested coding style change for functions

2013-09-26 Thread Thomas Martitz
Am 23.09.2013 10:37, schrieb Tanu Kaskinen: Quoting the CODING_STYLE file of systemd: - Try to use this: void foo() { } instead of this: void foo() { } But it's OK if you don't. Perhaps we could do it the other way

Re: [pulseaudio-discuss] Suggested coding style change for functions

2013-09-24 Thread João Paulo Rechi Vita
On Mon, Sep 23, 2013 at 7:29 AM, Damir Jelić wrote: > On Mon, Sep 23, 2013 at 11:37:33AM +0300, Tanu Kaskinen wrote: >> On Mon, 2013-09-23 at 10:21 +0200, David Henningsson wrote: >> > On 09/20/2013 11:23 AM, Peter Meerwald wrote: >> > > I think both coding styles are sane and I suggest to NOT con

Re: [pulseaudio-discuss] Suggested coding style change for functions

2013-09-23 Thread Damir Jelić
On Mon, Sep 23, 2013 at 11:37:33AM +0300, Tanu Kaskinen wrote: > On Mon, 2013-09-23 at 10:21 +0200, David Henningsson wrote: > > On 09/20/2013 11:23 AM, Peter Meerwald wrote: > > > I think both coding styles are sane and I suggest to NOT convert to a new > > > style > > > > > > the 'other project

Re: [pulseaudio-discuss] Suggested coding style change for functions

2013-09-23 Thread Tanu Kaskinen
On Mon, 2013-09-23 at 10:21 +0200, David Henningsson wrote: > On 09/20/2013 11:23 AM, Peter Meerwald wrote: > > I think both coding styles are sane and I suggest to NOT convert to a new > > style > > > > the 'other projects' is Gnome? > > Gnome, Linux Kernel, FluidSynth (as mentioned previously)

Re: [pulseaudio-discuss] Suggested coding style change for functions

2013-09-23 Thread David Henningsson
On 09/20/2013 11:23 AM, Peter Meerwald wrote: > >>> Having coding style similar to other projects allow people such as >>> myself to easier move between projects and focus on what's important: >>> features and fixing bugs, rather than having to remember several >>> different coding styles. > >>

Re: [pulseaudio-discuss] Suggested coding style change for functions

2013-09-21 Thread Damir Jelić
On Fri, Sep 20, 2013 at 09:50:27AM -0500, João Paulo Rechi Vita wrote: > On Fri, Sep 20, 2013 at 4:23 AM, Peter Meerwald wrote: > > > >> > Having coding style similar to other projects allow people such as > >> > myself to easier move between projects and focus on what's important: > >> > features

Re: [pulseaudio-discuss] Suggested coding style change for functions

2013-09-20 Thread João Paulo Rechi Vita
On Fri, Sep 20, 2013 at 4:23 AM, Peter Meerwald wrote: > >> > Having coding style similar to other projects allow people such as >> > myself to easier move between projects and focus on what's important: >> > features and fixing bugs, rather than having to remember several >> > different coding st

Re: [pulseaudio-discuss] Suggested coding style change for functions

2013-09-20 Thread Peter Meerwald
> > Having coding style similar to other projects allow people such as > > myself to easier move between projects and focus on what's important: > > features and fixing bugs, rather than having to remember several > > different coding styles. > This is a good enough argument for me, so I'm not a

Re: [pulseaudio-discuss] Suggested coding style change for functions

2013-09-20 Thread Tanu Kaskinen
On Thu, 2013-09-19 at 23:26 +0200, David Henningsson wrote: > Our current coding style currently says this: > > void function(int foo) { > bar(); > } > > I suggest we change it to this: > > void function(int foo) > { > bar(); > } > > To clarify, this only applies to functions, not to if

[pulseaudio-discuss] Suggested coding style change for functions

2013-09-19 Thread David Henningsson
Our current coding style currently says this: void function(int foo) { bar(); } I suggest we change it to this: void function(int foo) { bar(); } To clarify, this only applies to functions, not to if statements, structs or anything else. This is because the latter is more standard: All