[pulseaudio-discuss] systemd socket activation support

2014-10-18 Thread Colin Guthrie
Hi, So while at linux plumbers attending the systemd hackfest, I thought a good use of the hacking time I had available would be to allow PulseAudio to be activated via systemd's socket activation system. The changes needed are actually quite minimal, and by doing this we can disable quite a lot

Re: [pulseaudio-discuss] systemd socket activation support

2014-10-19 Thread Tanu Kaskinen
On Sat, 2014-10-18 at 20:43 +0200, Colin Guthrie wrote: > Hi, > > So while at linux plumbers attending the systemd hackfest, I thought a good > use of the hacking time I had available would be to allow PulseAudio to be > activated via systemd's socket activation system. Great, thanks for the patc

Re: [pulseaudio-discuss] systemd socket activation support

2014-10-19 Thread Peter Meerwald
Hi, > use of the hacking time I had available would be to allow PulseAudio to be > activated via systemd's socket activation system. how does this work relate to the systemd socket activation patches by Campagna / Jardon / Crequy listed on http://www.freedesktop.org/wiki/Software/PulseAudio/Pat

Re: [pulseaudio-discuss] systemd socket activation support

2014-10-20 Thread Colin Guthrie
Peter Meerwald wrote on 19/10/14 22:50: > Hi, > >> use of the hacking time I had available would be to allow PulseAudio to be >> activated via systemd's socket activation system. > > how does this work relate to the systemd socket activation patches by > Campagna / Jardon / Crequy listed on > h

Re: [pulseaudio-discuss] systemd socket activation support

2014-10-20 Thread Colin Guthrie
Tanu Kaskinen wrote on 19/10/14 18:10: > On Sat, 2014-10-18 at 20:43 +0200, Colin Guthrie wrote: >> Hi, >> >> So while at linux plumbers attending the systemd hackfest, I thought a good >> use of the hacking time I had available would be to allow PulseAudio to be >> activated via systemd's socket a

Re: [pulseaudio-discuss] systemd socket activation support

2014-10-23 Thread Jaska Uimonen
Hi Colin, And thanks for the patches, I really need these for Tizen IVI. In my initial testing they seem to work fine, however couple of observations: in socket-server.c the systemd headers are behind the systemd enabler flags (like they should be), but that is behind some HAVE_LIBWRAP thing. I

Re: [pulseaudio-discuss] systemd socket activation support

2014-10-24 Thread Jaska Uimonen
Hello, Colin sorry to drop the comments in pieces... so one more thing: in socket-server.c: in the creation there's always: "s->filename = strdup" but for cleanup you have added: "!s->activated" flag... is the "activated" flag needed for some reason in the cleanup? br, Jaska Quoting Colin G

Re: [pulseaudio-discuss] systemd socket activation support

2014-10-24 Thread Colin Guthrie
Jaska Uimonen wrote on 24/10/14 06:46: > And thanks for the patches, I really need these for Tizen IVI. > > In my initial testing they seem to work fine, however couple > of observations: > > in socket-server.c the systemd headers are behind the systemd > enabler flags (like they should be), but

Re: [pulseaudio-discuss] systemd socket activation support

2014-10-26 Thread Tanu Kaskinen
Sorry for somewhat slow reply... On Mon, 2014-10-20 at 12:02 +0100, Colin Guthrie wrote: > Tanu Kaskinen wrote on 19/10/14 18:10: > > We support non-systemd systems too, so I think the page should be named > > something else than just general "Running", given that the contents are > > only about s