It's possible that the memblockq of a sink input is rewound to a negative read
index if the sink input is moved between sinks shortly after its creation. When
this happens, pa_memblockq_peek() returns a memchunk whose 'memblock' field is
NULL and whose 'length' field indicates the length of the
The assert that this patch fixes can be reproduced with e.g. the
following script:
SAMPLE_PATH=/usr/share/sounds/alsa/
SAMPLE=Front_Left
pactl remove-sample $SAMPLE 2 /dev/null
pactl upload-sample $SAMPLE_PATH$SAMPLE.wav
mod1=`pactl load-module module-null-sink sink_name=null1`
mod2=`pactl
On Thu, 2010-11-18 at 01:58 +0200, Colin Guthrie wrote:
I think this is because it fails the is_suitable_sink() test which IMO
only makes sense in automatic mode. I'll fix that up :)
OK fixed in:
71cb35691ca0ea48dc559a69a554e02dd2ae30f5
Cheers
Col
Yes, I didn't realize that
Hi,
The functionality you suggested sounds good, so I could give it a shot.
I can try to provide another patch sometime next week.
In the meantime, you can merge this one if you see fit.
- A-V
On Fri, 2010-11-12 at 11:15 +0200, Colin Guthrie wrote:
'Twas brillig, and Antti-Ville Jansson at 12
Earlier, if slave sinks were unlinked in non-automatic mode, their
re-appearance was disregarded. Now they are added back to the list of outputs.
Signed-off-by: Antti-Ville Jansson antti-ville.jans...@digia.com
Reviewed-by: Tanu Kaskinen tanu.kaski...@digia.com
---
src/modules/module-combine.c
