Re: [pulseaudio-discuss] [PATCH 3/4] core: no rewinding on volume change if the sink does not support it.

2011-04-11 Thread Jyri Sarha
On Fri, 8 Apr 2011, Colin Guthrie wrote: 'Twas brillig, and o...@iki.fi at 08/04/11 15:18 did gyre and gimble: From: Jyri Sarha jyri.sa...@nokia.com ... Would it not be possible to move this check into the function itself and just make it a noop? The reason for this patch in the first

Re: [pulseaudio-discuss] [PATCH 4/4] alsa-mixer: Add force-hw-volume flag to alsa profile sets

2011-04-11 Thread Jyri Sarha
On Sat, 09 Apr 2011 20:20:40 +0200, David Henningsson david.hennings...@canonical.com wrote: On 2011-04-08 17:18, Colin Guthrie wrote: 'Twas brillig, and o...@iki.fi at 08/04/11 15:18 did gyre and gimble: From: Jyri Sarhajyri.sa...@nokia.com Before this patch, if any of the paths in a path

Re: [pulseaudio-discuss] [PATCH] call-state-tracker: New component.

2011-04-08 Thread Jyri Sarha
that is generic enough. For product specific modules we plan to open source as much as possible in the out of source tree compiled modules [1]. Best regards, Jyri Sarha [1] The source code for the pulseaudio modules mentioned can be found here: http://meego.gitorious.org/maemo-multimedia/pulseaudio-modules

Re: [pulseaudio-discuss] [PATCH] alsa-sink: take base volume into account when applying hw volume

2010-12-01 Thread Jyri Sarha
On Tue, 30 Nov 2010, Colin Guthrie wrote: Any comments on this one Jyri? It seems add code to sink_write_volume_cb() to mirror the normal method sink_set_volume_cb() so looks OK to me but not followed the path through to see if this is supposed to be factored in already in some other way...

Re: [pulseaudio-discuss] [PATCH] alsa-sink: take base volume into account when applying hw volume

2010-12-01 Thread Jyri Sarha
On Wed, 1 Dec 2010, David Henningsson wrote: On 2010-12-01 11:31, Jyri Sarha wrote: Am currently working on a problem caused by safety-margin not taken into account when rewinding. When I get this fixed I'll add a fix for double use bug too. Hmm, for tsched or non-tsched? I think we merged

Re: [pulseaudio-discuss] Compiler optimisation dependency?

2010-10-25 Thread Jyri Sarha
On Sun, 24 Oct 2010, tarantism wrote: I'm building pulse under Scratchbox for Maemo 5 then copying the module-sine.so file to Nokia N900 to test. If I use compiler options -O0 or -O1, it works fine. If I use -O2 or -O3 I just get a sqwarking noise. Any ideas? How does the precompiled

Re: [pulseaudio-discuss] [PATCH 1/5] core: Add infrastructure for synchronizing HW and SW volume changes

2010-10-15 Thread Jyri Sarha
Hi, Review below: 'Twas brillig, and o...@iki.fi at 13/10/10 17:40 did gyre and gimble: +PA_SINK_SYNC_VOLUME = 0x0200U, +/** The HW volume changes are syncronized with SW volume. + * \since X.X.XX */ + } pa_sink_flags_t; Can you put 0.9.22 here? If needed I'll do a global

Re: [pulseaudio-discuss] [PATCH 0/5] HW and SW volume syncronization in IO-thread

2010-10-14 Thread Jyri Sarha
On 2010-10-13 18:40, o...@iki.fi wrote: From: Jyri Sarhajyri.sa...@nokia.com ... Thank you for your work! This is the main reason I've been advocating against enabling flat-volumes by default in Ubuntu, so I'm glad to see something that addresses the issue. The basic problem is that we

Re: [pulseaudio-discuss] [PATCH 0/5] HW and SW volume syncronization in IO-thread

2010-10-14 Thread Jyri Sarha
On 2010-10-13 18:40, o...@iki.fi wrote: From: Jyri Sarhajyri.sa...@nokia.com ... ...rather than trying to add explicit delays just for the volume sync. Either that, or some kind of volume ramping. Just curious if you considered that solution as well? Ah, only after reading my reply from

Re: [pulseaudio-discuss] [PATCH 0/5] HW and SW volume syncronization in IO-thread

2010-10-14 Thread Jyri Sarha
On 2010-10-13 18:40, o...@iki.fi wrote: From: Jyri Sarhajyri.sa...@nokia.com ... Thank you for your work! This is the main reason I've been advocating against enabling flat-volumes by default in Ubuntu, so I'm glad to see something that addresses the issue. The basic problem is that we

Re: [pulseaudio-discuss] [PATCH 0/5] HW and SW volume syncronization in IO-thread

2010-10-14 Thread Jyri Sarha
On 2010-10-13 18:40, o...@iki.fi wrote: From: Jyri Sarhajyri.sa...@nokia.com ... ...rather than trying to add explicit delays just for the volume sync. Either that, or some kind of volume ramping. Just curious if you considered that solution as well? Ah, only after reading my reply from

Re: [pulseaudio-discuss] [PATCH] core: New LIFO style flist implementation v2.0

2010-09-01 Thread Jyri Sarha
On Tue, 31 Aug 2010, Shouqun Liu wrote: After apply this patch, pulseaudio starts with segmentation fault..my pulseadudio version is 0.9.21 thanks Sorry about that. There was a clear bug in the patch. I must have been running different code than I was testing. Any way I have fixed the bug

Re: [pulseaudio-discuss] [PATCH] core: New LIFO style flist implementation

2010-08-23 Thread Jyri Sarha
On Mon, 23 Aug 2010, Shouqun Liu wrote: Hi Jyri, I have applied the patch, but makes no effort to improve the performance, the CPU usage is still high :) Well, I originally created the patch to avoid pulseaudio getting stuck while waiting swapped out memblocks on Nokia N900. After applying

[pulseaudio-discuss] [PATCH] core: New LIFO style flist implementation

2010-08-19 Thread Jyri Sarha
:00 2001 From: Jyri Sarha jyri.sa...@nokia.com Date: Mon, 30 Nov 2009 16:55:27 +0200 Subject: [PATCH] core: New LIFO style flist implementation The old free list implementation used objects in FIFO style. This is bad because it tries keep all the objects ever used alive and in memory. This minimizes

[pulseaudio-discuss] [PATCH 3/5] alsa-sink: Add locking to protect concurrent mixer and mixer_path access

2010-02-28 Thread Jyri Sarha
From: Jyri Sarha jyri.sa...@nokia.com --- src/modules/alsa/alsa-sink.c | 55 ++--- 1 files changed, 51 insertions(+), 4 deletions(-) diff --git a/src/modules/alsa/alsa-sink.c b/src/modules/alsa/alsa-sink.c index 45ba24a..43b0b09 100644 --- a/src/modules

[pulseaudio-discuss] [PATCH 0/5] Synchronize HW and SW volume timing

2010-02-28 Thread Jyri Sarha
From: Jyri Sarha jyri.sa...@nokia.com The first patch here is part of Maemo Fremantle release, so has gone trough considerable amount of testing already. However, the adaptation on top of the latest upstream is fairly recent. Jyri Sarha (5): core: Add infrastructure for delayed HW volume

[pulseaudio-discuss] [PATCH 4/5] udev-detect: Add sync_volume parameter

2010-02-28 Thread Jyri Sarha
From: Jyri Sarha jyri.sa...@nokia.com --- src/modules/module-udev-detect.c | 17 ++--- 1 files changed, 14 insertions(+), 3 deletions(-) diff --git a/src/modules/module-udev-detect.c b/src/modules/module-udev-detect.c index 7695d3c..205c737 100644 --- a/src/modules/module-udev

[pulseaudio-discuss] [PATCH 2/5] alsa-sink: Take syncronized HW volume infra into use

2010-02-28 Thread Jyri Sarha
From: Jyri Sarha jyri.sa...@nokia.com --- src/modules/alsa/alsa-mixer.c | 38 +--- src/modules/alsa/alsa-mixer.h |2 +- src/modules/alsa/alsa-sink.c| 81 +++--- src/modules/alsa/alsa-source.c |2 +- src/modules/alsa

[pulseaudio-discuss] [PATCH 1/5] core: Add infrastructure for delayed HW volume setting

2010-02-28 Thread Jyri Sarha
From: Jyri Sarha jyri.sa...@nokia.com To make concurrent use of SW and HW volume glitchles their application needs to be synchronized. For accurate synchronization the HW volume needs to be applied in IO thread. This patch adds infrastructure to delay the applying of HW volume to match with SW

[pulseaudio-discuss] [PATCH 5/5] alsa-card: Add sync_volume parameter

2010-02-28 Thread Jyri Sarha
From: Jyri Sarha jyri.sa...@nokia.com --- src/modules/alsa/module-alsa-card.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/modules/alsa/module-alsa-card.c b/src/modules/alsa/module-alsa-card.c index 6bea33d..8e613e7 100644 --- a/src/modules/alsa/module-alsa

[pulseaudio-discuss] [PATCH] bluetooth-device: Add safe guard against BT streaming irregularities.

2009-05-13 Thread Jyri Sarha
From: Jyri Sarha jyri.sa...@nokia.com Some bad quality BT-headsets block bluez socket sometimes for hundreds of milliseconds, especially when changing mode. When the module tries catch up the lost time it may SBC encode up to half a second of audio without yielding. On slow machine this may cause

[pulseaudio-discuss] [PATCH] bluetooth-device: Add safe guard against BT streaming irregularities.

2009-05-08 Thread Jyri Sarha
From: Jyri Sarha jyri.sa...@nokia.com Some bad quality BT-headsets block bluez socket sometimes for hundreds of milliseconds, especially when changing mode. When the module tries catch up the lost time it may SBC encode up to half a second of audio without yielding. On slow machine this may cause

[pulseaudio-discuss] [PATCH] bluetooth-device: Add safe guard against BT streaming irregularities.

2009-05-07 Thread Jyri Sarha
Some bad quality BT-headsets block bluez socket sometimes for hundreds of milliseconds, especially when changing mode. When the module tries catch up the lost time it may SBC encode up to half a second of audio without yielding. On slow machine this may cause maximum RT time slice to be exceeded.

[pulseaudio-discuss] [PATCH] optimization: Optimized pa_sink_render_full.

2009-05-07 Thread Jyri Sarha
I have used this fix for quite a while and I am pretty confident about it. However, the performance gain was not what I expected. --- src/pulsecore/sink.c | 78 ++--- 1 files changed, 73 insertions(+), 5 deletions(-) diff --git a/src/pulsecore/sink.c

[pulseaudio-discuss] [PATCH] optimization: Take samples from silence cache rather than write zeros.

2009-05-07 Thread Jyri Sarha
If the only stream to render from is muted take samples from the silence cache. This should shrink memory/cache bandwidth. Again the gain was not what I hoped for. --- src/pulsecore/sink.c | 32 ++-- 1 files changed, 22 insertions(+), 10 deletions(-) diff --git

[pulseaudio-discuss] Atomic operations on ARM

2008-02-01 Thread Jyri Sarha
it may take a while because I am still only learning the autoconf magic and I have some other tasks I should take care of too. Cheers, Jyri // Jyri Sarha -- [EMAIL PROTECTED] ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de

[pulseaudio-discuss] Rendering data from sink with 0.9.7

2007-10-24 Thread Jyri Sarha
, SND_PCM_ACCESS_RW_INTERLEAVED)) 0) goto finish; -else if (*use_mmap) -*use_mmap = 0; if ((ret = set_format(pcm_handle, hwparams, f)) 0) goto finish; \patch Best regards, Jyri // Jyri Sarha - okuAtikiDotfi