Re: [pulseaudio-discuss] [PATCH] core: Drop empty gaps in the memblockq when playing data from it.

2011-04-28 Thread Colin Guthrie
'Twas brillig, and Colin Guthrie at 20/04/11 15:04 did gyre and gimble: > 'Twas brillig, and Antti-Ville Jansson at 20/04/11 14:00 did gyre and > gimble: >> The assert that this patch fixes can be reproduced with e.g. the >> following script: >> >> >> SAMPLE_PATH="/usr/share/sounds/alsa/" >> SAMPLE

Re: [pulseaudio-discuss] [PATCH] core: Drop empty gaps in the memblockq when playing data from it.

2011-04-20 Thread Colin Guthrie
'Twas brillig, and Antti-Ville Jansson at 20/04/11 14:00 did gyre and gimble: > The assert that this patch fixes can be reproduced with e.g. the > following script: > > > SAMPLE_PATH="/usr/share/sounds/alsa/" > SAMPLE="Front_Left" > > pactl remove-sample $SAMPLE 2> /dev/null > pactl upload-sampl

Re: [pulseaudio-discuss] [PATCH] core: Drop empty gaps in the memblockq when playing data from it.

2011-04-20 Thread Antti-Ville Jansson
The assert that this patch fixes can be reproduced with e.g. the following script: SAMPLE_PATH="/usr/share/sounds/alsa/" SAMPLE="Front_Left" pactl remove-sample $SAMPLE 2> /dev/null pactl upload-sample $SAMPLE_PATH$SAMPLE.wav mod1=`pactl load-module module-null-sink sink_name=null1` mod2=`pactl

[pulseaudio-discuss] [PATCH] core: Drop empty gaps in the memblockq when playing data from it.

2011-04-20 Thread Antti-Ville Jansson
It's possible that the memblockq of a sink input is rewound to a negative read index if the sink input is moved between sinks shortly after its creation. When this happens, pa_memblockq_peek() returns a memchunk whose 'memblock' field is NULL and whose 'length' field indicates the length of the gap