[Puppet-dev] [PATCH/facter 1/1] Fixed #3403 - Added fact to query vlans; added spec test

From: Jonas Genannt Signed-off-by: James Turnbull --- lib/facter/util/vlans.rb | 25 + lib/facter/vlans.rb |8 spec/unit/data/linux_vlan_config |6 ++ spec/unit/util/vlans.rb | 14 ++ 4 files changed, 53

Re: [Puppet-dev] [PATCH/puppet 1/1] Fixes #3653 - Changed default factpath value to better reflect plugins in modules

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 24/04/10 5:35 AM, Luke Kanies wrote: > Shouldn't we just s/$vardir\/facts/$vardir\/lib\/facter/g? > I was trying to go for the principle of least surprise and assuming people might have used the default rather than arbitrarily change it. Regards

Re: [Puppet-dev] [PATCH/puppet 1/1] Fixes #3663 - It should be possible to list signed hosts only

Something slightly urks me about this, but I think it's because the overall modeling isn't that great to start, and this just exposes some of that. Really, we should split to 'cert' and 'csr' as separate commands, then this wouldn't be necessary. In the meantime, +1. On Apr 23, 2010, at

Re: [Puppet-dev] [PATCH/puppet 1/1] Fixes #3653 - Changed default factpath value to better reflect plugins in modules

Shouldn't we just s/$vardir\/facts/$vardir\/lib\/facter/g? On Apr 23, 2010, at 11:05 AM, James Turnbull wrote: Signed-off-by: James Turnbull --- lib/puppet/defaults.rb |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/puppet/defaults.rb b/lib/puppet/defaults.rb inde

Re: [Puppet-dev] [PATCH/puppet 1/1] Fixes #3653 - Changed default factpath value to better reflect plugins in modules

On Apr 23, 2010, at 11:09 AM, Nigel Kersten wrote: On Fri, Apr 23, 2010 at 11:05 AM, James Turnbull > wrote: Signed-off-by: James Turnbull --- lib/puppet/defaults.rb |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/puppet/defaults.rb b/lib/puppet/defaults.rb in

Re: [Puppet-dev] [PATCH/puppet 1/1] Fixes #3582 - Adds dbport configuration option for specifying database port

+1, with one question: Is this really "for Client caching"? It's for catalog caching, right? Those docs might need to be fixed. On Apr 22, 2010, at 9:33 PM, James Turnbull wrote: Signed-off-by: James Turnbull --- ext/puppetstoredconfigclean.rb |1 + lib/puppet/defaults.rb |2

[Puppet-dev] [PATCH/puppet 1/1] Fix #3664 - qualified variable parsing in string interpolation

Hi, I'm not sure the fix is 100% correct, but it looks like this fixes the issue. I didn't test anything more complex than my failing test manifests, so it might break everything else :-) Thanks, Brice Original commit msg: "${myclass::var}" was lexed as a CLASSNAME instead of a VARIABLE token,

Re: [Puppet-dev] Any more work needed on 2927?

IMO they should at least be in the Testing branch. On Apr 22, 2010, at 1:25 PM, Trevor Vaughan wrote: Yes, I uploaded the tests and Luke indicated that it was ready to go into testing. They aren't *great* and I can work on those some more, but I'm hoping that it will be adequate for now. Than

Re: [Puppet-dev] [PATCH/puppet 1/1] Fixes #3653 - Changed default factpath value to better reflect plugins in modules

On Fri, Apr 23, 2010 at 11:05 AM, James Turnbull wrote: > > Signed-off-by: James Turnbull > --- > lib/puppet/defaults.rb |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/lib/puppet/defaults.rb b/lib/puppet/defaults.rb > index d333535..2bfb0be 100644 > --- a/lib/pupp

[Puppet-dev] [PATCH/puppet 1/1] Fixes #3653 - Changed default factpath value to better reflect plugins in modules

Signed-off-by: James Turnbull --- lib/puppet/defaults.rb |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/puppet/defaults.rb b/lib/puppet/defaults.rb index d333535..2bfb0be 100644 --- a/lib/puppet/defaults.rb +++ b/lib/puppet/defaults.rb @@ -632,7 +632,7 @@ module Pu

[Puppet-dev] Re: [PATCH/puppet 1/1] Fixes #3663 - It should be possible to list signed hosts only

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 James Turnbull wrote: > Adds a --signed option to the --list feature that only displays signed > certificates I am pretty sure I've got the approach wrong here and I am fairly sure the tests aren't right either. Hopefully can get some feedback from

[Puppet-dev] [PATCH/puppet 1/1] Fixes #3663 - It should be possible to list signed hosts only

Adds a --signed option to the --list feature that only displays signed certificates Signed-off-by: James Turnbull --- lib/puppet/application/puppetca.rb|8 +++- lib/puppet/ssl/certificate_authority/interface.rb |4 +++- spec/unit/application/puppetca.rb

Re: [Puppet-dev] [PATCH/puppet 1/1] Partial fix to #2837 - changed warning message to debug

On Fri, Apr 23, 2010 at 9:48 AM, James Turnbull wrote: > > Signed-off-by: James Turnbull > --- > lib/puppet/network/format_handler.rb |2 +- > spec/unit/network/format_handler.rb |5 +++-- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/lib/puppet/network/format_hand

[Puppet-dev] [PATCH/puppet 1/1] Partial fix to #2837 - changed warning message to debug

Signed-off-by: James Turnbull --- lib/puppet/network/format_handler.rb |2 +- spec/unit/network/format_handler.rb |5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/puppet/network/format_handler.rb b/lib/puppet/network/format_handler.rb index ea8cf35..dce1bca

Re: [Puppet-dev] [PATCH] Fix #3555 - fix state of purged lists

+1 Nice catch on 'insync?' -- Luke Kanies | +1-615-594-8199 On Apr 22, 2010, at 15:25, Peter Meier wrote: > As purged is not contained by default within ensureable we need to > extend the parameter to properly deal with purged lists. > --- > lib/puppet/type/maillist.rb | 10 ++ > 1 fi