Re: [Puppet-dev] [PATCH/puppet 1/1] Part 2 of fix for #1175 (functions in environments)

2010-06-14 Thread Luke Kanies
On Jun 14, 2010, at 10:53 AM, Markus Roberts wrote: On Sat, Jun 12, 2010 at 9:40 PM, Luke Kanies wrote: On Jun 11, 2010, at 4:10 PM, Markus Roberts wrote: Jesse and I are shooting for the minimal viable fix here, with the idea that a great deal of refactoring is needed but isn't appropr

Re: [Puppet-dev] [PATCH/puppet 1/1] Part 2 of fix for #1175 (functions in environments)

2010-06-14 Thread Markus Roberts
commit 43ec46b2cca783a9f08599c70e87d4d8d5ade340 Author: Markus Roberts Date: Mon Jun 14 18:22:40 2010 -0700 Improving fix for #1175; tightening thread safety The previous code maintained thread safety up to work-duplication (so that a collision would, at worse, result in effective

Re: [Puppet-dev] [PATCH/puppet 1/1] Part 2 of fix for #1175 (functions in environments)

2010-06-14 Thread Markus Roberts
On Sat, Jun 12, 2010 at 9:40 PM, Luke Kanies wrote: > On Jun 11, 2010, at 4:10 PM, Markus Roberts wrote: > > Jesse and I are shooting for the minimal viable fix here, with the idea >> that >> a great deal of refactoring is needed but isn't appropriate at this time. >> The >> changes in this com