Re: [Puppet-dev] RBAC for Dashboard and Puppet

2011-03-05 Thread James Turnbull
> I started to say that that would do it but then I got to thinking that > it may conflict with the other resolution rules unless we specified > precedence. A quick search of our documentation turned up no statement > of how we resolve conflicts now, and in various forums we've made > conflicting

Re: [Puppet-dev] RBAC for Dashboard and Puppet

2011-03-05 Thread Markus Roberts
J -- > It occurs to me that the logical extension of a Dashboard RBAC system > > (or perhaps even moving elements of the problem upstream) is for > > auth.conf to recognize users or perhaps better "roles" as an > > authentication construct. > > > > > > I like. There would be some

Re: [Puppet-dev] RBAC for Dashboard and Puppet

2011-03-05 Thread James Turnbull
Markus Roberts wrote: > J -- > > It occurs to me that the logical extension of a Dashboard RBAC system > (or perhaps even moving elements of the problem upstream) is for > auth.conf to recognize users or perhaps better "roles" as an > authentication construct. > > > I like. Ther

[Puppet-dev] [PATCH/puppet 1/2] Refactoring duplicate code and logic in prep for DESTDIR deprecation.

2011-03-05 Thread Elias Lutfallah
DESTDIR is slated to be deprecated. The block of code that checks for DESTDIR contained duplicate code as the block that checks for --destdir. The dupe code has been moved out of the destdir checks. I have also flipped the order of checking. Previously, if the DESTDIR env was set it would be use

[Puppet-dev] [PATCH/puppet 1/2] Refactoring duplicate code and logic in prep for DESTDIR deprecation.

2011-03-05 Thread Elias Lutfallah
DESTDIR is slated to be deprecated. The block of code that checks for DESTDIR contained duplicate code as the block that checks for --destdir. The dupe code has been moved out of the destdir checks. I have also flipped the order of checking. Previously, if the DESTDIR env was set it would be use

[Puppet-dev] [PATCH/puppet 1/2] Refactoring duplicate code and logic in prep for DESTDIR deprecation.

2011-03-05 Thread dontyoumonkeywiththemonkey
From: Elias Lutfallah DESTDIR is slated to be deprecated. The block of code that checks for DESTDIR contained duplicate code as the block that checks for --destdir. The dupe code has been moved out of the destdir checks. I have also flipped the order of checking. Previously, if the DESTDIR env

[Puppet-dev] [PATCH/puppet 2/2] (5724) Prep for deprecation of DESTDIR

2011-03-05 Thread Elias Lutfallah
In preparation of deprecating the DESTDIR env variable, I've added a warning when the DESTDIR variable is being used. Signed-off-by: Elias Lutfallah --- install.rb |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/install.rb b/install.rb index d20b7cd..e8755e0 100755 --- a

[Puppet-dev] [PATCH/puppet 2/2] (5724) Prep for deprecation of DESTDIR

2011-03-05 Thread dontyoumonkeywiththemonkey
From: Elias Lutfallah In preparation of deprecating the DESTDIR env variable, I've added a warning when the DESTDIR variable is being used. Signed-off-by: Elias Lutfallah --- install.rb |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/install.rb b/install.rb index d20b7

[Puppet-dev] [PATCH/puppet 2/2] (5724) Prep for deprecation of DESTDIR

2011-03-05 Thread Elias Lutfallah
In preparation of deprecating the DESTDIR env variable, I've added a warning when the DESTDIR variable is being used. Signed-off-by: Elias Lutfallah --- install.rb |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/install.rb b/install.rb index d20b7cd..e8755e0 100755 --- a

Re: [Puppet-dev] RBAC for Dashboard and Puppet

2011-03-05 Thread Nigel Kersten
On Sat, Mar 5, 2011 at 1:39 PM, Markus Roberts wrote: > J -- > >> It occurs to me that the logical extension of a Dashboard RBAC system >> (or perhaps even moving elements of the problem upstream) is for >> auth.conf to recognize users or perhaps better "roles" as an >> authentication construct. >

Re: [Puppet-dev] RBAC for Dashboard and Puppet

2011-03-05 Thread Markus Roberts
J -- It occurs to me that the logical extension of a Dashboard RBAC system > (or perhaps even moving elements of the problem upstream) is for > auth.conf to recognize users or perhaps better "roles" as an > authentication construct. > I like. There would be some details that should be sorted out

Re: [Puppet-dev] RBAC for Dashboard and Puppet

2011-03-05 Thread Patrick
On Mar 5, 2011, at 12:32 PM, James Turnbull wrote: > Randall's request the other day about Dashboard RBAC prompted some > thoughts about auth in Puppet too. > > Currently API access is controlled via auth.conf: > > # path /path/to/resource > # [environment envlist] > # [method methodlist] > # [

[Puppet-dev] RBAC for Dashboard and Puppet

2011-03-05 Thread James Turnbull
Randall's request the other day about Dashboard RBAC prompted some thoughts about auth in Puppet too. Currently API access is controlled via auth.conf: # path /path/to/resource # [environment envlist] # [method methodlist] # [auth[enthicated] {yes|no|on|off|any}] # allow [host|ip|*] # deny [host|

[Puppet-dev] "Needs Design Decision" state renamed to "Needs Decision"

2011-03-05 Thread James Turnbull
Hi all After some discussion we've decided that "Needs Design Decision" status in the Redmine ticketing system is poorly named. Most of the decisions needed are not in fact Design decisions but also cover product management, code, architecture and other matters. As a result we're going to rename

[Puppet-dev] [PATCH/puppet 1/2] (#6513) Adjust P::U::Settings test name to reflect what it tests

2011-03-05 Thread Jacob Helwig
The 'should interpolate found values using the current environment' wasn't actually testing what it was describing, since the environment variable is special cased. Signed-off-by: Jacob Helwig --- Local branch: ticket/2.6.x/6513-propigate-environment-in-settings-values spec/unit/util/settings_

[Puppet-dev] [PATCH/puppet 2/2] (#6513) Propagate the environment when doing variable lookup in settings

2011-03-05 Thread Jacob Helwig
For example with the following: test.conf: [master] rrddir = /var/lib/puppet/rrd templatedir = /var/lib/puppet/templates [env_a] templatedir = $rrddir/templates rrddir = /tmp/env_a/ The command: RUBYLIB=lib bin/puppet master --config ./test.conf --environment env_a