On Red Hat, Ubuntu, Debian and deriatives the -r flag
allows creation of "system" users with a UID below that
defined in /etc/login.defs.
This commit adds support for a system parameter and a
system_users feature which can be used like so:
user { "foo":
system => true,
ensure => p
On Mar 8, 2011, at 6:09 PM, Nigel Kersten wrote:
> On Tue, Mar 8, 2011 at 6:07 PM, Luke Kanies wrote:
>> On Mar 8, 2011, at 6:05 PM, Nigel Kersten wrote:
>>
>>> On Tue, Mar 8, 2011 at 5:52 PM, Luke Kanies wrote:
Does this use a different db than storeconfigs?
Aren't the facts al
On Tue, Mar 8, 2011 at 6:07 PM, Luke Kanies wrote:
> On Mar 8, 2011, at 6:05 PM, Nigel Kersten wrote:
>
>> On Tue, Mar 8, 2011 at 5:52 PM, Luke Kanies wrote:
>>> Does this use a different db than storeconfigs?
>>>
>>> Aren't the facts already available in storeconfigs?
>>>
>>> This seems an odd c
On Mar 8, 2011, at 6:05 PM, Nigel Kersten wrote:
> On Tue, Mar 8, 2011 at 5:52 PM, Luke Kanies wrote:
>> Does this use a different db than storeconfigs?
>>
>> Aren't the facts already available in storeconfigs?
>>
>> This seems an odd choice, if the answer to both of those questions is yes.
>
On Tue, Mar 8, 2011 at 5:52 PM, Luke Kanies wrote:
> Does this use a different db than storeconfigs?
>
> Aren't the facts already available in storeconfigs?
>
> This seems an odd choice, if the answer to both of those questions is yes.
There was an RFC about this design choice:
http://groups.goo
Does this use a different db than storeconfigs?
Aren't the facts already available in storeconfigs?
This seems an odd choice, if the answer to both of those questions is yes.
On Mar 8, 2011, at 4:48 PM, Nick Lewis wrote:
> So far this terminus only supports find and save. Search is forthcoming.
- Adds support for Slamd64 and Bluewhite64 for the operatingsystem
fact
- Adds support for Slamd64 and Bluewhite64 for the
operatingsystemrelease fact
Signed-off-by: Adrien Thebo
---
Local-branch: tickets/next/2721
lib/facter/operatingsystem.rb|8 ++--
lib/facter/operatin
From: Daniel Pittman
When a new fstab fixture is added, we also want to try to test mount output.
If that fixture is missing, we would have failed a test, but now mark it
pending.
This is more correct when, for example, we don't yet have that fixture: it
isn't technically a failure, just an inco
From: Daniel Pittman
In the final combination test we need to mark Solaris pending, because we
genuinely have a bug where we can't test due to stubbing order.
---
spec/unit/provider/mount/parsed_spec.rb | 11 ---
1 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/spec/unit/
There were some warnings and stack traces in the spec output that aren't
necessary.
The only interesting fix is of the message:
lib/puppet/module.rb:79 warning: multiple values for a block parameter (0 for 1)
from lib/puppet/util/logging.rb:30
If you call any form of logging on a module you e
Timestamps are currently the only supported metadata for searching.
Paired-With: Max Martin
Reviewed-By: Jacob Helwig
Signed-off-by: Nick Lewis
---
.../indirector/facts/inventory_active_record.rb| 42 --
.../facts/inventory_active_record_spec.rb | 89 ---
So far this terminus only supports find and save. Search is forthcoming. It
uses two new tables (inventory_host and inventory_facts) so that it won't
interact with storedconfigs.
Paired-With: Jacob Helwig
Signed-off-by: Nick Lewis
---
.../indirector/facts/inventory_active_record.rb| 33 ++
Paired-With: Max Martin
Reviewed-By: Jacob Helwig
Signed-off-by: Nick Lewis
---
.../indirector/facts/inventory_active_record.rb| 34 +
lib/puppet/rails/inventory_host.rb | 26 ++
.../facts/inventory_active_record_spec.rb | 52 +++
When adding a test for #6309, decided to refactor mount provider
integration tests by adding return value to check_fstab method.
Paired-with:Paul Berry
Signed-off-by: Max Martin
---
spec/integration/provider/mount_spec.rb | 38 ++
1 files changed, 33 insertions(+),
Whoops, a minor typo with rake mail_patches made it look like Why The Lucky
Stiff worked on this patch with us. Sorry to disappoint y'all, it was just
me and Max.
On Tue, Mar 8, 2011 at 3:13 PM, wrote:
> From: Paul Berry
>
> Paired-with: Max Martin
> Signed-off-by: Max Martin
> ---
> spec/i
> Thinking about it though (and after looking at the code), do you need the
>> little bit at the top there to be executed? Why can't you just do something
>> like:
>>
>> Puppet::Util.expects(:execute).with { |command,options| ... }
>>
>>
> This was the first approach I tried. There were three
Hello Puppet Hackers,
We've been doing a lot of working trying to improve the state of
Puppet's test suite lately, so we've been a bit stricter on asking for
good tests with code submissions. We've updated the testing puppet
wiki page with some helpful guidelines, and hopefully made it clearer
how
1. Added tested
2. Refactored to use F:U:R.exec
3. Chomp trailing newline
Signed-off-by: James Turnbull
---
Local-branch: tickets/master/5485
lib/facter/selinux.rb | 11 +++
spec/unit/data/selinux_sestatus |4
spec/unit/selinux_spec.rb | 15 +--
From: Matt Robinson
The structure of the AST has changed from 2.6.x to master, so the code
to generate documentation from the AST had to change.
Generating documentation for resources other than classes, nodes and
defines is still broken, see ticket #6634
Paired-with: Daniel Pittman
Signed-off
From: Matt Robinson
Merging 2.6.next into next caused a regression; this commit fixes that
regression.
Paired-with:Max Martin
Signed-off-by: Max Martin
---
Local-branch: ticket/next/4798-rdoc-fixes
lib/puppet/util/rdoc.rb |1 +
lib/puppet/util/rdoc/parser.rb |
From: Matt Robinson
Paired-with: Daniel Pittman
Signed-off-by: Max Martin
---
Local-branch: ticket/next/4798-rdoc-fixes
lib/puppet/application/doc.rb |8 +---
lib/puppet/defaults.rb|4
2 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/lib/puppet/applicatio
There were some regressions discovered after the merge that these patches fix.
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to puppet-dev@googlegroups.com.
To unsubscribe from this group, send email to
There were two problems:
* In lib/puppet/type/mount.rb, we were calling provider.mounted? to
determine whether we needed to execute "mount" after updating the
in-memory fstab record. This wasn't working properly because
provider.mounted? makes its decision based on the data stored in the
On Mon, Mar 7, 2011 at 7:55 PM, Markus Roberts wrote:
> Thinking about it though (and after looking at the code), do you need the
> little bit at the top there to be executed? Why can't you just do something
> like:
>
> Puppet::Util.expects(:execute).with { |command,options| ... }
>
>
This wa
Garrett Honeycutt wrote:
>
> We currently are not doing validation and do not have all the
> properties listed. I propose that we accept this patch, since it adds
> the rest of the missing properties and create a new ticket to add
> validation to the entirety of the properties. This gives will ens
On Feb 9, 10:21 am, James Turnbull wrote:
> Garrett Honeycutt wrote:
> > * Alphabetized properties
>
> > * Added documentation for acceptable values
>
> > * Added the following properties:
> > atime
> > canmount
> > checksum
> > devices
> > exec
> > logbias
> > nbmand
>
Paul Nasrat wrote:
> +1 been pending for too long
Was that a +1 on patches 2 and 3 in that series also? I largely rewrote
the whole fact.
James
--
James Turnbull
Puppet Labs
1-503-734-8571
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" grou
+1 been pending for too long
On 8 March 2011 10:28, James Turnbull wrote:
> From: Paul Nasrat
>
> The EC2 fact is completely broken at the moment:
>
> * Timeout::Error isn't caught by rescue (due to how it inherits)
> * The issue of wrong open semantics outlined here, this is causing hidden
> i
> - Vendor the "json_shape" library, a lightweight JSON schema validator (
> https://github.com/jes5199/json_shape).
>
> I'm fully in support of this proposal, with one caveat: The definition of
> 'vendor'. Do you mean creating a vendor directly in the puppet repo and
> adding it as a gem there,
The fact now checks for an EC2 ARP or in the EU Zone for an EC2 MAC
This should mean the fact's return is much more robust
The fact also now supports returning userdata (which is a bit ugly
given Facter returns strings but a good bookmark for refactor in 2.0)
Signed-off-by: James Turnbull
---
Lo
From: Paul Nasrat
The EC2 fact is completely broken at the moment:
* Timeout::Error isn't caught by rescue (due to how it inherits)
* The issue of wrong open semantics outlined here, this is causing hidden
immediate failure
* The fact is going to cause a 2 second wait to every facter run
Whils
Added facts arp (like the ipaddress etc) facts
Added facts arp_interfacename
Signed-off-by: James Turnbull
---
Local-branch: tickets/master/2346
lib/facter/arp.rb | 22 ++
lib/facter/util/ip.rb | 11 +--
spec/unit/util/ip_spec.rb | 23 +++
[PATCH/facter 1/3] Discussion on ec2 facts - #2346
[PATCH/facter 2/3] Fixed #2346 - Part 1: Added arp fact for Linux
[PATCH/facter 3/3] Fixed #2346 - A much cleverer EC2 fact
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this g
33 matches
Mail list logo
