Re: [Puppet-dev] [PATCH/puppet 1/1] (#2728) Add diff output for changes made by Augeas provider

2011-03-20 Thread Daniel Pittman
On Sun, Mar 20, 2011 at 21:00, Michael Knox wrote: > On 21/03/11 2:22 PM, Daniel Pittman wrote: >> On Sun, Mar 20, 2011 at 15:31, Michael Knox >>  wrote: >>> On 21/03/11 5:56 AM, Daniel Pittman wrote: […] > Not in the Augeas's 4 save modes, noop, newfile, backup & overwrite. I have > a half writt

Re: [Puppet-dev] [PATCH/puppet 1/1] (#2728) Add diff output for changes made by Augeas provider

2011-03-20 Thread Michael Knox
On 21/03/11 2:22 PM, Daniel Pittman wrote: On Sun, Mar 20, 2011 at 15:31, Michael Knox wrote: On 21/03/11 5:56 AM, Daniel Pittman wrote: Am I correct in understanding that we are writing a temporary copy for the diff, then rewriting the change to the real file separately? Yes If so, could we

[Puppet-dev] [PATCH/puppet 01/23] Fixed #4258 - Added pkgutil package provider

2011-03-20 Thread Juerg Walz
From: James Turnbull Signed-off-by: Juerg Walz --- Local-branch: tickets/master/4258-dev lib/puppet/provider/package/pkgutil.rb | 117 1 files changed, 117 insertions(+), 0 deletions(-) create mode 100644 lib/puppet/provider/package/pkgutil.rb diff --git a/l

[Puppet-dev] [PATCH/puppet 23/23] (#4258) Bug fix: populating instances for aliases

2011-03-20 Thread Juerg Walz
Signed-off-by: Juerg Walz --- Local-branch: tickets/master/4258-dev lib/puppet/provider/package/pkgutil.rb |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/puppet/provider/package/pkgutil.rb b/lib/puppet/provider/package/pkgutil.rb index 350cacc..97625f2 100755 ---

[Puppet-dev] [PATCH/puppet 10/23] These regular expressions will not match anything. pkgutil doesn't output anything that can be matched.

2011-03-20 Thread Juerg Walz
From: rgevaert Signed-off-by: Juerg Walz --- Local-branch: tickets/master/4258-dev lib/puppet/provider/package/pkgutil.rb |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/lib/puppet/provider/package/pkgutil.rb b/lib/puppet/provider/package/pkgutil.rb index 1d699f3..19

[Puppet-dev] [PATCH/puppet 21/23] (#4258) Update pkgutil spec for recent impl changes

2011-03-20 Thread Juerg Walz
From: Dominic Cleal Fix test output of pkgutil for commands using --single Fix expected upgrade command to match impl Signed-off-by: Juerg Walz --- Local-branch: tickets/master/4258-dev spec/unit/provider/package/pkgutil_spec.rb | 22 +- 1 files changed, 9 insertions(+),

[Puppet-dev] [PATCH/puppet 22/23] (#4258) Use pkgutil -a to reliably determine package common names/aliases

2011-03-20 Thread Juerg Walz
From: Dominic Cleal Populate instances with both the real package name ("CSWsvn") and the alias name ("subversion") from separate "pkgutil -a" call. Fixed cases where pkgutil noise was parsed as aliased package names and also breaking "not in catalog" detection. Updated pkgutil_spec test to sho

[Puppet-dev] [PATCH/puppet 19/23] (#4258) pkgutil provider: better handling of short package names

2011-03-20 Thread Juerg Walz
Signed-off-by: Juerg Walz --- Local-branch: tickets/master/4258-dev lib/puppet/provider/package/pkgutil.rb |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/lib/puppet/provider/package/pkgutil.rb b/lib/puppet/provider/package/pkgutil.rb index 0e2056b..4a87932 100755

[Puppet-dev] [PATCH/puppet 20/23] (#4258) pkgutil: bug fix: if shortname is not equal to package name

2011-03-20 Thread Juerg Walz
Signed-off-by: Juerg Walz --- Local-branch: tickets/master/4258-dev lib/puppet/provider/package/pkgutil.rb |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/puppet/provider/package/pkgutil.rb b/lib/puppet/provider/package/pkgutil.rb index 4a87932..3a23796 100755 --

[Puppet-dev] [PATCH/puppet 18/23] (#4258) pkgutil provider: misc enhancements

2011-03-20 Thread Juerg Walz
Several enhancements and bug-fixes for the pkgutil package provider: - handle "Not in catalog" - fix "SAME" version detection - allow short package name (w/o CSW) to match (-> no need to specify a different package name for different operating systems, ex. "ruby") - use the "-u" command line s

[Puppet-dev] [PATCH/puppet 17/23] Add spec tests for pkgutil package provider

2011-03-20 Thread Juerg Walz
From: Dominic Cleal Signed-off-by: Juerg Walz --- Local-branch: tickets/master/4258-dev spec/unit/provider/package/pkgutil_spec.rb | 132 1 files changed, 132 insertions(+), 0 deletions(-) create mode 100755 spec/unit/provider/package/pkgutil_spec.rb diff --git

[Puppet-dev] [PATCH/puppet 14/23] Removing blastwave references and unused PAGER

2011-03-20 Thread Juerg Walz
From: Dominic Cleal Signed-off-by: Juerg Walz --- Local-branch: tickets/master/4258-dev lib/puppet/provider/package/pkgutil.rb | 18 -- 1 files changed, 8 insertions(+), 10 deletions(-) diff --git a/lib/puppet/provider/package/pkgutil.rb b/lib/puppet/provider/package/pkguti

[Puppet-dev] [PATCH/puppet 15/23] Fixing indentation

2011-03-20 Thread Juerg Walz
From: Dominic Cleal Signed-off-by: Juerg Walz --- Local-branch: tickets/master/4258-dev lib/puppet/provider/package/pkgutil.rb |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/puppet/provider/package/pkgutil.rb b/lib/puppet/provider/package/pkgutil.rb index b9

[Puppet-dev] [PATCH/puppet 13/23] Changing indentation to 2-spaces as per 2.6+ style

2011-03-20 Thread Juerg Walz
From: Dominic Cleal Signed-off-by: Juerg Walz --- Local-branch: tickets/master/4258-dev lib/puppet/provider/package/pkgutil.rb | 212 1 files changed, 106 insertions(+), 106 deletions(-) diff --git a/lib/puppet/provider/package/pkgutil.rb b/lib/puppet/provid

[Puppet-dev] [PATCH/puppet 16/23] * Fix exception on parse failure of pkgutil output * Fix exception when querying latest version for unknown package

2011-03-20 Thread Juerg Walz
From: Dominic Cleal Signed-off-by: Juerg Walz --- Local-branch: tickets/master/4258-dev lib/puppet/provider/package/pkgutil.rb | 19 ++- 1 files changed, 6 insertions(+), 13 deletions(-) diff --git a/lib/puppet/provider/package/pkgutil.rb b/lib/puppet/provider/package/pkgut

[Puppet-dev] [PATCH/puppet 09/23] Add comments that explain what we are ignoring in the package and remove legacy output

2011-03-20 Thread Juerg Walz
From: rgevaert Signed-off-by: Juerg Walz --- Local-branch: tickets/master/4258-dev lib/puppet/provider/package/pkgutil.rb |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/puppet/provider/package/pkgutil.rb b/lib/puppet/provider/package/pkgutil.rb index a5f852d

[Puppet-dev] [PATCH/puppet 07/23] Adding patch from Rudy Gevaert to fix not installed detection

2011-03-20 Thread Juerg Walz
From: Dominic Cleal Signed-off-by: Juerg Walz --- Local-branch: tickets/master/4258-dev lib/puppet/provider/package/pkgutil.rb |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/puppet/provider/package/pkgutil.rb b/lib/puppet/provider/package/pkgutil.rb index b8

[Puppet-dev] [PATCH/puppet 12/23] Single package queries made more robust when dealing with pkgutil noise

2011-03-20 Thread Juerg Walz
From: Dominic Cleal Signed-off-by: Juerg Walz --- Local-branch: tickets/master/4258-dev lib/puppet/provider/package/pkgutil.rb | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/puppet/provider/package/pkgutil.rb b/lib/puppet/provider/package/pkgutil.rb inde

[Puppet-dev] [PATCH/puppet 11/23] Fixing wget verbose regex

2011-03-20 Thread Juerg Walz
From: Dominic Cleal Signed-off-by: Juerg Walz --- Local-branch: tickets/master/4258-dev lib/puppet/provider/package/pkgutil.rb |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/puppet/provider/package/pkgutil.rb b/lib/puppet/provider/package/pkgutil.rb index 19a62d

[Puppet-dev] [PATCH/puppet 08/23] Ignoring lines from use_gpg and catalog fetching

2011-03-20 Thread Juerg Walz
From: Dominic Cleal Signed-off-by: Juerg Walz --- Local-branch: tickets/master/4258-dev lib/puppet/provider/package/pkgutil.rb |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/lib/puppet/provider/package/pkgutil.rb b/lib/puppet/provider/package/pkgutil.rb index 05d

[Puppet-dev] [PATCH/puppet 05/23] pkgutil provider: The path to the admin file is /var/opt/csw/pkgutil/admin

2011-03-20 Thread Juerg Walz
From: Maciej Blizinski Signed-off-by: Juerg Walz --- Local-branch: tickets/master/4258-dev lib/puppet/provider/package/pkgutil.rb |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/puppet/provider/package/pkgutil.rb b/lib/puppet/provider/package/pkgutil.rb index

[Puppet-dev] [PATCH/puppet 02/23] Adding pkgutil support.

2011-03-20 Thread Juerg Walz
From: Maciej Blizinski Signed-off-by: Juerg Walz --- Local-branch: tickets/master/4258-dev lib/puppet/provider/package/pkgutil.rb | 111 1 files changed, 111 insertions(+), 0 deletions(-) create mode 100755 lib/puppet/provider/package/pkgutil.rb diff --git a

[Puppet-dev] [PATCH/puppet 06/23] pkgutil provider: Using the --single option which speeds up execution.

2011-03-20 Thread Juerg Walz
From: Maciej Blizinski Signed-off-by: Juerg Walz --- Local-branch: tickets/master/4258-dev lib/puppet/provider/package/pkgutil.rb |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/lib/puppet/provider/package/pkgutil.rb b/lib/puppet/provider/package/pkgutil.rb index 4f

[Puppet-dev] [PATCH/puppet 04/23] pkgutil provider: Correcting a typo in a message.

2011-03-20 Thread Juerg Walz
From: Maciej Blizinski Signed-off-by: Juerg Walz --- Local-branch: tickets/master/4258-dev lib/puppet/provider/package/pkgutil.rb |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/puppet/provider/package/pkgutil.rb b/lib/puppet/provider/package/pkgutil.rb index 39c

[Puppet-dev] [PATCH/puppet 03/23] Using --single in the pkgutil provider.

2011-03-20 Thread Juerg Walz
From: Maciej Blizinski Signed-off-by: Juerg Walz --- Local-branch: tickets/master/4258-dev lib/puppet/provider/package/pkgutil.rb |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/lib/puppet/provider/package/pkgutil.rb b/lib/puppet/provider/package/pkgutil.rb index

[Puppet-dev]

2011-03-20 Thread Juerg Walz
Small bug fix for Dominic Cleals latest changes (to populate pkg instances for aliases): the hash "cloning" didn't work for me as expected: notice: /Stage[main]/Base_system::Common_pkgs/Package[screen]/ensure: is ensure4.0.3,REV=2010.06.08providerpkgutilnameCSWscrn, should be 4.0.3,REV=2010.06.

Re: [Puppet-dev] [PATCH/puppet 1/1] (#2728) Add diff output for changes made by Augeas provider

2011-03-20 Thread Daniel Pittman
On Sun, Mar 20, 2011 at 15:31, Michael Knox wrote: > On 21/03/11 5:56 AM, Daniel Pittman wrote: > > Hey. I love the basic change, but have a few semantic questions that I hope > you can answer more quickly than I could by reading the augeas source. > > Is augeus creating these temporary files in a

Re: [Puppet-dev] [PATCH/puppet 1/1] (#2728) Add diff output for changes made by Augeas provider

2011-03-20 Thread Michael Knox
On 21/03/11 5:56 AM, Daniel Pittman wrote: Hey. I love the basic change, but have a few semantic questions that I hope you can answer more quickly than I could by reading the augeas source. Is augeus creating these temporary files in a way that is safe against symlink attacks and similar se

Re: [Puppet-dev] [PATCH/puppet 1/1] (#2728) Add diff output for changes made by Augeas provider

2011-03-20 Thread Daniel Pittman
Hey. I love the basic change, but have a few semantic questions that I hope you can answer more quickly than I could by reading the augeas source. Is augeus creating these temporary files in a way that is safe against symlink attacks and similar security issues? Am I correct in understanding that

Re: [Puppet-dev] [PATCH/puppet 1/1] Fix #5610: Prevent unnecessary RAL lookups

2011-03-20 Thread Stefan Schulte
On Sun, Mar 20, 2011 at 08:06:56AM -0700, Jesse A Wolfe wrote: > > > > > > Is there a specific reason why uniqueness_key should be a SORTED list of > > keyattributes? If we do not sort them they appear in the array in the > > same order as the params were defined in the type definition (so the > >

Re: [Puppet Users] Re: [Puppet-dev] ANNOUNCE: Puppet 2.6.6 available!

2011-03-20 Thread TJ Yang
On Sun, Mar 20, 2011 at 9:19 AM, Todd Zullinger wrote: > I wrote: >> I plan to get these packages built for Fedora and EPEL 5/6 testing >> repositories in the next few days.  Anyone who finds showstopper bugs >> before then will be my hero for the day. > > Puppet 2.6.6 packages are now in Fedora a

Re: [Puppet-dev] [PATCH/puppet 1/1] Fix #5610: Prevent unnecessary RAL lookups

2011-03-20 Thread Jesse A Wolfe
> > > Is there a specific reason why uniqueness_key should be a SORTED list of > keyattributes? If we do not sort them they appear in the array in the > same order as the params were defined in the type definition (so the > order is still determined) [By type definition I mean the ruby source, > no

Re: [Puppet-dev] ANNOUNCE: Puppet 2.6.6 available!

2011-03-20 Thread Todd Zullinger
I wrote: > I plan to get these packages built for Fedora and EPEL 5/6 testing > repositories in the next few days. Anyone who finds showstopper bugs > before then will be my hero for the day. Puppet 2.6.6 packages are now in Fedora and EPEL testing repositories. Anyone testing these packages is e