Re: [Puppet-dev] [PATCH/puppet 1/1] Fixed #5684 - Move to Apache 2.0 license

2011-04-05 Thread Todd Zullinger
James Turnbull wrote: > --- a/conf/redhat/puppet.spec > +++ b/conf/redhat/puppet.spec > @@ -8,7 +8,7 @@ Name: puppet > Version:2.6.0 > Release:1%{?dist} > Summary:A network tool for managing many disparate systems > -License:GPLv2+ > +License:Apa

[Puppet-dev] [PATCH/puppet 1/1] (#2728) Utilise Augeas SAVE_NEWFILE mode to provide a diff of any changes that augeas will make.

2011-04-05 Thread Michael Knox
Also utilise the *.augnew file so that augeas is only run once if changes are made. Signed-off-by: Mike Knox --- Local-branch: feature/master/2728 lib/puppet/provider/augeas/augeas.rb | 36 +++-- 1 files changed, 29 insertions(+), 7 deletions(-) diff --git a/lib/pu

Re: [Puppet-dev] [PATCH/puppet 1/1] (#4820) - Alert user when mixing special with other time fields in a cron resource

2011-04-05 Thread Daniel Pittman
On Tue, Apr 5, 2011 at 19:20, Nigel Kersten wrote: > On Tue, Apr 5, 2011 at 7:18 PM, Nigel Kersten wrote: >> >> Signed-off-by: Nigel Kersten >> --- >>  lib/puppet/provider/cron/crontab.rb |    3 +++ >>  1 files changed, 3 insertions(+), 0 deletions(-) >> >> diff --git a/lib/puppet/provider/cron/

Re: [Puppet-dev] [PATCH/puppet 1/1] (#4820) - Alert user when mixing special with other time fields in a cron resource

2011-04-05 Thread Nigel Kersten
On Tue, Apr 5, 2011 at 7:18 PM, Nigel Kersten wrote: > > Signed-off-by: Nigel Kersten > --- >  lib/puppet/provider/cron/crontab.rb |    3 +++ >  1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/lib/puppet/provider/cron/crontab.rb > b/lib/puppet/provider/cron/crontab.rb > index 8

[Puppet-dev] [PATCH/puppet 1/1] (#4820) - Alert user when mixing special with other time fields in a cron resource

2011-04-05 Thread Nigel Kersten
Signed-off-by: Nigel Kersten --- lib/puppet/provider/cron/crontab.rb |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/lib/puppet/provider/cron/crontab.rb b/lib/puppet/provider/cron/crontab.rb index 8a347b3..fba65db 100755 --- a/lib/puppet/provider/cron/crontab.rb +++ b

Re: [Puppet-dev]

2011-04-05 Thread Asif Iqbal
On Tue, Apr 5, 2011 at 9:11 PM, Nigel Kersten wrote: > On Mon, Apr 4, 2011 at 7:45 PM, Juerg Walz wrote: >> >> >> This patch adds a check to the pkgutil provider to make sure the wget >> options (in pkgutil.conf) include -nv to give us the optimal level of >> verbosity from wget. >> >> I've mer

Re: [Puppet-dev]

2011-04-05 Thread Nigel Kersten
On Mon, Apr 4, 2011 at 7:45 PM, Juerg Walz wrote: > > > This patch adds a check to the pkgutil provider to make sure the wget options > (in pkgutil.conf) include -nv to give us the optimal level of verbosity from > wget. > > I've merged Dominic Cleal's latest changes before working on this patch

Re: [Puppet-dev] [PATCH/puppet 1/1] (#6885) puppet agent fingerprint requires --verbose to return a value.

2011-04-05 Thread Luke Kanies
On Apr 5, 2011, at 3:55 PM, Ben Hughes wrote: > On Tue, Apr 05, 2011 at 09:35:53AM -0700, Daniel Pittman wrote: > >> I like the general not-stupidness of the patch, but it really should >> go through the standard logging infrastructure, not just call puts. >> We should either raise the level of t

[Puppet-dev] [PATCH/puppet 1/1] (#5528) Add REST API for signing, revoking, retrieving, cleaning certs

2011-04-05 Thread Max Martin
This commit introduces a new Indirector terminus, certificate_status, which allows for signing, revoking, listing, and cleaning SSL certificates over HTTP via REST. Documentation for these new features can be found in our REST API documentation on the docs site: http://docs.puppetlabs.com/guides/r

Re: [Puppet-dev] [PATCH/puppet 1/1] (#6885) puppet agent fingerprint requires --verbose to return a value.

2011-04-05 Thread Ben Hughes
On Tue, Apr 05, 2011 at 09:35:53AM -0700, Daniel Pittman wrote: > I like the general not-stupidness of the patch, but it really should > go through the standard logging infrastructure, not just call puts. > We should either raise the level of the log message so it will display > / record by defaul

Re: [Puppet-dev] Re: [PATCH/puppet 1/1] (#5528) Add REST API for signing, revoking, retrieving, cleaning certs

2011-04-05 Thread Matt Robinson
The current code only returns PSON correctly. I'm putting in a ticket today for fixing problems with YAML and other supported formats. On Tue, Apr 5, 2011 at 12:11 PM, Corey Osman wrote: > Horray!  I am excited to test out the list of signed certificates. > What serialization format would the li

[Puppet-dev] Re: [PATCH/puppet 1/1] (#5528) Add REST API for signing, revoking, retrieving, cleaning certs

2011-04-05 Thread Corey Osman
Horray! I am excited to test out the list of signed certificates. What serialization format would the list of certs be returned as? (PSON, YAML)? Can I have a choice by passing in the format I desire? Corey On Apr 5, 10:47 am, Jacob Helwig wrote: > On Mon, 04 Apr 2011 17:13:02 -0700, Max Mart

Re: [Puppet-dev] [PATCH/puppet 1/1] (#5528) Add REST API for signing, revoking, retrieving, cleaning certs

2011-04-05 Thread Jacob Helwig
On Mon, 04 Apr 2011 17:13:02 -0700, Max Martin wrote: > > This code has not actually been merged yet, but is currently being reviewed > by Jacob Helwig. Matt and I decided to go ahead and send out this e-mail to > see if anyone has comments/suggestions/issues, since this is a pretty big > feature

Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #6974 - Moved to Apache 2.0 license

2011-04-05 Thread Robin Bowes
On 05/04/11 18:44, Matt Robinson wrote: > It would be great if there was some WHY explanation in the commit message. > Yes, I was looking for that. No issues, just curious. R. -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to th

Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #6974 - Moved to Apache 2.0 license

2011-04-05 Thread James Turnbull
Matt Robinson wrote: > It would be great if there was some WHY explanation in the commit message. > So I think we've discussed the why numerous times on the list and off but I will update the message. James -- James Turnbull Puppet Labs 1-503-734-8571 -- You received this message because yo

Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #6974 - Moved to Apache 2.0 license

2011-04-05 Thread Matt Robinson
It would be great if there was some WHY explanation in the commit message. On Tue, Apr 5, 2011 at 10:42 AM, James Turnbull wrote: > > Signed-off-by: James Turnbull > --- > Local-branch: tickets/master/6974 >  COPYING                   |  339 > - >  LI

[Puppet-dev] [PATCH/facter 1/1] Fixed #6974 - Moved to Apache 2.0 license

2011-04-05 Thread James Turnbull
Signed-off-by: James Turnbull --- Local-branch: tickets/master/6974 COPYING | 339 - LICENSE | 24 ++-- README|8 - README.md | 24 +++ README.rst| 26 --

Re: [Puppet-dev] [PATCH/puppet 1/1] (#6885) puppet agent fingerprint requires --verbose to return a value.

2011-04-05 Thread Daniel Pittman
I like the general not-stupidness of the patch, but it really should go through the standard logging infrastructure, not just call puts. We should either raise the level of the log message so it will display / record by default, or perhaps adjust log output levels temporarily. Daniel On Tue, Apr

Re: [Puppet-dev] [PATCH/puppet 1/1] (#6885) puppet agent fingerprint requires --verbose to return a value.

2011-04-05 Thread Ben Hughes
On Tue, Apr 05, 2011 at 04:27:13PM +1000, Ben Hughes wrote: > Always output the fingerprint to STDOUT, no matter what loglevel is used, > as that's the whole purpose of the comment. Ironically, this breaks the unit test entitled "Puppet::Application::Agent when running with --fingerprint should d