Re: [Puppet-dev] [PATCH/puppet 1/1] (#1853) Pacman package provider

2011-05-13 Thread Max Martin
Paul, We really appreciate your work on adding testing for this provider; unfortunately, we are unable to run the tests you wrote on our development machines, as they directly call the pacman command, which is not available on our computers (currently, 15/19 of the tests fail with the message "

Re: [Puppet-dev] [PATCH/puppet-dashboard 1/1] (#5126) Support HTTP basic auth in bin/external_node

2011-05-13 Thread Matt Robinson
Cool, glad to see this getting in. I was about to review it to say it looked good since I had worked on it with you a month ago, but I see it's already been merged with Jacob's review. On Thu, May 12, 2011 at 12:31 PM, nfagerlund wrote: > Although URLs with usernames and passwords were valid in

[Puppet-dev] [PATCH/mcollective 1/1] 7496 - Doc bug in connector_stomp

2011-05-13 Thread R.I.Pienaar
Fix example config for connection pools Signed-off-by: R.I.Pienaar --- Local-branch: ticket/master/7496 website/reference/plugins/connector_stomp.md |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/website/reference/plugins/connector_stomp.md b/website/reference/plu

Re: [Puppet-dev] [PATCH/puppet 2/2] (#7498) Support setting the --in-reply-to flag when using rake mail_patches

2011-05-13 Thread Jacob Helwig
Yeah, gmail makes this a little more difficult than it really needs to be. It'd be nice if you didn't have to go to the more message options menu, "Show Original" then start searching through the raw message to get it, when using the web interface. -- Jacob Helwig On Fri, 13 May 2011 08:11:01 -

[Puppet-dev] Re: [PATCH/puppet 1/1] (#7291) Monkeypatch Symbol class with #sub method in ruby 1.9

2011-05-13 Thread ajsharp
I've included both patches below, with the intention of someone merging in one of the them. The first patch is the Symbol monkeypatch, and the second patch fixes this without a monkey patch to the Symbol class. PATCH 1 === Ruby 1.9 removed Symbol#sub, and it's used in various places in the pu

Re: [Puppet-dev] [PATCH/puppet 2/2] (#7498) Support setting the --in-reply-to flag when using rake mail_patches

2011-05-13 Thread Alex Sharp
The hard part of this is actually getting ahold of the Message-Id header field so you can set the In-Reply-To field :) In the meantime I suppose I'll just paste patches into a reply message. On May 12, 2011, at 2:16 PM, Jacob Helwig wrote: > It's handy to be able to support those people that wi