[Puppet-dev] ANNOUNCE: Puppet Dashboard v1.1.1 Available

2011-05-17 Thread Michael Stahnke
Announcing final release of Dashboard v1.1.1 Downloads Available: = Tarball: http://www.puppetlabs.com/downloads/dashboard/puppet-dashboard-1.1.1.tar.gz RPM: http://www.puppetlabs.com/downloads/dashboard/puppet-dashboard-1.1.1-1.noarch.rpm DEB: http://www.puppetlabs.com/downloads/dashboard/p

[Puppet-dev] [PATCH] maint: fix spec_helper inclusions again.

2011-05-17 Thread Daniel Pittman
We got rid of the '../../spec_helper' style requires, but a few of them snuck back in in recent changes. This purges them out, replaced with the header: #!/usr/bin/env rspec require 'spec_helper' Reviewed-By: Nick Lewis --- spec/unit/application/device_spec.rb |5 ++--

[Puppet-dev] [PATCH/puppet 1/1] (#7507) Add more filters for Ruby 1.9 spec failures

2011-05-17 Thread Pieter van de Bruggen
Paired-With: Matt Robinson Signed-off-by: Pieter van de Bruggen --- Local-branch: tickets/2.7.x/7507 spec/integration/util/file_locking_spec.rb |2 +- spec/unit/indirector/facts/couch_spec.rb |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/integration/util/fi

Re: [Puppet-dev] [PATCH/puppet 1/2] (#7474) Add support for web request type and provider

2011-05-17 Thread Jacob Helwig
On Tue, 17 May 2011 19:24:34 +, Nigel Kersten wrote: > > On Tue, May 17, 2011 at 5:40 AM, Luke Kanies wrote: > > Thanks for the patches. > > > > How do you expect to use this type?  Can you provide some example use cases? > > I also wanted the community to give feedback on the name in > part

Re: [Puppet-dev] [PATCH/puppet 1/2] (#7474) Add support for web request type and provider

2011-05-17 Thread Nigel Kersten
On Tue, May 17, 2011 at 5:40 AM, Luke Kanies wrote: > Thanks for the patches. > > How do you expect to use this type?  Can you provide some example use cases? I also wanted the community to give feedback on the name in particular. I'm not convinced 'web' is the best name for this type, but I can

Ang.: Re: [Puppet-dev] require a gem in facter

2011-05-17 Thread patant
Found the error: require 'rubygems' require 'mygem' Facter.add("myfacter") do setcode do -- This works: Facter.add("myfacter") do require 'rubygems' require 'mygem' setcode do --- -- You received this message because you are subscribed to the Google Groups "Puppet Developers" gro

[Puppet-dev] [PATCH/puppet 2/2] (#7507) Add ability to filter Ruby 1.9 spec failures

2011-05-17 Thread Matt Robinson
By running: rspec spec --tag ~@fails_on_ruby_1.9.2 We can now just run the specs that pass under Ruby 1.9. Obviously in the long term we want to have all the specs passing, but until then we need notification when we regress. From now on new code will be required to pass under Ruby 1.9, and

[Puppet-dev] [PATCH/puppet 6/8] Process name instrumentation listener

2011-05-17 Thread Brice Figureau
This listener changes the current process name in function of what instrumented code is running. If the name is too long, the process name is automatically scrolled to show all the activity. Signed-off-by: Brice Figureau --- .../util/instrumentation/listeners/process_name.rb | 103

[Puppet-dev] [PATCH/puppet 8/8] Example probes for the indirector

2011-05-17 Thread Brice Figureau
This commit adds some instrumentation probes for the various verbs of the indirector. Signed-off-by: Brice Figureau --- lib/puppet/indirector/indirection.rb |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/lib/puppet/indirector/indirection.rb b/lib/puppet/indirecto

[Puppet-dev] [PATCH/puppet 5/8] Add the 'performance' instrumentation listener

2011-05-17 Thread Brice Figureau
This instrumentation listeners accumulates some statistics on the duration and number of calls of a given instrumented code. Signed-off-by: Brice Figureau --- .../util/instrumentation/listeners/performance.rb | 28 +++ .../instrumentation/listeners/performance_spec.rb | 37

[Puppet-dev] [PATCH/puppet 2/8] Add indirection (REST usable) to manipulate instrumentation

2011-05-17 Thread Brice Figureau
This adds two REST API: * /instrumentation_listener(s)/ GET /instrumentation_listener/ Gives details about a given instrumentation listener GET /instrumentation_listeners/unused Lists all instrumentation listeners loaded in the system PUT /instrumentation_listener/name Allows to enable or disabl

[Puppet-dev] [PATCH/puppet 7/8] Add probe indirection for probe management

2011-05-17 Thread Brice Figureau
This allows to enable/disable and list probes either internally or through REST. * GET /instrumentation_probes/all Will return the list of currently defined probes in the running instance * PUT /instrumentation_probes/unused Will enable all probes * DELETE /instrumentation_probes/unused Will dis

[Puppet-dev] [PATCH/puppet 3/8] Add a way to add probe to puppet code

2011-05-17 Thread Brice Figureau
This patch contains a module (Instrumentable) that can be mixed in various puppet classes to help define probes. To add a probe for a given method, it is just a matter of using the Instrumentable probe method: class MyClass extend Instrumentable probe :thismethod def thismethod(arg) ...

[Puppet-dev] [PATCH/puppet 1/8] Instrumentation foundation layer

2011-05-17 Thread Brice Figureau
This is the base of the instrumentation layer. The idea is to allow instrumentation of code blocks. Each time this code is executed an event is fired to some event listeners that in turn can do whatever is needed to perform the instrumentation. This patch adds: * code instrumentation calls * the

[Puppet-dev] [PATCH/puppet 0/8] Puppet Instrumentation Framework, v1.1

2011-05-17 Thread Brice Figureau
Hi, Here is a new version of the Puppet Instrumentation Framework. I believe the patch has now reached the maturity needed to let it live its own life in the Puppet ecosystem. This is mostly the previous patch with all comments taken into account along with some bug fixes. Architecture: The PIF

[Puppet-dev] [PATCH/puppet 4/8] Add the example 'log' listener

2011-05-17 Thread Brice Figureau
This listener stores the last 20 event durations for a given label. It is not terribly useful except giving an idea of the api. Signed-off-by: Brice Figureau --- lib/puppet/util/instrumentation/listeners/log.rb | 24 + .../util/instrumentation/listeners/log_spec.rb | 35 +++

[Puppet-dev] [PATCH/puppet 1/2] (#7507) Fix when_invoked action specs in Ruby 1.9

2011-05-17 Thread Matt Robinson
Ruby 1.9 is strict about argument arity for methods that are metaprogrammatically defined. A ton of specs that were setting up when_invoked didn't pass options even though they should have been. Reviewed-by: Daniel Pittman Signed-off-by: Matt Robinson --- Local-branch: ticket/2.7.x/7507-filter_

Re: [Puppet-dev] require a gem in facter

2011-05-17 Thread Daniel Pittman
On Tue, May 17, 2011 at 00:07, patant wrote: > I'll try this group aswell. > See https://groups.google.com/d/msg/puppet-users/n8Tv4B-G4-g/UwLnQlCTgU0J >  Anyone knows if it's possible to do? So, uh, the answer (or, rather, questions) you got from Matt were pretty apposite. There isn't anything

[Puppet-dev] Re: [PATCH/puppet 1/8] Instrumentation foundation layer

2011-05-17 Thread Josh Cooper
Hi Brice, Thanks for following up with this. We'll take a look at it soon. Please do post the patch to the mailing list. Thanks, Josh On Apr 30, 2:14 pm, Brice Figureau wrote: > Hi Josh, > > On 26/04/11 00:01, Josh Cooper wrote: > > > Jacob and I were going through patches submitted to the mail

[Puppet-dev] require a gem in facter

2011-05-17 Thread patant
I'll try this group aswell. See https://groups.google.com/d/msg/puppet-users/n8Tv4B-G4-g/UwLnQlCTgU0J Anyone knows if it's possible to do? Thanks, Patrik -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email

Re: [Puppet-dev] Re: (#2728) Utilise Augeas SAVE_NEWFILE mode to provide a diff of any changes that augeas will make.

2011-05-17 Thread Michael Knox
Thanks, I've updated my branch based on comments, and it works fine with a dummy manifest that includes a single file change, changes to multiple files and changes to a file with an alternative root. Also cherry-picked Dominic's initial test cases. https://github.com/mikeknox/puppet/tree/feature/m