Re: [Puppet-dev] File mode/owner management

On May 27, 2011, at 12:44 AM, Brice Figureau wrote: > Hi, > > I'm facing a situation I'm not sure exactly how to handle. > I'm trying to come up with a fix for #7106 [1] > > So, the idea is to leverage the FileSetting mode, group and owner system > so that users could do: > > puppet.conf: > las

Re: [Puppet-dev] Re: "Open Source Team" planning meeting summary

Andrew Forgue wrote: > #5517 - behavior change within 2.6 makes it impossible to override class > parameters of "included" parametrized classes > > This bug is almost singlehandedly preventing us from using parameterized > classes. We honestly can't move to 2.7 (and the changes in scope) > without

[Puppet-dev] Re: "Open Source Team" planning meeting summary

Writing this is groups.google.com's interface, pardon the formatting. Some bugs that have been causing us a bit of pain that I would really be happy if they actually got fixed: #3910 - Server is not authoritative over client environment when specified in an ENC This particular bug has been ope

[Puppet-dev] Puppet should correctly support CA trust chains (#3143)

On Tue, 31 May 2011 22:01:15 -0600, Alan Sparks wrote: > > On 5/31/2011 9:07 PM, Jacob Helwig wrote: > > On Tue, 31 May 2011 20:56:47 -0600, Alan Sparks wrote: > >> > >>> On Tue, May 31, 2011 at 5:08 PM, Jacob Helwig >>> > wrote: > >>> > >>> Just a quick reminder

[Puppet-dev] Re: [Puppet Users] Re: "Open Source Team" planning meeting summary

On Tue, 31 May 2011 20:56:47 -0600, Alan Sparks wrote: > > > On Tue, May 31, 2011 at 5:08 PM, Jacob Helwig > > wrote: > > > > Just a quick reminder that we're going to have our planning meeting > > tomorrow. If you'd like to influence what we end up prioriti

Re: [Puppet-dev] [PATCH/puppet 1/2] Fix #7710 - Allow to set any owner/group in file settings

On May 28, 2011, at 8:11 AM, Brice Figureau wrote: > It is impossible to set an owner/group different than root or service > for any file/directory settings (both from defaults or by speficying > those in the configuration file). > This has been introduced in commit 06fcec to prevent users to > se

[Puppet-dev] Re: [Puppet Users] Re: "Open Source Team" planning meeting summary

On Tue, May 31, 2011 at 5:08 PM, Jacob Helwig wrote: > On Thu, 26 May 2011 09:38:28 -0700, Jacob Helwig wrote: > > > > As promised yesterday, here are the results of our first planning > > meeting. > > > > Right now, we're loosely following a Scrum style of development. With > > the current one-w

[Puppet-dev] [PATCH/facter 1/1] (#7726) Fixes output from prtconf inside zone

From: adrienthebo Signed-off-by: Adrien Thebo --- Local-branch: ticket/master/7726 lib/facter/memory.rb |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/facter/memory.rb b/lib/facter/memory.rb index 992f2ad..ef861ad 100644 --- a/lib/facter/memory.rb +++ b/lib/facte

[Puppet-dev] Re: "Open Source Team" planning meeting summary

On Thu, 26 May 2011 09:38:28 -0700, Jacob Helwig wrote: > > As promised yesterday, here are the results of our first planning > meeting. > > Right now, we're loosely following a Scrum style of development. With > the current one-week iteration's backlog outlined below. > > * #2128 - Allow arbit

Re: [Puppet-dev] [PATCH/facter 1/1] Fixes ubuntu detection in facter gem

On Tuesday, May 31, 2011 at 4:27 PM, Luke Kanies wrote: > Doesn't the lsbrelease fact rely on the lsb command, rather than the file? > > > Stig has confirmed that the file is always present, but not (that I know of) > the command. > The ubuntu-minimal package depends on lsb-release, which pro

Re: [Puppet-dev] Re: [PATCH/facter 1/1] Fixes ubuntu detection in facter gem

On May 31, 2011, at 3:23 PM, Stig Sandbeck Mathisen wrote: > Stig Sandbeck Mathisen writes: > >> The "/etc/lsb-release" file is owned by the "base-files" package, >> which has priority "required" on Ubuntu Lucid (latest LTS release) and >> Ubuntu Natty (latest release). It should therefore alway

Re: [Puppet-dev] [PATCH/facter 1/1] Fixes ubuntu detection in facter gem

On May 31, 2011, at 3:53 PM, Nick Lewis wrote: > On Tuesday, May 31, 2011 at 2:24 PM, Ivan Porto Carrero wrote: > >> >> Signed-off-by: Ivan Porto Carrero >> --- >> lib/facter/operatingsystem.rb | 4 >> lib/facter/operatingsystemrelease.rb | 2 +- >> 2 files changed, 5 insertions(+), 1 deleti

Re: [Puppet-dev] [PATCH 1/3] #7211: more helpful error messages in various cases.

On Tue, May 31, 2011 at 15:57, Daniel Pittman wrote: > We were emitting a bunch of unhelpful failure messages, surrounding invalid > actions and especially default actions interacting with the command-line. > > This cleans those up, to give a helpful, informative, and correct message in > all case

[Puppet-dev] [PATCH 2/3] #7211: nasty logic error with global Face options taking arguments.

A logic error meant that global Face options that took arguments were mishandled: we never consumed the argument, so we read this: puppet facts --render-as json find $(hostname) ...as meaning "invoke the 'json' action on the 'facts' face"... This fixes that problem, so we now correctly handl

[Puppet-dev] [PATCH 3/3] #7211: Test unknown options don't shadow unknown actions.

Unknown options used to shadow unknown actions: $ puppet node something_I_cannot_do --unknown-option Could not parse options: invalid option: --unknown-option The earlier changes have fixed this problem, but we now add extra testing to make sure that we don't regress to the earlier state

[Puppet-dev] [PATCH 1/3] #7211: more helpful error messages in various cases.

We were emitting a bunch of unhelpful failure messages, surrounding invalid actions and especially default actions interacting with the command-line. This cleans those up, to give a helpful, informative, and correct message in all cases. Notably, we no longer report that there is no "default" act

Re: [Puppet-dev] [PATCH/facter 1/1] Fixes ubuntu detection in facter gem

On Tuesday, May 31, 2011 at 2:24 PM, Ivan Porto Carrero wrote: > > Signed-off-by: Ivan Porto Carrero (mailto:i...@flanders.co.nz)> > --- > lib/facter/operatingsystem.rb | 4 > lib/facter/operatingsystemrelease.rb | 2 +- > 2 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a

[Puppet-dev] [PATCH/facter 4/4] (#7670) Add an acceptance test

This test runs only on Ubuntu machines and will reproduce the problem with these steps: * load Facter * request the operatingsystem fact * clear Facter * request the operatingsystem fact and verify it is still correct Reviewed-By: Jacob Helwig Signed-off-by: Nick Lewis --- Local-branch

[Puppet-dev] [PATCH/facter 1/4] (#7670) Never fail to find a fact that is present

With the previous behavior, any fact which depended on another fact in a file not matching its name would fail to properly load the required fact, resulting in missing, incorrect, or inconsistent values. For instance, the operatingsystem fact depends on the lsbdistid fact found in lsb.rb. The firs

[Puppet-dev] [PATCH/facter 3/4] maint: Fix spelling of acceptance directory

Signed-off-by: Nick Lewis --- Local-branch: ticket/master/7670 .../ticket_7039_facter_multiple_facts_one_file.rb |0 1 files changed, 0 insertions(+), 0 deletions(-) rename {accecptance => acceptance}/tests/ticket_7039_facter_multiple_facts_one_file.rb (100%) diff --git a/accecptance/tes

[Puppet-dev] [PATCH/facter 2/4] (#7670) Stop preloading all facts in the application

If a requested fact isn't found in the same location as its name, we want to load all of the facts to find it. However, to simplify that, we were previously just preloading all the facts every time. Because requesting a fact now implicitly loads all facts if necessary, we can rely on that, providin

[Puppet-dev] Re: [PATCH/facter 1/1] Fixes ubuntu detection in facter gem

Stig Sandbeck Mathisen writes: > The "/etc/lsb-release" file is owned by the "base-files" package, > which has priority "required" on Ubuntu Lucid (latest LTS release) and > Ubuntu Natty (latest release). It should therefore always be present, > on any Ubuntu installation (excluding administrativ

[Puppet-dev] Re: [PATCH/facter 1/1] Fixes ubuntu detection in facter gem

Daniel Pittman writes: > The change doesn't assume it, because it checks if that file exists, > so it reduces the number of cases things go wrong on Ubuntu ... and I > believe 'ubuntu-minimal' *does* get lsb-bas installed, leading it to > be correct except in cases upstream consider "not Ubuntu"

[Puppet-dev] Re: Fix #6026 - security file should support inline comments

Hi Brice, Can you rebase these changes with the latest 2.7.x branch and resubmit? I merged a change this morning for #5966, which touched the same code in lib/puppet/network/authstore.rb -- the part about only performing global substitution on :dynamic patterns. Thank you, Josh On May 31, 11:07 

Re: [Puppet-dev] Re: [PATCH/puppet 1/1] maint: Fix order dependent test failure

FWIW, this "thread local as quasi-global" behaviour happens in a few other places, too, and leads to strange results. Explicitly passing the desired data is a much better solution; if we need to ensure thread-safe updates in place we should architect around that without using thread storage, in mo

Re: [Puppet-dev] [PATCH/facter 1/1] Fixes ubuntu detection in facter gem

On Tue, May 31, 2011 at 14:30, James Turnbull wrote: > Ivan Porto Carrero wrote: >> Signed-off-by: Ivan Porto Carrero >> --- >>  lib/facter/operatingsystem.rb        |    4 >>  lib/facter/operatingsystemrelease.rb |    2 +- >>  2 files changed, 5 insertions(+), 1 deletions(-) >> >> diff --gi

[Puppet-dev] Re: [PATCH/puppet 1/1] maint: Fix order dependent test failure

Hi Brice, >From what I can tell the cloned list of declarations is only created, referenced, and nil'ed within a single call to Rights#allowed?. So it should be straightforward for Rights#allowed? to clone the declarations and pass that context as an optional argument to its super (AuthStore#allow

Re: [Puppet-dev] [PATCH/facter 1/1] Fixes ubuntu detection in facter gem

Ivan Porto Carrero wrote: > Signed-off-by: Ivan Porto Carrero > --- > lib/facter/operatingsystem.rb|4 > lib/facter/operatingsystemrelease.rb |2 +- > 2 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/lib/facter/operatingsystem.rb b/lib/facter/operatingsystem

[Puppet-dev] [PATCH/facter 1/1] Fixes ubuntu detection in facter gem

Signed-off-by: Ivan Porto Carrero --- lib/facter/operatingsystem.rb|4 lib/facter/operatingsystemrelease.rb |2 +- 2 files changed, 5 insertions(+), 1 deletions(-) diff --git a/lib/facter/operatingsystem.rb b/lib/facter/operatingsystem.rb index a90c283..8381da1 100644 --- a

[Puppet-dev] [PATCH/puppet 3/4] Fix #6026 - security file should support inline comments

Auth.conf, namespaceauth.conf and fileserver.conf were not supporting trailing inlined comments. Also this commit fixes some indentation and error management. Signed-off-by: Brice Figureau --- lib/puppet/file_serving/configuration/parser.rb| 19 ++- lib/puppet/network/authc

[Puppet-dev] [PATCH/puppet 2/4] Fix #5010 - Allow leading whitespace in auth.conf

The regex used to detect ACE is too lax and would allow trailing spaces to sneak in, which in turn would confuse the ACE parser. Signed-off-by: Brice Figureau --- lib/puppet/network/authconfig.rb |2 ++ spec/integration/network/rest_authconfig_spec.rb |1 - spec/unit/netw

[Puppet-dev] [PATCH/puppet 4/4] Refactor: rename RestAuthConfig.allowed? in check_authorization

allowed? was a poorly named method since it doesn't return a boolean. Instead this methods throws an exception when the access is denied (in order to keep the full context of what ACE triggered the deny). Signed-off-by: Brice Figureau --- lib/puppet/network/rest_authconfig.rb|6 +

[Puppet-dev] [PATCH/puppet 1/4] Fix #5777 - rule interpolation broke auth.conf CIDR rules

Due to the interpolation performed to support regex back-references, various type of rules (mainly IP CIDR notations and wildcard hosts) were not working anymore. This patch adds an auth.conf integration test that covers most of the various rules types. Signed-off-by: Brice Figureau --- lib/pup

Re: [Puppet-dev] [PATCH/puppet 1/3] Fix #5777 - rule interpolation broke auth.conf CIDR rules

On 31/05/11 17:54, Jacob Helwig wrote: > On Tue, 31 May 2011 16:35:16 +0200, Brice Figureau wrote: >> >> On Mon, 2011-05-30 at 13:32 -0700, Jacob Helwig wrote: >>> On Mon, 30 May 2011 22:18:47 +0200, Brice Figureau wrote: [ snip ] >> What would you think, if as part of this patch, I rename the meth

Re: [Puppet-dev] [PATCH/puppet 1/1] maint: Fix order dependent test failure

On 31/05/11 19:46, Josh Cooper wrote: > When running spec/unit/network/rights_spec.rb prior to > spec/unit/network/authstore_spec.rb, test failures occur due to the > AuthStore storing Declarations in current thread state. This is a > temporary fix (explicitly clearing thread state for each test ru

[Puppet-dev] [PATCH/puppet 1/1] maint: Fix order dependent test failure

When running spec/unit/network/rights_spec.rb prior to spec/unit/network/authstore_spec.rb, test failures occur due to the AuthStore storing Declarations in current thread state. This is a temporary fix (explicitly clearing thread state for each test run) until the AuthStore can be modified to not

Re: [Puppet-dev] feature (#2247): development

On Mon, May 30, 2011 at 22:06, Nathan Norton wrote: G'day Nathan. > This relates to http://projects.puppetlabs.com/issues/2247 > > Reading the posts in the report above, Nigel stated this feature > could be added as long as it is submitted with tests. > I have essentially got something working h

[Puppet-dev] feature (#2247): development

Hello List, This relates to http://projects.puppetlabs.com/issues/2247 Reading the posts in the report above, Nigel stated this feature could be added as long as it is submitted with tests. I have essentially got something working however the tests are giving me issues. My question relates to t

[Puppet-dev] [PATCH/puppet 1/1] (#2728) Add diff output for changes made by Augeas provider

From: Michael Knox Utilising Augeas's SAVE_NEWFILE mode (similar to augtool -n) to determine the changes that will be made be made by Augeas. Output a unified diff to info handle non-default root, and multiple files correctly Adding tests for Augeas diff functionality Add test for non-default :

[Puppet-dev] [PATCH/mcollective 1/1] 7712 - The exit handler in the application framework should always disconnect

Previously we handled SystemExit but did not disconnect causing EOF Exceptions in the middleware logs. This commit move the disconnect logic into a reusable method and calls it before raising the exit exception again. Signed-off-by: R.I.Pienaar --- Local-branch: bug/master/7712 lib/mcollective/

[Puppet-dev] Re: (#5966) Add support for hostname regular expressions in auth.conf

Hi Siim, Thank you for submitting this patch. I merged your changes to the 2.7.x branch, and in the process I converted the tests to rspec, since we are trying to move away from the Test::Unit ones. I've put the diff of the changes below. Thanks again, Josh diff --git a/spec/unit/network/authsto

Re: [Puppet-dev] [PATCH/puppet 1/3] Fix #5777 - rule interpolation broke auth.conf CIDR rules

On Tue, 31 May 2011 16:35:16 +0200, Brice Figureau wrote: > > On Mon, 2011-05-30 at 13:32 -0700, Jacob Helwig wrote: > > On Mon, 30 May 2011 22:18:47 +0200, Brice Figureau wrote: > > > > > > On 30/05/11 21:26, markus wrote: > > > > B -- > > > > > > > >> +RSpec::Matchers.define :allow do |request

[Puppet-dev] New Puppet report processors...

Hi all On my TODO list for about a year now has been a tutorial on how easy it is to write Puppet report processors and how much more you can do with them than just email/log/store Puppet report data. Rather than write a whole tutorial I decided to create a whole series of examples of report proc

Re: [Puppet-dev] [PATCH/puppet 1/3] Fix #5777 - rule interpolation broke auth.conf CIDR rules

On Mon, 2011-05-30 at 13:32 -0700, Jacob Helwig wrote: > On Mon, 30 May 2011 22:18:47 +0200, Brice Figureau wrote: > > > > On 30/05/11 21:26, markus wrote: > > > B -- > > > > > >> +RSpec::Matchers.define :allow do |request| > > >> + > > >> + match do |auth| > > >> +begin > > >> + auth.a