Re: [Puppet-dev] [PATCH/puppet 1/2] Fix #7710 - Allow to set any owner/group in file settings

2011-06-01 Thread Luke Kanies
On Jun 1, 2011, at 2:05 AM, Brice Figureau wrote: > On Tue, 2011-05-31 at 19:59 -0700, Luke Kanies wrote: >> On May 28, 2011, at 8:11 AM, Brice Figureau wrote: >> >>> It is impossible to set an owner/group different than root or service >>> for any file/directory settings (both from defaults or b

[Puppet-dev] [PATCH 2/3] (#7683) Add a 'man' face and subcommand to Puppet.

2011-06-01 Thread Daniel Pittman
This is the minimal wrapper, cloning a good deal of the logic from help, that runs our face through the 'man' template and returns ronn-formatted Markdown. This provides the crudest baseline possible for getting man-style output, but lets us move forward to improve behaviour. Reviewed-By: Nick Fa

[Puppet-dev] [PATCH 3/3] (#7683) Use ronn, when available, to render the output.

2011-06-01 Thread Daniel Pittman
We now look for ronn(1), and if it is available ask it to generate the *roff output, delegate that to man(1) directly, and show the result to the user in their pager. If ronn(1) isn't available we delegate to $MANPAGER, $PAGER, less, most, or more, in that order, to paginate the raw markdown. Not

[Puppet-dev] [PATCH 1/3] maint: remove obsolete work-around code from help face.

2011-06-01 Thread Daniel Pittman
The application wrapper for help used to disable the inherited 'render' method from FaceBase - specifically, to avoid the behaviour of rendering strings poorly. Now that we have support for good output in the upstream method, this is unnecessary, so we can eliminate the stub method entirely and us

[Puppet-dev] "Open Source Team" planning meeting summary 2011-06-1

2011-06-01 Thread Jacob Helwig
Thanks to everyone that provided their feedback on what they would like to see worked on. We've gone through the suggestions, and re-prioritized our back-log to take into account the various suggestions, and the state of each of the tickets. Next week, I don't plan on directly soliciting with a "

Re: [Puppet-dev] [PATCH/puppet 1/1] (#6857) Password disclosure when changing a user's password

2011-06-01 Thread Jacob Helwig
Ben paired with Josh and I on writing the tests for this. -- Jacob Helwig On Wed, 01 Jun 2011 14:06:51 -0700, Ben Hughes wrote: > > Make the should_to_s and is_to_s functions to return a form of 'redacted'. > > Rather than send the password hash to system logs in cases of failure or > running

[Puppet-dev] [PATCH/puppet 1/1] (#6857) Password disclosure when changing a user's password

2011-06-01 Thread Ben Hughes
Make the should_to_s and is_to_s functions to return a form of 'redacted'. Rather than send the password hash to system logs in cases of failure or running in --noop mode, just state whether it's the new or old hash. We're already doing this with password changes that work, so this just brings it

[Puppet-dev] [PATCH] (#7699) Don't duplicate inherited action names on faces.

2011-06-01 Thread Daniel Pittman
We earlier moved to duplicating Action objects in the Faces subsystem to ensure they had the correct binding context during execution and introspection. This was correct, but introduced a bug where we would report both the parent and child binding as separate entries with duplicate names, in the l

[Puppet-dev] Re: [Puppet Users] Re: "Open Source Team" planning meeting summary

2011-06-01 Thread Peter Meier
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi First, I would like to thank for that open process and the commitment you are putting into that. And I'm really excited that there is now a team dedicated to address the things in core puppet. Awesome! Thanks! However, as this thread seemed to bec

[Puppet-dev] [PATCH 2/2] (#7177) Deprecate implicit 'puppet apply' for 2.7.0

2011-06-01 Thread Daniel Pittman
Back in prehistory (eg: 0.25 era), 'puppet' was the name for the agent, and could be used directly to apply a manifest as well as to communicate with the puppet master process. During the 2.6 series we moved to a single binary, but continued to support older scripts by detecting invocations that l

[Puppet-dev] [PATCH 1/2] (#7717) Layout cleanup for subcommand extraction.

2011-06-01 Thread Daniel Pittman
This transforms the layout of the code, to make it easier to work with, but makes no functional changes. Done separately to make clearer the functional changes vs the non-functional changes. --- lib/puppet/util/command_line.rb | 16 +++- 1 files changed, 11 insertions(+), 5 deletion

[Puppet-dev] Re: [PATCH/puppet 1/2] (#7474) Add support for web request type and provider

2011-06-01 Thread Mo
On May 27, 1:09 am, Michael Stahnke wrote: > I have a concern with this type, but it's more generic and not your > implementation. > > The basic premise is that if you gather a resource externally from puppet's > catalog, that resource can change, but the catalog might not. > > Let me explain a

Re: [Puppet-dev] Re: Fix #6026 - security file should support inline comments

2011-06-01 Thread Brice Figureau
Hi Josh, On 31/05/11 23:58, Josh Cooper wrote: > Can you rebase these changes with the latest 2.7.x branch and > resubmit? I merged a change this morning for #5966, which touched the > same code in lib/puppet/network/authstore.rb -- the part about only > performing global substitution on :dynamic

Re: [Puppet-dev] Re: "Open Source Team" planning meeting summary

2011-06-01 Thread Dean Wilson
On 1 June 2011 06:52, Andrew Forgue wrote: > #3910 - Server is not authoritative over client environment when specified > in an ENC +1 for this. Dean -- Dean Wilson               http://www.unixdaemon.net Profanity is the one language all programmers understand --- Anon -- You received this

Re: [Puppet-dev] File mode/owner management

2011-06-01 Thread Brice Figureau
On Wed, 2011-06-01 at 01:15 -0700, Patrick wrote: > On May 31, 2011, at 10:59 PM, Luke Kanies wrote: > > > On May 27, 2011, at 12:44 AM, Brice Figureau wrote: > > > >> Then to the second issue, it seems the the FileSetting only allow either > >> "root" or "service" as owner and group. That means

Re: [Puppet-dev] [PATCH/puppet 1/2] Fix #7710 - Allow to set any owner/group in file settings

2011-06-01 Thread Brice Figureau
On Tue, 2011-05-31 at 19:59 -0700, Luke Kanies wrote: > On May 28, 2011, at 8:11 AM, Brice Figureau wrote: > > > It is impossible to set an owner/group different than root or service > > for any file/directory settings (both from defaults or by speficying > > those in the configuration file). > >

Re: [Puppet-dev] File mode/owner management

2011-06-01 Thread Patrick
On May 31, 2011, at 10:59 PM, Luke Kanies wrote: > On May 27, 2011, at 12:44 AM, Brice Figureau wrote: > >> Then to the second issue, it seems the the FileSetting only allow either >> "root" or "service" as owner and group. That means my aforementioned >> example wouldn't even work. Since the ag