Re: [Puppet-dev] [PATCH/puppet 1/1] (#7699) - Help should only show options once

2011-07-06 Thread Daniel Pittman
I am happy with this; it looks and behaves as expected, including that none of the existing testing broke at this change. This is only an internal API, not customer facing, so we have no stability assurances down at this level. Your additional tests firm up the API, and the change is logically co

Re: [Puppet-dev] [PATCH/puppet 1/1] (#7699) - Help should only show options once

2011-07-06 Thread Dan Bode
I would really appreciate if someone could have a look at this patch. It could potentially cause other things to break if they are expecting the options method of face or action to return an element per alias. I reviewed the code and this did not appear to be the case (all of the tests also passed

[Puppet-dev] [PATCH/puppet 1/1] (#7699) - Help should only show options once

2011-07-06 Thread Dan Bode
puppet help was reprinting every option once for every alias that is had. This fix involves only storing the option.name in the @options instance var for both face and actions options. The @options_hash still maintains the list of options and aliases as its keys. Signed-off-by: Dan Bode --- Loca

[Puppet-dev] [PATCH/puppet-dashboard 1/1] (#8199) Move 'failed' resources to the top when viewing report events

2011-07-06 Thread Nick Lewis
Because failed resources are the resources a user likely cares about most, we move those to the top to make them more immediately visible. This commit also moves the logic for grouping and sorting resource_statuses from the view to the callback. Because the callback functions as an ad-hoc controll

[Puppet-dev] [PATCH/puppet-dashboard 2/2] (#7967) Improved user-facing design for delayed job warnings

2011-07-06 Thread Randall Hansen
Now that Dashboard depends on background tasks ("delayed jobs") to import reports, we're showing users the status of these tasks. We improved the sidebar notification section with status icons. We improved the page to which they link by (a) making a tabbed view, and (b) making it a little shinier

[Puppet-dev] [PATCH/puppet-dashboard 1/2] (#8266) Back-end logic for splitting read and unread DJ failures.

2011-07-06 Thread Randall Hansen
From: Daniel Pittman Rather than displaying a single, giant list of delayed_job failures on this page, we want to split it out into two lists: one unread, which is important, and one read, which isn't so much. This does the basic controller logic to support displaying those two pages, fetching t

[Puppet-dev] Re: Updated CHANGELOG and package building files for 2.7.2rc1

2011-07-06 Thread Mo
You can ignore this first patch, not part of my set. Not sure how it snuck in here. On Jul 6, 6:43 pm, Mo Morsi wrote: > From: Michael Stahnke > > Signed-off-by: Michael Stahnke > Signed-off-by: Mo Morsi > --- -- You received this message because you are subscribed to the Google Groups "Pu

[Puppet-dev] [PATCH/puppet 2/2] (#7474) Add support for web resource type and provider (revision 2)

2011-07-06 Thread Mo Morsi
Adds a new resource type to puppet for web requests and implements a provider of that type using the ruby curl interface provided by the 'curb' rubygem This is the second revision of the patch I had previous sent out, including put and delete methods, better session security and handling, and many

[Puppet-dev] [PATCH/puppet 1/2] Updated CHANGELOG and package building files for 2.7.2rc1

2011-07-06 Thread Mo Morsi
From: Michael Stahnke Signed-off-by: Michael Stahnke Signed-off-by: Mo Morsi --- Local-branch: feature/master/7474 CHANGELOG | 120 +++ conf/redhat/puppet.spec |7 ++- conf/solaris/pkginfo|2 +- conf/suse/puppet.spec |

[Puppet-dev] [PATCH/puppet 1/1] (#8273) Default options text to ''

2011-07-06 Thread Dan Bode
This allows the puppet man command to succeed if an option exists without documentation. It was previously failing with 'err: private method `gsub' called for nil:NilClass; Signed-off-by: Dan Bode --- Local-branch: issue/master/8273 lib/puppet/face/help/man.erb |2 +- 1 files changed, 1 in

[Puppet-dev] Announce: Puppet 2.7.2rc1

2011-07-06 Thread Michael Stahnke
This a bug-fix release in the 2.7.x branch. This merges up all changes in the 2.6.9 release that were unable to be merged into 2.7.{0,1} due to 2.7 being frozen in release candidate state. This release is available for download at: http://puppetlabs.com/downloads/puppet/puppet-2.7.2rc1.tar.gz

[Puppet-dev] [PATCH/puppet-dashboard 1/1] (#8251 and #8042) Don't use our own logger

2011-07-06 Thread Matt Robinson
By using our own logger to do log rotation, we ran into 2 problems. First, having rails rotate it's own files causes problems when multiple rails workers try to rotate the logs at the same time, as can occur when using delayed_job or passenger. Second, the logger we created used :default as the l

[Puppet-dev] [PATCH/puppet-dashboard 1/1] (#8121) Properly generate CSS from SASS in production.

2011-07-06 Thread Pieter van de Bruggen
According to this link (http://blog.citrusbyte.com/2008/03/20/sass-production-woes-in-rails/), Sass has known issues with CSS generation in Rails 2.3. This is remedied easily enough by providing an initializer that forces the plugin to "reload" a little later in the process, but the exact mechani