Re: [Puppet-dev] Extending Network Devices

2011-07-20 Thread Nan Liu
On Wed, Jul 20, 2011 at 5:07 PM, Brice Figureau wrote: > Hi, > > Foreword: the work I did is very basic in terms of code helping support > other devices (beside the transport stuff itself that you apparently > don't need). My point is that I believe we'll see more patterns of > similarities when a

[Puppet-dev] (puppetlabs/puppet-docs) New pull request: (#8543) Update cloudpack getting started

2011-07-20 Thread wearetherobots
Greetings! Please review the pull request #13: (#8543) Update cloudpack getting started opened by Dan Bode (bodepd) Some more information about the pull request: Opened: Thu Jul 21 00:53:02 UTC 2011 Based on: puppetlabs:master (496091b2eb62d4dae61dd7bb873556

[Puppet-dev] [PATCH/puppet 1/2] Fix order-dependent test failure in certificate_status/file spec

2011-07-20 Thread Nick Lewis
This test was failing if the SSL indirections had previously been configured as :ca. The was due to the fact that we are explicitly testing the certificate_status :file terminus, which depends on the other SSL indirections using corresponding termini. This spec wasn't appropriately ensuring they we

[Puppet-dev] [PATCH/puppet 2/2] Replace calls to Array#count with #length

2011-07-20 Thread Nick Lewis
Array#count is not available in Ruby 1.8.5, so we need to use #length in these specs for compatibility. Reviewed-By: Matt Robinson Signed-off-by: Nick Lewis --- spec/unit/face/ca_spec.rb |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/unit/face/ca_spec.rb b/spec

[Puppet-dev] [PATCH 2/2] (#6789) Port SSL::CertificateAuthority::Interface to a Face

2011-07-20 Thread Daniel Pittman
The Puppet::SSL::CertificateAuthority::Interface class was an early prototype heading toward building out a system like Faces. Now that we have done that, this changeset ports the early code to a new face. Reviewed-By: Pieter van de Bruggen --- lib/puppet/application/ca.rb |5 + lib/puppet/

[Puppet-dev] [PATCH 1/2] maint: SSL::Inventory.serial should report missing names.

2011-07-20 Thread Daniel Pittman
Our SSL inventory was able to find the serial number of a certificate by name, but was incapable of living up to the contract it offered, that it would actually report when a certificate was missing. Now it returns `nil`, which is the same case as "no inventory", if the certificate was not found,

Re: [Puppet-dev] Testing defined types

2011-07-20 Thread Tim Sharpe
Unfortunately rspec already claims /have_.*/ in their matchers and I don't really want to break that functionality. I've pushed a small patch to enable contain_ and it shouldn't be too much of an issue to get a contain() matcher that supports the Puppet nomenclature happening either. On Wedn

[Puppet-dev] [PATCH/Cloudpack/puppet-cloudpack 1/1] (#8528) Removed terminate signal from bootstrap

2011-07-20 Thread Dan Bode
The bootstrap method was previously terminating nodes, even if everything was successful. This fix removes the destroy server at exit signal from the bootstrap method. Server termination should not be effected in case of failure, because the same signal is still specified in the create and init m

Re: [Puppet-dev] Extending Network Devices

2011-07-20 Thread Brice Figureau
Hi, On 20/07/11 22:15, Nan Liu wrote: > All: > > I know Brice is the expert. Not sure if anyone else wants to dive in > and give some quick hints on how to extend Puppet 2.7 network devices. Foreword: the work I did is very basic in terms of code helping support other devices (beside the transpo

[Puppet-dev] Extending Network Devices

2011-07-20 Thread Nan Liu
All: I know Brice is the expert. Not sure if anyone else wants to dive in and give some quick hints on how to extend Puppet 2.7 network devices. 1. Network devices are a bit weird, since they don't collect facts through facter, the cisco device facts reside in: lib/puppet/util/network_device/cisc

Re: [Puppet-dev] Re: [PATCH/puppet 1/6] (#8489) Consistently use File::PATH_SEPARATOR

2011-07-20 Thread Josh Cooper
On Wed, Jul 20, 2011 at 11:42 AM, Nick Fagerlund < nick.fagerl...@puppetlabs.com> wrote: > On Jul 20, 8:17 am, Jacob Helwig wrote: > > I can see adding a note something like "separated by the > > '#{File::PATH_SEPARATOR}' character (varies by platform).", but I'd > > really rather not have us lis

[Puppet-dev] (puppetlabs/puppet-dashboard) Closed pull request: (#8499) Update the usage of mktemp in Rakefile to work on mac

2011-07-20 Thread wearetherobots
Greetings! On Wed Jul 20 19:07:52 UTC 2011 pull request #5 was closed. (#8499) Update the usage of mktemp in Rakefile to work on mac requested by Michael Stahnke (stahnma) Thanks! The Pull Request Bot -- You received this message because you are subscribed to

[Puppet-dev] (puppetlabs/puppet-dashboard) New pull request: (#8499) Update the usage of mktemp in Rakefile to work on mac

2011-07-20 Thread wearetherobots
Greetings! Please review the pull request #5: (#8499) Update the usage of mktemp in Rakefile to work on mac opened by Michael Stahnke (stahnma) Some more information about the pull request: Opened: Wed Jul 20 18:48:46 UTC 2011 Based on: puppetlabs:master (af

[Puppet-dev] (puppetlabs/puppet-dashboard) Closed pull request: Fix for (#8499) --mktemp must work with mac

2011-07-20 Thread wearetherobots
Greetings! On Wed Jul 20 18:53:10 UTC 2011 pull request #4 was closed. Fix for (#8499) --mktemp must work with mac requested by Michael Stahnke (stahnma) Thanks! The Pull Request Bot -- You received this message because you are subscribed to the Google Groups

[Puppet-dev] Re: [PATCH/puppet 1/6] (#8489) Consistently use File::PATH_SEPARATOR

2011-07-20 Thread Nick Fagerlund
On Jul 20, 8:17 am, Jacob Helwig wrote: > I can see adding a note something like "separated by the > '#{File::PATH_SEPARATOR}' character (varies by platform).", but I'd > really rather not have us listing out both ';' and ':'. > > The bigger problem is that we're trying to serve two different purp

Re: [Puppet-dev] [PATCH/puppet 3/6] Fix tests with "relative" paths on Windows

2011-07-20 Thread Daniel Pittman
On Tue, Jul 19, 2011 at 16:04, Josh Cooper wrote: >>  >   it "should not fail if the path is fully qualified, with a trailing >> separator" do >> >> > -    path = "/some/path/with/trailing/separator" >> > -    path_with_separator = "#{path}#{File::SEPARATOR}" >> > -    File.stubs(:lstat).with(path

Re: [Puppet-dev] [PATCH/puppet] Remove Puppet::Network::HttpPool keep_alive handling

2011-07-20 Thread Daniel Pittman
On Tue, Jul 19, 2011 at 16:44, Nick Lewis wrote: > Keep alive has been disabled since 2008, and seems to have caused problems > when > it was enabled before then. Since there doesn't seem to be any push to get it > working again, just remove it to simplify this code. This is an great change, and

[Puppet-dev] [PATCH/Cloudpack/puppet-cloudpack 4/4] (#8517) Should install dashboard for testing

2011-07-20 Thread Dan Bode
Renamed the master_source script to indicate that it is only intended to be used for development/testing. Added more logic for installing the dashboard for testing. Signed-off-by: Dan Bode --- .../{master_source.erb => master_source_dev.erb} | 35 +++- 1 files changed, 34 in

[Puppet-dev] [PATCH/Cloudpack/puppet-cloudpack 2/4] (#8501) Making ssh connections more robust.

2011-07-20 Thread Dan Bode
There were some timing issues where net/ssh could get stuck in a loop when connecting to ubuntu. This has been resolved by specifying a 10 second timeout on the method call that tests the initial connection. Signed-off-by: Dan Bode --- lib/puppet/cloudpack.rb | 14 +- 1 files chan

[Puppet-dev] [PATCH/Cloudpack/puppet-cloudpack 3/4] (#8504) Removed PE specific logging.

2011-07-20 Thread Dan Bode
Previously success was indicated with PE specific messages. This could be confusing for users installing FOSS with cloud-provisoner. Signed-off-by: Dan Bode --- lib/puppet/cloudpack.rb |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/puppet/cloudpack.rb b/lib/puppet

[Puppet-dev] [PATCH/Cloudpack/puppet-cloudpack 1/4] (#8513) Make classifcation of node optional

2011-07-20 Thread Dan Bode
We should not require that users use the Dashboard for node classification on order to bootstrap their nodes. Classification with the Dashboard is only performed when node_group is set. Node group has also been updated to not be required. Unit tests that expect node_group to be required have bee

Re: [Puppet-dev] [PATCH/puppet 1/6] (#8489) Consistently use File::PATH_SEPARATOR

2011-07-20 Thread Jacob Helwig
On Wed, 20 Jul 2011 09:06:02 +0200, David Schmitt wrote: > > On 20.07.2011 00:40, Daniel Pittman wrote: > >On Tue, Jul 19, 2011 at 15:25, Jacob Helwig wrote: > >>On Tue, 19 Jul 2011 15:13:40 -0700, Daniel Pittman wrote: > >>> > >>>On Tue, Jul 19, 2011 at 14:59, Josh Cooper wrote: > > +

Re: [Puppet-dev] [PATCH/puppet 1/6] (#8489) Consistently use File::PATH_SEPARATOR

2011-07-20 Thread David Schmitt
On 20.07.2011 00:40, Daniel Pittman wrote: On Tue, Jul 19, 2011 at 15:25, Jacob Helwig wrote: On Tue, 19 Jul 2011 15:13:40 -0700, Daniel Pittman wrote: On Tue, Jul 19, 2011 at 14:59, Josh Cooper wrote: Puppet uses both colon and File::PATH_SEPARATOR in various places, which does not work on