Re: [Puppet-dev] Facter Branch Updates

2011-08-23 Thread Josh Cooper
> > We have > > 1.6.x --> feature set for 1.6 (no API breakage please, mostly bug fixes) > 1.7.x --> new features go here > master --> newer, possibly experimental things here (this might be > 2.0 eventually, or who knows) > > 1.6rc exists, (as it has in the past) and is where facter is currentl

Re: [Puppet-dev] Facter Branch Updates

2011-08-23 Thread Luke Kanies
On Aug 23, 2011, at 7:14 PM, Michael Stahnke wrote: > On Tue, Aug 23, 2011 at 7:10 PM, Luke Kanies wrote: >> What is the master branch for, in this model? > There has been discussion of implementing structured data, and complex > data structures into facter that could lead to a 2.0 release (or >

Re: [Puppet-dev] Facter Branch Updates

2011-08-23 Thread Michael Stahnke
On Tue, Aug 23, 2011 at 7:10 PM, Luke Kanies wrote: > What is the master branch for, in this model? There has been discussion of implementing structured data, and complex data structures into facter that could lead to a 2.0 release (or something along those lines). That might require significant

Re: [Puppet-dev] Facter Branch Updates

2011-08-23 Thread Luke Kanies
What is the master branch for, in this model? -- Luke Kanies | +1-615-594-8199 | http:/about.me/lak On Aug 23, 2011, at 5:58 PM, Michael Stahnke wrote: > All, > > I've added some new branches to Facter in order to get some > much-needed love into it. > > We have > > 1.6.x --> feature set for

Re: [Puppet-dev] (puppetlabs/puppet) New pull request: Ticket/2.7.x/8410

2011-08-23 Thread Luke Kanies
On Aug 23, 2011, at 10:25 AM, Nick Lewis wrote: On Tuesday, August 23, 2011 at 9:10 AM, Stefan Schulte wrote: Whouldn't this be an opportunity to remove the tempfile stuff in the execute method? (https://projects.puppetlabs.com/issues/2538#note-5 ;-)) The wait_for_output scares me a bit. I

[Puppet-dev] Facter Branch Updates

2011-08-23 Thread Michael Stahnke
All, I've added some new branches to Facter in order to get some much-needed love into it. We have 1.6.x --> feature set for 1.6 (no API breakage please, mostly bug fixes) 1.7.x --> new features go here master --> newer, possibly experimental things here (this might be 2.0 eventually, or w

Re: [Puppet-dev] #2157 - help on windows paths

2011-08-23 Thread Josh Cooper
On Tue, Aug 23, 2011 at 4:27 PM, Ken Barber wrote: > >> If PROGRAMDATA is defined, I would use that value. > >> Otherwise, if ALLUSERSPROFILE is defined (and it should be), I would use > >> %ALLUSERSPROFILE%\Application Data > > > > I actually like this methodology over relying on win32-dir mysel

Re: [Puppet-dev] #2157 - help on windows paths

2011-08-23 Thread Ken Barber
>> If PROGRAMDATA is defined, I would use that value. >> Otherwise, if ALLUSERSPROFILE is defined (and it should be), I would use >> %ALLUSERSPROFILE%\Application Data > > I actually like this methodology over relying on win32-dir myself > because if it works its a win-win and I don't need to degra

[Puppet-dev] (puppetlabs/facter) New pull request: Identify OracleLinux properly

2011-08-23 Thread wearetherobots
Greetings! Please review the pull request #32: Identify OracleLinux properly opened by (Djelibeybi) Some more information about the pull request: Opened: Tue Aug 23 23:12:11 UTC 2011 Based on: puppetlabs:master (00bed7a658510d85a6e832482b4058ec73dc078a)

Re: [Puppet-dev] #2157 - help on windows paths

2011-08-23 Thread Ken Barber
> If PROGRAMDATA is defined, I would use that value. > Otherwise, if ALLUSERSPROFILE is defined (and it should be), I would use > %ALLUSERSPROFILE%\Application Data I actually like this methodology over relying on win32-dir myself because if it works its a win-win and I don't need to degrade. I gu

Re: [Puppet-dev] specifying modules in file path

2011-08-23 Thread Nigel Kersten
On Tue, Aug 23, 2011 at 1:25 PM, Digant C Kasundra wrote: > Hey guys, > > I know I've been silent for years but I've got a window to work on some > puppet upgrades and had a question about the deprecation notice: > DEPRECATION NOTICE: Files found in modules without specifying 'modules' in > file

Re: [Puppet-dev] #2157 - help on windows paths

2011-08-23 Thread Josh Cooper
On Tue, Aug 23, 2011 at 12:46 PM, Ken Barber wrote: > Thanks Josh. > > > The ProgramData environment variable is not supported on 2003. The > > equivalent directory on 2003 (and other legacy systems) > > is %ALLUSERSPROFILE%\Application Data.[1] > > Gah! (/me goes off to download Windows 2003 ...

[Puppet-dev] specifying modules in file path

2011-08-23 Thread Digant C Kasundra
Hey guys, I know I've been silent for years but I've got a window to work on some puppet upgrades and had a question about the deprecation notice: DEPRECATION NOTICE: Files found in modules without specifying 'modules' in file path will be deprecated in the next major release. Please fix modul

Re: [Puppet-dev] #2157 - help on windows paths

2011-08-23 Thread Jacob Helwig
On Tue, 23 Aug 2011 20:46:11 +0100, Ken Barber wrote: > > Thanks Josh. > > > The ProgramData environment variable is not supported on 2003. The > > equivalent directory on 2003 (and other legacy systems) > > is %ALLUSERSPROFILE%\Application Data.[1] > > Gah! (/me goes off to download Windows 200

Re: [Puppet-dev] #2157 - help on windows paths

2011-08-23 Thread Ken Barber
Thanks Josh. > The ProgramData environment variable is not supported on 2003. The > equivalent directory on 2003 (and other legacy systems) > is %ALLUSERSPROFILE%\Application Data.[1] Gah! (/me goes off to download Windows 2003 ...). So in 2008R2 ALLUSERSPROFILE points at C:\ProgramData ... so i

Re: [Puppet-dev] #2157 - help on windows paths

2011-08-23 Thread Josh Cooper
On Tue, Aug 23, 2011 at 11:31 AM, Ken Barber wrote: > > Generally speaking: Facter should probably still work (though in a > > degraded mode) without the win32-dir gem installed. > > Hmm. ENV["ProgramData"] is actually the same as Dir::COMMON_APPDATA on > 2008R2. I can avoid the gem completely th

Re: [Puppet-dev] #2157 - help on windows paths

2011-08-23 Thread Ken Barber
> Generally speaking: Facter should probably still work (though in a > degraded mode) without the win32-dir gem installed. Hmm. ENV["ProgramData"] is actually the same as Dir::COMMON_APPDATA on 2008R2. I can avoid the gem completely this way, but this is not how Puppet does it today ... as it seem

Re: [Puppet-dev] #2157 - help on windows paths

2011-08-23 Thread Jacob Helwig
On Tue, 23 Aug 2011 19:10:35 +0100, Ken Barber wrote: > > Hi everyone, > > I need some advice on a ticket I'm working on - #2157: > > https://projects.puppetlabs.com/issues/2157 > > This introduces scripting support for facter. This new change > introduces two new path requirements: > > * A di

[Puppet-dev] #2157 - help on windows paths

2011-08-23 Thread Ken Barber
Hi everyone, I need some advice on a ticket I'm working on - #2157: https://projects.puppetlabs.com/issues/2157 This introduces scripting support for facter. This new change introduces two new path requirements: * A directory for scripted facts (for linux now its /etc/facter/facts.d/) * A file

Re: [Puppet-dev] (puppetlabs/puppet) New pull request: Ticket/2.7.x/8410

2011-08-23 Thread Nick Lewis
On Tuesday, August 23, 2011 at 9:10 AM, Stefan Schulte wrote: > Whouldn't this be an opportunity to remove the tempfile stuff in the > execute method? > > (https://projects.puppetlabs.com/issues/2538#note-5 ;-)) > > The wait_for_output scares me a bit. > I would like to make that change, but

Re: [Puppet-dev] (puppetlabs/puppet) New pull request: Ticket/2.7.x/8410

2011-08-23 Thread Stefan Schulte
On Mon, Aug 22, 2011 at 06:00:05PM -0700, wearetherob...@puppetlabs.com wrote: > > > > > Greetings! > > Please review the pull request #54: href="https://github.com/puppetlabs/puppet/pull/54"; > title="Ticket/2.7.x/8410">Ticket/2.7.x/8410 opened by (nicklewis) > > > Some