Re: [Puppet-dev] Is a Puppet::Type instance a Puppet::Resource instance?

2012-07-03 Thread Luke Kanies
On Jul 3, 2012, at 1:42 PM, Brice Figureau wrote: > On 03/07/12 22:15, Luke Kanies wrote: >> On Jul 3, 2012, at 5:04 AM, Brice Figureau wrote: >> >>> On 03/07/12 01:03, Luke Kanies wrote: On Jul 2, 2012, at 1:59 PM, Brice Figureau wrote: > Hi, > > While wrapping up my comp

Re: [Puppet-dev] Is a Puppet::Type instance a Puppet::Resource instance?

2012-07-03 Thread Brice Figureau
On 03/07/12 22:15, Luke Kanies wrote: > On Jul 3, 2012, at 5:04 AM, Brice Figureau wrote: > >> On 03/07/12 01:03, Luke Kanies wrote: >>> On Jul 2, 2012, at 1:59 PM, Brice Figureau wrote: >>> Hi, While wrapping up my compiler performance patch (soon to be released), I stumble

Re: [Puppet-dev] Is a Puppet::Type instance a Puppet::Resource instance?

2012-07-03 Thread Luke Kanies
On Jul 3, 2012, at 5:04 AM, Brice Figureau wrote: > On 03/07/12 01:03, Luke Kanies wrote: >> On Jul 2, 2012, at 1:59 PM, Brice Figureau wrote: >> >>> Hi, >>> >>> While wrapping up my compiler performance patch (soon to be >>> released), I stumbled on this test (in compiler_spec.rb): >>> >>> it

Re: [Puppet-dev] Various compiler performance patches

2012-07-03 Thread Ken Barber
+3 your my new personal hero Brice :-). On Tue, Jul 3, 2012 at 4:10 PM, James Turnbull wrote: > Nigel Kersten wrote: >>> Those patches are not ready for general consumption and upstream merging >>> (that's why I didn't publish a pull request), but I'd appreciate any >>> feedback and tests on othe

Re: [Puppet-dev] Various compiler performance patches

2012-07-03 Thread James Turnbull
Nigel Kersten wrote: >> Those patches are not ready for general consumption and upstream merging >> (that's why I didn't publish a pull request), but I'd appreciate any >> feedback and tests on other sets of manifests to see the potential gains. >> My idea was to help PL dev team to produce a more

Re: [Puppet-dev] Various compiler performance patches

2012-07-03 Thread Nigel Kersten
On Tue, Jul 3, 2012 at 5:00 AM, Brice Figureau wrote: > Hi, > > I'm proud to release a set of unofficial and certainly unstable (in > various ways) patches against both 2.7.x and 3.0.x to improve the > performance of the puppet compiler (and only the compiler). > > Warning: I never tried to use th

Re: [Puppet-dev] Various compiler performance patches

2012-07-03 Thread Stephen Gran
Hi, On Tue, 2012-07-03 at 14:00 +0200, Brice Figureau wrote: > Hi, > > I'm proud to release a set of unofficial and certainly unstable (in > various ways) patches against both 2.7.x and 3.0.x to improve the > performance of the puppet compiler (and only the compiler). I know it's a bit early to

Re: [Puppet-dev] Is a Puppet::Type instance a Puppet::Resource instance?

2012-07-03 Thread Brice Figureau
On 03/07/12 01:03, Luke Kanies wrote: > On Jul 2, 2012, at 1:59 PM, Brice Figureau wrote: > >> Hi, >> >> While wrapping up my compiler performance patch (soon to be >> released), I stumbled on this test (in compiler_spec.rb): >> >> it "should fail to add resources that conflict with existing >>

[Puppet-dev] Various compiler performance patches

2012-07-03 Thread Brice Figureau
Hi, I'm proud to release a set of unofficial and certainly unstable (in various ways) patches against both 2.7.x and 3.0.x to improve the performance of the puppet compiler (and only the compiler). Warning: I never tried to use those patches in production. Also those patches are almost not covere