Re: [Puppet-dev] #18393 - diff args

2013-05-15 Thread Alex Harvey
On Thursday, May 16, 2013 3:31:09 AM UTC+10, Jeff Weiss wrote: > > > The pull request that Andy mentioned and that Chris merged is to provide > an adequate default diffargs on all of our commercially supported > platforms. Diff is off by default. If one goes into puppet.conf to enable > diff,

Re: [Puppet-dev] #18393 - diff args

2013-05-15 Thread Jeff Weiss
On Tue, May 14, 2013 at 9:30 PM, Alex Harvey wrote: > > That said, I think being able to configure the diff_args in puppet.conf is > also an adequate solution. > > As you noted diffargs is already configurable in puppet.conf. The pull request that Andy mentioned and that Chris merged is to provi

Re: [Puppet-dev] #18393 - diff args

2013-05-15 Thread Chris Price
Andy, Sorry, for some reason when I was reviewing that pull request I was thinking it was targeted at our AIX branch. I probably should have checked with your team before merging it. If you guys decide that we should back that out and solve the problem a different way, we will be happy to work wi

Re: [Puppet-dev] #18393 - diff args

2013-05-15 Thread Andy Parker
On Tue, May 14, 2013 at 9:30 PM, Alex Harvey wrote: > > > On Wednesday, May 15, 2013 4:54:33 AM UTC+10, Andy Parker wrote: >> >> It looks like the PE team hit this problem for AIX and created a fix >> where they change the default diff_args based on the platform: >> https://github.com/puppetlabs/p