Re: [Puppet-dev] RFC: Static Analysis of the Puppet project

2014-08-06 Thread Kylo Ginsberg
On Tue, Aug 5, 2014 at 3:50 PM, rahul wrote: > So to summarize, this is our plan for Rubocop: > > - We propose to enable AndOr cop in small chunks, giving preference to > those files/directories that are heavily in development. > - For AndOr, the conclusion seems to be to avoid keywords completel

[Puppet-dev] Re: Decision: Near future of resource expressions

2014-08-06 Thread Henrik Lindberg
On 2014-07-08 1:18, Wil Cooley wrote: On Wed, Aug 6, 2014 at 1:30 PM, Henrik Lindberg mailto:henrik.lindb...@cloudsmith.com>> wrote: $extra_opts = { $ssl => true, ... } I assume you mean {ssl => true, ...}, and not the value of a variable $ssl ? Yes, sorry

Re: [Puppet-dev] Re: Decision: Near future of resource expressions

2014-08-06 Thread Wil Cooley
On Wed, Aug 6, 2014 at 1:30 PM, Henrik Lindberg < henrik.lindb...@cloudsmith.com> wrote: > $extra_opts = { $ssl => true, ... } >> > > I assume you mean {ssl => true, ...}, and not the value of a variable $ssl > ? Yes, sorry > > apache::vhost { ... >>ssl => undef, >>a

Re: [Puppet-dev] Puppet PR Triage Notes 2014-08-06

2014-08-06 Thread Rob Reynolds
On Wed, Aug 6, 2014 at 1:29 PM, Adrien Thebo wrote: > Felix is writing a book on Puppet! If you're interested in helping with > technical review send him an email, and glory and riches will be yours! > > Attended: Finch, Michael, Rob, Joshua, Felix > > New: > > Facter: > > 741: Fact 637 add lsbmi

[Puppet-dev] Re: Decision: Near future of resource expressions

2014-08-06 Thread Henrik Lindberg
On 2014-06-08 19:29, Wil Cooley wrote: On Aug 5, 2014 6:41 PM, "Reid Vandewiele" mailto:r...@puppetlabs.com>> wrote: > Example 1 (assuming behavior whereinmerging is OK, and that explicit parameter specification takes precedence): > > apache::vhost { $servername: > port => $port, > ssl

[Puppet-dev] Re: Decision: Near future of resource expressions

2014-08-06 Thread Henrik Lindberg
On 2014-06-08 16:56, Spencer Krum wrote: I think a metaparameter is a great solution. It has the advantage of feeling the most puppety, and can be successfully googled for. I don't think I agree that attribute_hash is more descriptive than attribute_defaults, since, aren't we setting defaults?

[Puppet-dev] Puppet PR Triage Notes 2014-08-06

2014-08-06 Thread Adrien Thebo
Felix is writing a book on Puppet! If you're interested in helping with technical review send him an email, and glory and riches will be yours! Attended: Finch, Michael, Rob, Joshua, Felix New: Facter: 741: Fact 637 add lsbminordistrelease - Copyright information in the fact implementation an

Re: [Puppet-dev] Re: Decision: Near future of resource expressions

2014-08-06 Thread Wil Cooley
On Aug 5, 2014 6:41 PM, "Reid Vandewiele" wrote: > Example 1 (assuming behavior whereinmerging is OK, and that explicit parameter specification takes precedence): > > apache::vhost { $servername: > port => $port, > ssl => $ssl, > attribute_defaults => $extra_opts, > } Assuming that the se

[Puppet-dev] Puppet PR Triage for 2014-08-06 starting soon

2014-08-06 Thread Joshua Partlow
Starting the PR triage for puppet/facter/hiera in 6 mins or so at http://links.puppetlabs.com/pr-triage -- Josh Partlow jpart...@puppetlabs.com Developer, Puppet Labs Join us at PuppetConf 2014, September 20-24 in San Francisco Register by September 8th to take advantage of the Final Countdown —

Re: [Puppet-dev] Iteration functions, which ones do we need?

2014-08-06 Thread Ben Ford
I don't think we have the luxury of backing them out any more; and to be honest I think that these functions here are mostly OK. Map & filter will be fine. People will struggle with reduce and slice and they probably won't get used much. I have two real concerns here. Clearly I'm concerned abou

Re: [Puppet-dev] Re: Decision: Near future of resource expressions

2014-08-06 Thread Ashley Penney
I hate to "me too" but I'm actually a pretty big fan of the metaparam too, it's very readable and clear. On Wed, Aug 6, 2014 at 11:41 AM, Ben Ford wrote: > I really like the metaparameter approach. It's almost self documenting. > > > > On Tuesday, August 5, 2014 6:41:40 PM UTC-7, Reid Vandewiel

Re: [Puppet-dev] Re: Decision: Near future of resource expressions

2014-08-06 Thread Ben Ford
I really like the metaparameter approach. It's almost self documenting. On Tuesday, August 5, 2014 6:41:40 PM UTC-7, Reid Vandewiele wrote: > > Maybe solving for this use case would be better handled by implementing > something that looks and feels like a metaparameter rather than trying to >

Re: [Puppet-dev] Re: Decision: Near future of resource expressions

2014-08-06 Thread Spencer Krum
I think a metaparameter is a great solution. It has the advantage of feeling the most puppety, and can be successfully googled for. I don't think I agree that attribute_hash is more descriptive than attribute_defaults, since, aren't we setting defaults? Thanks, Spencer On Wed, Aug 6, 2014 at 6:

[Puppet-dev] Re: Syntax of resource expressions (was: Decision: Near future of resource expressions)

2014-08-06 Thread Henrik Lindberg
On 2014-06-08 8:25, David Schmitt wrote: Hi, thanks for keeping the ball rolling! On 2014-08-06 02:51, Andy Parker wrote: I'm pulling this discussion out into a new thread so that we can become more focussed. I'm also going to start a thread about one other topic that has been brought to my at

[Puppet-dev] Re: Decision: Near future of resource expressions

2014-08-06 Thread Henrik Lindberg
On 2014-06-08 3:41, Reid Vandewiele wrote: On Tue, Aug 5, 2014 at 4:11 PM, Henrik Lindberg mailto:henrik.lindb...@cloudsmith.com>> wrote: On 2014-05-08 18:24, Andy Parker wrote: My argument against using parenthesis is that parenthesis, are often read as "seldom necessary g

Re: [Puppet-dev] Iteration functions, which ones do we need?

2014-08-06 Thread Erik Dalén
I don't think they are too much or that any should be left out. I suppose all of them could be emulated with just the reduce function, so if anything that one should be kept. But it is just cumbersome and makes the code less clear to do a filter in a reduce function. On 6 August 2014 03:01, Andy