Re: [Puppet-dev] RFC: Static Analysis of the Puppet project

2014-08-07 Thread Kylo Ginsberg
On Wed, Aug 6, 2014 at 5:39 PM, Kylo Ginsberg wrote: > On Tue, Aug 5, 2014 at 3:50 PM, rahul wrote: > >> So to summarize, this is our plan for Rubocop: >> >> - We propose to enable AndOr cop in small chunks, giving preference to >> those files/directories that are heavily in development. >> - Fo

Re: [Puppet-dev] Re: Decision: Near future of resource expressions

2014-08-07 Thread Ben Ford
I would also like to propose that we use the metaparameter syntax for defaults as well. For example, rather than writing this: #less readable file { default: mode => '0666'; '/tmp/foo': ; '/tmp/bar': ; '/tmp/special': mode => '0777'; } One would write this: #more readable $d

[Puppet-dev] Re: Decision: Near future of resource expressions

2014-08-07 Thread Henrik Lindberg
On 2014-07-08 20:09, Ben Ford wrote: I would also like to propose that we use the metaparameter syntax for defaults as well. For example, rather than writing this: #less readable file { default: mode => '0666'; '/tmp/foo': ; '/tmp/bar': ; '/tmp/special': mode => '0777'; } One would write

Re: [Puppet-dev] Re: Decision: Near future of resource expressions

2014-08-07 Thread Joshua Partlow
On Thu, Aug 7, 2014 at 12:55 PM, Henrik Lindberg < henrik.lindb...@cloudsmith.com> wrote: > On 2014-07-08 20:09, Ben Ford wrote: > >> I would also like to propose that we use the metaparameter syntax for >> defaults as well. >> >> For example, rather than writing this: >> >> #less readable >> >> f

Re: [Puppet-dev] RFC: Static Analysis of the Puppet project

2014-08-07 Thread Rahul Gopinath
While hacking rubocop, I found that I can get it to autocorrect even more `Style/AndOr` violations if I replace the use of the `not` keyword with `!` first. The Rubocop is able to do the necessary changes automatically. So I think we should turn on the `Style/Not` cop also for our code for three re