[Puppet-dev] Scheduled downtime on projects.puppetlabs.com

2012-05-15 Thread Ben Hughes
p;sec=0&p1=179&p2=202 for those battling other timezones). So try not to find any bugs during those hours. (: Thanks! -- Ben Hughes -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to puppe

[Puppet-dev] Re: Redmine and Forge outages

2011-08-16 Thread Ben Hughes
On Tue, Aug 16, 2011 at 06:53:03PM -0700, Ben Hughes wrote: > Due to continuing problems with our datacenter, we're moving some > infrastructure this evening. Both Forge and Redmine are back, we have normality. (With the obligatory Hitch-Hikers Guide to the Galaxy reference of: A

[Puppet-dev] Redmine and Forge outages

2011-08-16 Thread Ben Hughes
utage earlier too [1]. If you have any issues in a couple of hours once it's all back up, feel free to hunt me down and ask me. Thanks. 1. http://status.linode.com/2011/08/partial-outage-in-fremont.html -- Ben Hughes || Come to PuppetConf http://bit.ly/puppetconfsig -- You received th

[Puppet-dev] Re: Redmine upgrade

2011-07-28 Thread Ben Hughes
On Wed, Jul 27, 2011 at 11:55:16AM -0700, Ben Hughes wrote: > It should be swift, and probably, no one will even notice. Let us all just pretend that was the case... If anyone is seeing anything out of sorts, please give me a shout (or, if you still can, raise a ticket). Thanks. --

[Puppet-dev] Redmine upgrade

2011-07-27 Thread Ben Hughes
Good day all, Just a quick heads-up that I'll be upgrading Redmine on https://projects.puppetlabs.com on the 28th at 10:30PM PDT. (05:30 UTC) It should be swift, and probably, no one will even notice. Thanks. -- Ben Hughes || Come to PuppetConf http://bit.ly/puppetconfsig -- You rec

[Puppet-dev] [PATCH] (#6728) Facter improperly detects openvzve on CloudLinux systems

2011-06-10 Thread Ben Hughes
Update the OpenVZ fact to be slightly more resilient in it's checking of OpenVZ, so it doesn't clash with CloudLinux's LVE container system. It checks if /proc/vz/ actually has anything in it, which if it doesn't, is Cloudlinux. Uses the better OpenVZ detection methodology from #2242, which is rea

[Puppet-dev]

2011-06-10 Thread Ben Hughes
This is a redux of #6728 where I broke OpenVZ on some platforms to get Cloudlinux's use of OpenVZ detection working. Now I'm not super pumped about relying on a glob of /proc/vz/ to detect if something is or isn't Cloudlinux, but due to the way they use OpenVZ I can't think of a better way to do i

[Puppet-dev] [PATCH/puppet 1/1] (#6857) Password disclosure when changing a user's password

2011-06-01 Thread Ben Hughes
this just brings it inline with those, albeit via a slightly different pair of methods. Signed-off-by: Ben Hughes --- ...rd-disclosure-when-changing-a-users-password.rb | 23 lib/puppet/type/user.rb|8 +++ spec/un

Re: [Puppet-dev] [PATCH/puppet 2/2] (#6885) puppet agent fingerprint requires --verbose to return a value.

2011-04-17 Thread Ben Hughes
e that phrase over there?). Squashed it and rewrote the commit message to be a little clearer. Thanks for the guidance. -- Ben Hughes || http://www.puppetlabs.com/ pgp9pqee6doPt.pgp Description: PGP signature

[Puppet-dev] [PATCH/puppet 1/1] (#6885) puppet agent fingerprint requires --verbose to return a value.

2011-04-17 Thread Ben Hughes
gging facilities. Signed-off-by: Ben Hughes --- lib/puppet/application/agent.rb |2 +- spec/unit/application/agent_spec.rb |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/puppet/application/agent.rb b/lib/puppet/application/agent.rb index 3749241..53e0832 100644 ---

Re: [Puppet-dev] [PATCH/puppet 2/2] (#6885) puppet agent fingerprint requires --verbose to return a value.

2011-04-17 Thread Ben Hughes
nstance. This is just me not understanding how stubbing works. -- Ben Hughes || http://www.puppetlabs.com/ pgpI2WrSvV77P.pgp Description: PGP signature

Re: [Puppet-dev] [PATCH/puppet 2/2] (#6885) puppet agent fingerprint requires --verbose to return a value.

2011-04-17 Thread Ben Hughes
sing Puppet logging. The original test stubbed the Puppet logging. -- Ben Hughes || http://www.puppetlabs.com/ pgpEwNzwzJflQ.pgp Description: PGP signature

[Puppet-dev] [PATCH/puppet 2/2] (#6885) puppet agent fingerprint requires --verbose to return a value.

2011-04-11 Thread Ben Hughes
Fix the spec test for agent fingerprinting with stubbing of puts. This is because it no longer uses the Puppet.logging functionality, so we need to stub Kernel as well. Signed-off-by: Ben Hughes --- spec/unit/application/agent_spec.rb |2 +- 1 files changed, 1 insertions(+), 1 deletions

[Puppet-dev]

2011-04-11 Thread Ben Hughes
Fix and unit test fix for #6885, --fingerprint outputting to stdout. -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to puppet-dev@googlegroups.com. To unsubscribe from this group, send email to puppet-dev

[Puppet-dev] [PATCH/puppet 1/2] (#6885) puppet agent fingerprint requires --verbose to return a value.

2011-04-11 Thread Ben Hughes
Always output the fingerprint to STDOUT, no matter what loglevel is used, as that's the whole purpose of the comment. Having to specify --verbose in addition to --fingerprint to get the finger is nonsensical. Signed-off-by: Ben Hughes --- lib/puppet/application/agent.rb |2 +- 1

[Puppet-dev] [PATCH/puppet 1/1] (#7018) explain internals better in service provider documentation

2011-04-07 Thread Ben Hughes
Add explicit reasoning for hasstatus in the documentation with certain "virtual" services. Just to clear up why notify => Service["something_virtual"] requires hasstatus defining for it to function. Signed-off-by: Ben Hughes --- lib/puppet/type/service.rb |5 ++

[Puppet-dev] [PATCH/puppet 1/1] (#7018) explain internals better in service provider documentation

2011-04-07 Thread Ben Hughes
Add explicit reasoning for hasstatus in the documentation with certain "virtual" services. Just to clear up why notify => Service["something_virtual"] requires hasstatus defining for it to function. Signed-off-by: Ben Hughes --- lib/puppet/type/service.rb |5 ++

[Puppet-dev] [PATCH/facter 1/1] (#6728) Facter improperly detects openvzve on CloudLinux systems

2011-04-06 Thread Ben Hughes
Make the openvz check for more than just the vz directory to be sure it's OpenVZ. Update the OpenVZ fact to be slightly more resilient in it's checking of OpenVZ, so it doesn't clash with CloudLinux's LVE container system. Signed-off-by: Ben Hughes --- lib/facter/util/v

Re: [Puppet-dev] [PATCH/puppet 1/1] (#6885) puppet agent fingerprint requires --verbose to return a value.

2011-04-05 Thread Ben Hughes
/ record by default, or perhaps adjust log output levels temporarily. I tried logging via Puppet.info, but that didn't do it either. Is there a log level that outputs to STDOUT? (that's why I reluctantly fell back to puts). That would also fix the unit test. -- Ben Hughes || http://www.pu

Re: [Puppet-dev] [PATCH/puppet 1/1] (#6885) puppet agent fingerprint requires --verbose to return a value.

2011-04-05 Thread Ben Hughes
On Tue, Apr 05, 2011 at 04:27:13PM +1000, Ben Hughes wrote: > Always output the fingerprint to STDOUT, no matter what loglevel is used, > as that's the whole purpose of the comment. Ironically, this breaks the unit test entitled "Puppet::Application::Agent when running with --fi

[Puppet-dev] [PATCH/puppet 1/1] (#6885) puppet agent fingerprint requires --verbose to return a value.

2011-04-04 Thread Ben Hughes
Always output the fingerprint to STDOUT, no matter what loglevel is used, as that's the whole purpose of the comment. Having to specify --verbose in addition to --fingerprint to get the finger is nonsensical. Signed-off-by: Ben Hughes --- lib/puppet/application/agent.rb |2 +- 1

[Puppet-dev] [PATCH/puppet 1/1] (#6937) Document the recurse parameter of File type.

2011-03-31 Thread Ben Hughes
Update the desc block with information gleaned from #1469 and the code about recurse => remote and other types of recursion. The auto generated documentation was sparse and this is an area that often comes up on the mailing list/IRC. Signed-off-by: Ben Hughes --- lib/puppet/type/file.rb |

[Puppet-dev] [PATCH/puppet 1/1] (#6893) Document the cron type in the case of specials.

2011-03-30 Thread Ben Hughes
Add in a better desc block for "specials" in cron provider, and outline it's limitations. The previous text was purely a placeholder. Signed-off-by: Ben Hughes --- lib/puppet/type/cron.rb |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/lib/puppet/typ

Re: [Puppet-dev] [PATCH/facter 1/1] Make the error message for failing to load the pre-requisite Ruby libraries more obvious. (Prompted by #6832)

2011-03-28 Thread Ben Hughes
mmitted... Apologises. Have given a more grown up commit message and changed the interpolation too. -- Ben Hughes || http://www.puppetlabs.com/ -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to

[Puppet-dev] [PATCH/facter 1/1] (#6883) Update Facter install.rb to be slightly more informative.

2011-03-28 Thread Ben Hughes
Give slightly more information to the user when installing facter and the pre-requisite Ruby libraries are not installed. In the case of OpenSSL, the user can have OpenSSL installed, and not the gem/library, but the error message given in no way hints to this. Signed-off-by: Ben Hughes

[Puppet-dev] [PATCH/facter 1/1] Make the error message for failing to load the pre-requisite Ruby libraries more obvious. (Prompted by #6832)

2011-03-27 Thread Ben Hughes
Signed-off-by: Ben Hughes --- Local-branch: tickets/master/6832 install.rb |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/install.rb b/install.rb index eb91e7c..42acfb9 100755 --- a/install.rb +++ b/install.rb @@ -119,7 +119,7 @@ def check_prereqs begin

[Puppet-dev] [PATCH/facter 1/1] (#5394) Document Facter facts.

2011-03-24 Thread Ben Hughes
From: Ben H Document all the builtin Facter facts in puppetdoc/rdoc format. Signed-off-by: Ben Hughes --- Local-branch: tickets/master/5394 lib/facter/Cfkey.rb | 11 +++ lib/facter/ipaddress.rb | 24 lib/facter/ipaddress6.rb

Re: [Puppet-dev] [PATCH/facter 1/2] (#6716) fix facter issues on OSX with ipv6 in macaddress.rb.

2011-03-17 Thread Ben Hughes
the spacing as was, rather than just changing it for a fix to avoid more whitespace changes. Should one just "fix" spacing as one finds it? -- Ben Hughes || http://www.puppetlabs.com/ pgpibLHQXjxhO.pgp Description: PGP signature

Re: [Puppet-dev] [PATCH/facter 1/2] (#6716) fix facter issues on OSX with ipv6 in macaddress.rb.

2011-03-16 Thread Ben Hughes
uot; (on BSD) or "ip route get 1.2.3.4" (on linux) be better too as this returns the interface it would use, rather than trying to parse routing tables. -- Ben Hughes || http://www.puppetlabs.com/ -- You received this message because you are subscribed to the Google Groups "Puppet

[Puppet-dev] [PATCH/facter 2/2] Add unit test fixtures to check dual stack netstat resolution on OSX. Relating to #6716.

2011-03-16 Thread Ben Hughes
Signed-off-by: Ben Hughes --- Local-branch: tickets/master/6716 spec/fixtures/ifconfig/darwin_10_6_6_dualstack |8 + spec/fixtures/ifconfig/darwin_10_6_6_dualstack_en1 |7 spec/fixtures/netstat/darwin_10_6_6_dualstack | 34 spec/unit/util

[Puppet-dev] [PATCH/facter 1/2] (#6716) fix facter issues on OSX with ipv6 in macaddress.rb.

2011-03-16 Thread Ben Hughes
Due to "netstat -rn" returning multiple protocols (IPv4 and IPv6) the "default_interface" can get more than one entry in to it, causing the macaddress resolving to break. This limits it to just one interface. Signed-off-by: Ben Hughes --- Local-branch: tickets/master/6

[Puppet-dev] [PATCH/facter 1/1] (#6327) Memory facts should be available on Mac Darwin

2011-03-15 Thread Ben Hughes
hat took over a second to run each time, so this appears cheaper. Signed-off-by: Ben Hughes --- lib/facter/memory.rb | 37 + lib/facter/util/memory.rb | 31 +++ 2 files changed, 68 insertions(+), 0 deletions(-) diff --g

[Puppet-dev]

2011-03-15 Thread Ben Hughes
Going to try to add some unit tests to this if I can. Can people with Macs have a test too please? Thanks. -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to puppet-dev@googlegroups.com. To unsubscribe from

Re: [Puppet-dev] [PATCH/facter 1/1] Remove Solaris from the list of confined systems. It won't get the original lsb facts, and it's nonsensical too.

2011-03-14 Thread Ben Hughes
On Mon, Mar 14, 2011 at 05:19:29PM -0700, James Turnbull wrote: > Is there a ticket for this Ben? Nope. I'll go make one. https://projects.puppetlabs.com/issues/6714 -- Ben Hughes || http://www.puppetlabs.com/ -- You received this message because you are subscribed to the Googl

[Puppet-dev] [PATCH/facter 1/1] Remove Solaris from the list of confined systems. It won't get the original lsb facts, and it's nonsensical too.

2011-03-14 Thread Ben Hughes
Signed-off-by: Ben Hughes --- lib/facter/lsbmajdistrelease.rb |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/facter/lsbmajdistrelease.rb b/lib/facter/lsbmajdistrelease.rb index 843a0af..3659541 100644 --- a/lib/facter/lsbmajdistrelease.rb +++ b/lib/facter

[Puppet-dev] [PATCH/facter 3/3] Added more rdoc style documentation for base facts.

2011-03-14 Thread Ben Hughes
Signed-off-by: Ben Hughes --- lib/facter/facterversion.rb |9 + lib/facter/id.rb |6 +- lib/facter/memory.rb | 17 + lib/facter/selinux.rb|9 + lib/facter/timezone.rb |9 + lib/facter/uptime.rb

[Puppet-dev] [PATCH/facter 1/3] inital stab at adding a puppetdoc-esque fact description to facts.

2011-03-14 Thread Ben Hughes
From: Ben H Signed-off-by: Ben Hughes --- lib/facter/architecture.rb | 13 + lib/facter/domain.rb| 20 lib/facter/ec2.rb | 10 ++ lib/facter/fqdn.rb | 11 +++ lib/facter/hardwareisa.rb

Re: [Puppet-dev] Proposal: add universal assertions on logs to puppet spec tests.

2011-03-02 Thread Ben Hughes
ally good addition to the testing! Sure some tests will fail initially, but that's a good thing, right? Will ultimately fix more things than it breaks at the beginning. -- Ben Hughes || http://www.puppetlabs.com/ -- You received this message because you are subscribed to the Google Groups &quo