From: Matt Robinson
Tables that display nodes and their resource statuses now feature a
Total row that shows the sum of all resource statuses for the current
scope of nodes.
Paired-with: Max Martin
Signed-off-by: Max Martin
---
Local-branch: ticket/master/6992-resource_status_totals
app
When viewing an individual report, resources are now grouped by their
status.
Paired-with: Matt Robinson
Signed-off-by: Max Martin
---
Local-branch: ticket/master/7544-resource-grouping
app/views/reports/_resource_statuses.html.haml | 44 +---
1 files changed, 24
pages should all work.
Pagination has also been implemented for the tabbed chart.
Paired-with: Matt Robinson
Signed-off-by: Max Martin
---
Local-branch: ticket/master/7840-consistency
app/controllers/nodes_controller.rb | 21 +---
app/controllers/pages_controller.rb
inson
Signed-off-by: Max Martin
---
...83820_add_status_column_to_resource_statuses.rb |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git
a/db/migrate/20110603183820_add_status_column_to_resource_statuses.rb
b/db/migrate/20110603183820_add_status_column_to_resource_statuses.rb
From: Matt Robinson
Paired-with: Max Martin
Signed-off-by: Max Martin
---
Local-branch: feature/master/6992-summary_of_resource_status
RELEASE_NOTES.md |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
index 1d76112..192e754 100644
styling to look better with the rest of
the site, and someplace for pagination links to go.
Paired-with: Max Martin
Signed-off-by: Max Martin
---
Local-branch: feature/master/6992-summary_of_resource_status
app/controllers/pages_controller.rb | 17 ++---
app/mode
most recent reports.
Should anyone want all their reports updated, there's a `rake
reports:update_report_data` task added that's idempotent, so I can be
run multiple times without messing up the data.
Paired-with: Max Martin
Signed-off-by: Max Martin
---
Local-branch: feature/
This patch series overhauls the Dashboard homepage to include some new
statistics about node and report statuses.
There are structural changes to support the statuses being consistent across
the site, specifcally pending
counts.
--
You received this message because you are subscribed to the Go
the eye, but that can be tweaked easily later.
Paired-with: Max Martin
Signed-off-by: Max Martin
---
Local-branch: feature/master/6992-summary_of_resource_status
app/models/status.rb |4 +++-
app/views/statuses/_run_failure.html.haml |3 +++
public/images/icons
nt it from being run. If you need more
information or guidance on how to proceed, please feel free to e-mail the list,
or check out our Wiki documentation on writing tests:
https://projects.puppetlabs.com/projects/puppet/wiki/Development_Writing_Tests
--
Max Martin
On Wednesday, May 11, 2011 at 6:3
prevent these failures.
Paired-with: Daniel Pittman
Signed-off-by: Max Martin
---
Local-branch: ticket/2.7.x/7469-rake-failures
spec/unit/application/indirection_base_spec.rb |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/spec/unit/application/indirection_base_spec.rb
b
phone: +1 (877) 575-9775
> ♲ Made with 100 percent post-consumer electrons
>
> --
> You received this message because you are subscribed to the Google Groups
> "Puppet Developers" group.
> To post to this group, send email to puppet-dev@googlegroups.com.
> To unsubs
defaultto value of "compat."
Paired-with: Matt Robinson
Signed-off-by: Max Martin
---
Local-branch: ticket/2.7.x/7137-spurious-warnings
lib/puppet/type/user.rb |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/lib/puppet/type/user.rb b/lib/puppet/type/use
disagreement over the issue, and that we need to have a more in-depth design
discussion about it before implementing an API.
On Thu, Apr 21, 2011 at 8:43 PM, Luke Kanies wrote:
> Was it really necessary to revert all three patches?
>
> On Apr 21, 2011, at 5:28 PM, Max Martin wrote:
>
>
Paired-with:Matt Robinson
Signed-off-by: Max Martin
---
Local-branch: ticket/2.7.x/7080-reverts
lib/puppet/node/facts.rb | 20
spec/unit/node/facts_spec.rb | 30 ++
2 files changed, 14 insertions(+), 36 deletions(-)
diff --git a/lib/puppet
/request_spec.rb
Paired-with:Matt Robinson
Signed-off-by: Max Martin
---
Local-branch: ticket/2.7.x/7080-reverts
lib/puppet/indirector/request.rb | 51 +-
spec/unit/indirector/request_spec.rb | 95 --
2 files changed, 2 insertions(+), 144 deletions
/node_spec.rb
Paired-with: Matt Robinson
Signed-off-by: Max Martin
---
Local-branch: ticket/2.7.x/7080-reverts
lib/puppet/node.rb | 23 -
spec/unit/node_spec.rb | 63
2 files changed, 0 insertions(+), 86 deletions(-)
diff
We don't have agent hostname prior to it coming online. According to
> what we've seen online pre-generating and distributing keys is not an
> option given that constraint.
>
> Thank you for your help!
>
--
Max Martin (404) 585-1840
Puppet Labs http://www.puppetlabs.com
-
Branch: refs/heads/master
Home: https://github.com/puppetlabs/puppet
Commit: 3ab44c7ce01ab86a995deb66228f5be95239c92a
https://github.com/puppetlabs/puppet/commit/3ab44c7ce01ab86a995deb66228f5be95239c92a
Author: Max Martin
Date: 2011-04-13 (Wed, 13 Apr 2011)
Changed paths:
M CHANGELOG
Testing of the to_pson method relied on order dependency that was
causing failures in ruby 1.8.6 (though not 1.8.7). Fixed this by parsing
the resulting PSON and testing the parsed object's properties instead of
doing string matching.
Reviewed-by:Matt Robinson
Signed-off-by: Max M
Apologies for the double e-mail; there were some hidden failures with the
first version of the patch.
On Mon, Apr 18, 2011 at 11:44 AM, Max Martin wrote:
> As per the design decision documented in #7131, optional arguments to
> options will no longer be supported. This patch cause
el Pittman
Signed-off-by: Max Martin
---
Local-branch: ticket/2.7.x/7131-optional-arguments
lib/puppet/interface/option.rb |5 +-
.../things_that_declare_options.rb | 54 +++-
spec/unit/application/face_base_spec.rb|1 -
3 fil
el Pittman
Signed-off-by: Max Martin
---
Local-branch: ticket/2.7.x/7131-optional-arguments
lib/puppet/interface/option.rb |1 +
.../things_that_declare_options.rb | 54 +++-
2 files changed, 30 insertions(+), 25 deletions(-)
diff --git a/
Paired-with: Jacob Helwig
Signed-off-by: Max Martin
---
lib/puppet/type/file/source.rb |1 +
spec/unit/type/file/source_spec.rb |1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/lib/puppet/type/file/source.rb b/lib/puppet/type/file/source.rb
index 6dda795..6ebec51 100
/rest_api.html
This documentation has not been updated as of the writing of this
commit, but will be very soon. Puppet::SSL::Host is now fully integrated
into the Indirector.
Paired-with:Matt Robinson, Jacob Helwig, Jesse Wolfe, Richard Crowley,
Luke Kanies
Signed-off-by: Max Martin
---
Local
/rest_api.html
This documentation has not been updated as of the writing of this
commit, but will be very soon. Puppet::SSL::Host is now fully integrated
into the Indirector.
Paired-with:Matt Robinson, Jacob Helwig, Jesse Wolfe, Richard Crowley,
Luke Kanies
Signed-off-by: Max Martin
---
Local
till works on
systems which use sysv-rc 2.88 or greater (atm, only Debian Lenny). We
wanted to change as little as possible because update-rc.d prints a
message stating that the new enable/disable API is unstable and may
change in the future.
Paired-with:Matt Robinson, Jacob Helwig
Signed-off-b
Paired-with:Matt Robinson
Signed-off-by: Max Martin
---
Local-branch: feature/next/6531_report_generator
lib/tasks/import_reports.rake |7 ++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/lib/tasks/import_reports.rake b/lib/tasks/import_reports.rake
index 4e8ce87
Added functionality to generate multiple sample reports per sample node
to the reports:samples:generate rake task.
Paired-with:Matt Robinson
Signed-off-by: Max Martin
---
Local-branch: feature/next/6531_report_generator
lib/data_generator.rb |9 +
lib/tasks
This series of patches adds rake tasks to generate sample data for testing.
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to puppet-dev@googlegroups.com.
To unsubscribe from this group, send email to
pup
The sample report generator is now a rake task that can be run from
project root with "rake reports:generate_samples". REPORT_DIR
environment variable can be set to the desired location of the report
samples; this defaults to tmp/sample_reports.
Paired-with:Matt Robinson
Signed-o
Generated sample reports will now have sample events attached to their
statuses.
Paired-with:Matt Robinson
Signed-off-by: Max Martin
---
Local-branch: feature/next/6531_report_generator
ext/report_generator/generate_report.rb | 24
1 files changed, 24 insertions
reports:samples:generate rake task now takes environment variable
arguments for the number of nodes, statuses, and events, as well as the
directory to store the sample reports in.
Paired-with:Matt Robinson
Signed-off-by: Max Martin
---
Local-branch: feature/next/6531_report_generator
lib/tasks
ad of module since this matches its original definition
and monkeypatching it as a module was causing errors.
Paired-with:Matt Robinson
Signed-off-by: Max Martin
---
Local-branch: feature/next/6531_report_generator
lib/tasks/generate_and_import_samples.rake |6 ++
lib/
New rake task node:generate_unresponsive to add NUM_NODES unresponsive
nodes to the DB for testing. This commit also moved data generator
functionality out of the generate_sample_reports.rake file into its own
lib file.
Paired-with:Matt Robinson
Signed-off-by: Max Martin
---
Local-branch
f-by: Max Martin
---
Local-branch: feature/next/6531_report_generator
...nerate_report.rb => generate_sample_reports.rb} | 27 -
ext/report_generator/populate_dashboard.rb | 31
2 files changed, 26 insertions(+), 32 deletions(-)
ren
From: Matt Robinson
The report generator needs a lot of cleanup and features added, so this
is just a branch for now. At some point this should be merged in to the
mainline (after cleanup) so that people can generate random report data.
Signed-off-by: Max Martin
---
Local-branch: feature/next
One of the stubs was accidentally stubbing for /bin/foo instead of
/bin/true.
Reviewed-by:Nick Lewis
Signed-off-by: Max Martin
---
spec/unit/type/exec_spec.rb |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/spec/unit/type/exec_spec.rb b/spec/unit/type/exec_spec.rb
Kudos are also due to Daniel for a lot of the work in this series.
On Thu, Mar 17, 2011 at 11:01 PM, Daniel Pittman wrote:
> On Thu, Mar 17, 2011 at 20:12, Nigel Kersten wrote:
> > On Thu, Mar 17, 2011 at 1:42 PM, Max Martin wrote:
> >
> >> This series of patches bre
-off-by: Max Martin
---
spec/unit/provider/exec/shell_spec.rb |2 +-
spec/unit/type/exec_spec.rb | 155 +
2 files changed, 82 insertions(+), 75 deletions(-)
diff --git a/spec/unit/provider/exec/shell_spec.rb
b/spec/unit/provider/exec/shell_spec.rb
From: Daniel Pittman
Many path parameters were implementing their own inconsistent validation
and behavior. Now those parameters can have a parent class that makes
things a lot more consistent.
Reviewed-by: Matt Robinson and Max Martin
Signed-off-by: Max Martin
---
lib/puppet/parameter.rb
From: Daniel Pittman
This is in preparation for allowing other new providers to handle exec
commands differently.
Reviewed-by: Max Martin and Matt Robinson
Signed-off-by: Max Martin
---
lib/puppet/provider/exec/posix.rb | 112 ++
lib/puppet/type/exec.rb | 179
Revised a few of the new tests for the exec type and provider to
ensure that they were testing what they meant to, and added in a
couple of new tests.
Reviewed-by:Daniel Pittman
Signed-off-by: Max Martin
---
lib/puppet/type/exec.rb |2 +-
spec/unit/provider/exec/posix_spec.rb
. For now leaving them since
they serve as a more integration level set of tests.
Paired-with: Max Martin
Signed-off-by: Max Martin
---
test/ral/type/exec.rb | 263 -
1 files changed, 87 insertions(+), 176 deletions(-)
diff --git a/test/ral/type
From: Matt Robinson
Paired-with: Max Martin
Signed-off-by: Max Martin
---
spec/unit/type_spec.rb |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/spec/unit/type_spec.rb b/spec/unit/type_spec.rb
index b7a0897..0adedf2 100755
--- a/spec/unit/type_spec.rb
+++ b/spec/unit
From: Matt Robinson
Paired-with: Max Martin
Signed-off-by: Max Martin
---
lib/puppet/type/exec.rb |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/lib/puppet/type/exec.rb b/lib/puppet/type/exec.rb
index 5ed2b10..387c592 100755
--- a/lib/puppet/type/exec.rb
+++ b/lib
From: Daniel Pittman
with_verbose_disabled allows you to run tests that muck with constans
without getting spammy warnings.
Reviewed-by: Max Martin and Matt Robinson
Signed-off-by: Max Martin
---
spec/lib/puppet_spec/verbose.rb |9 +
spec/spec_helper.rb |6
This series of patches breaks some of the existing functionality of the exec
type
into a POSIX-specific provider and adds a Shell exec provider to execute
unfiltered bash code.
[PATCH/puppet 1/9] (#4884) Get rid of open3 require since it wasn't being used
[PATCH/puppet 2/9] (#4884) Fix whitespa
From: Matt Robinson
Paired-with: Max Martin
Signed-off-by: Max Martin
---
spec/integration/transaction_spec.rb | 24 +---
1 files changed, 9 insertions(+), 15 deletions(-)
diff --git a/spec/integration/transaction_spec.rb
b/spec/integration/transaction_spec.rb
index
From: Matt Robinson
This makes it possible to use shell builtins when the exec is inline
bash commands.
Paired-with: Max Martin
Signed-off-by: Max Martin
---
lib/puppet/provider/exec/shell.rb | 17
spec/unit/provider/exec/shell_spec.rb | 44
Ensured that withenv properly restores the environment after it runs a block
and added testing for the method.
Reviewed-by: Matt Robinson and Daniel Pittman
Signed-off-by: Max Martin
---
lib/puppet/util/execution.rb |9 +++
spec/unit/util/execution_spec.rb | 49
When adding a test for #6309, decided to refactor mount provider
integration tests by adding return value to check_fstab method.
Paired-with:Paul Berry
Signed-off-by: Max Martin
---
spec/integration/provider/mount_spec.rb | 38 ++
1 files changed, 33 insertions
-off-by: Max Martin
---
Local-branch: ticket/next/4798-rdoc-fixes
lib/puppet/util/rdoc.rb | 13 +-
spec/fixtures/unit/util/rdoc/basic.pp | 16 +++
spec/unit/util/rdoc_spec.rb | 70 +++-
3 files changed, 35 insertions(+), 64 deletions
From: Matt Robinson
Merging 2.6.next into next caused a regression; this commit fixes that
regression.
Paired-with:Max Martin
Signed-off-by: Max Martin
---
Local-branch: ticket/next/4798-rdoc-fixes
lib/puppet/util/rdoc.rb |1 +
lib/puppet/util/rdoc/parser.rb
From: Matt Robinson
Paired-with: Daniel Pittman
Signed-off-by: Max Martin
---
Local-branch: ticket/next/4798-rdoc-fixes
lib/puppet/application/doc.rb |8 +---
lib/puppet/defaults.rb|4
2 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/lib/puppet
There were some regressions discovered after the merge that these patches fix.
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to puppet-dev@googlegroups.com.
To unsubscribe from this group, send email to
Added test case to ensure indirection name is not changed from "facts"
when making an HTTP GET request.
Reviewed-by:Paul Berry
Signed-off-by: Max Martin
---
spec/unit/network/http/api/v1_spec.rb |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/spec/un
Added support for adding "_search" to the end of any indirection to
'pluralize' it, and added tests to check this functionality and to test
hidden side effect of plurality method unpluralizing indirections.
Paired-With:Paul Berry
Signed-off-by: Max Martin
---
lib/puppet/ne
58 matches
Mail list logo
