Re: [Puppet-dev] ANNOUNCE: Facter 1.5.9rc6

On 10 May 2011 01:39, Nigel Kersten wrote: > Facter 1.5.9rc6 is a maintenance release containing fixes and updates. > > The keen-eyed observers amongst you will notice it's been a month since our > last RC5 of Facter 1.5.9, which is most certainly not our normal process. > We simply missed the "re

Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #6695 - Updated id fact for Darwin et al

On 14 March 2011 17:44, Daniel Pittman wrote: > On Mon, Mar 14, 2011 at 10:32, Paul Nasrat wrote: >> On 14 March 2011 16:52, Daniel Pittman wrote: >>> On Sun, Mar 13, 2011 at 19:57, James Turnbull >>> wrote: > > […] >>> It would be really goo

Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #6695 - Updated id fact for Darwin et al

On 14 March 2011 17:30, Daniel Pittman wrote: > On Mon, Mar 14, 2011 at 10:29, Paul Nasrat wrote: >> On 14 March 2011 15:46, James Turnbull wrote: >>> Paul Nasrat wrote: >>>> On 14 March 2011 02:57, James Turnbull wrote: >>>>> Signed-off-by:

Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #6695 - Updated id fact for Darwin et al

On 14 March 2011 16:52, Daniel Pittman wrote: > On Sun, Mar 13, 2011 at 19:57, James Turnbull wrote: >> >> Signed-off-by: James Turnbull >> --- >> Local-branch: tickets/master/6695 >>  lib/facter/id.rb |    2 +- >>  1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/lib/facter/i

Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #6695 - Updated id fact for Darwin et al

On 14 March 2011 15:46, James Turnbull wrote: > Paul Nasrat wrote: >> On 14 March 2011 02:57, James Turnbull wrote: >>> Signed-off-by: James Turnbull >> >> This list is kinda excessive, is there anything it doesn't work for >> explicitly (ie do we need

Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #6695 - Updated id fact for Darwin et al

On 14 March 2011 02:57, James Turnbull wrote: > > Signed-off-by: James Turnbull This list is kinda excessive, is there anything it doesn't work for explicitly (ie do we need the confine). > --- > Local-branch: tickets/master/6695 >  lib/facter/id.rb |    2 +- >  1 files changed, 1 insertions(+)

Re: [Puppet-dev] [PATCH/facter 1/1] Fix #6679 - Added Scientific Linux to operatingsystem fact

On 11 March 2011 00:52, James Turnbull wrote: > Thanks to James Goddard for the patch +1 > > Signed-off-by: James Turnbull > --- > Local-branch: ticket/master/6679 >  lib/facter/operatingsystem.rb     |    2 ++ >  spec/unit/operatingsystem_spec.rb |   12 ++-- >  2 files changed, 8 inser

Re: [Puppet-dev] [PATCH/facter 1/3] Discussion on ec2 facts - #2346

On 9 March 2011 16:55, James Turnbull wrote: > Paul Nasrat wrote: >> On 8 March 2011 17:23, James Turnbull wrote: >>> Paul Nasrat wrote: >>>> +1 been pending for too long >>> Was that a +1 on patches 2 and 3 in that series also?  I largely rewrote >>

Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #5485 - Updated selinux_mode fact

On 9 March 2011 14:00, Todd Zullinger wrote: > Paul Nasrat wrote: >> You've also changed the rule to use Current mode not Mode from >> config file, was this intentiional have you tested on rhel4, rhel5, >> rhel6 and non-rhel selinux systems? > > It seems like a dif

Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #5485 - Updated selinux_mode fact

On 8 March 2011 21:33, James Turnbull wrote: > 1.  Added tested > 2.  Refactored to use F:U:R.exec > 3.  Chomp trailing newline What happens if it gets output if no Current Mode line (think older, think you're missing test/handling for that. You've also changed the rule to use Current mode not M

Re: [Puppet-dev] [PATCH/facter 1/3] Discussion on ec2 facts - #2346

On 8 March 2011 17:23, James Turnbull wrote: > Paul Nasrat wrote: >> +1 been pending for too long > > Was that a +1 on patches 2 and 3 in that series also?  I largely rewrote > the whole fact. Just on this, I need to review the arp fact in more depth. I think the basic idea

Re: [Puppet-dev] [PATCH/facter 1/1] (#2721) Merged patch from Brane GraAnar

On 9 March 2011 01:32, Adrien Thebo wrote: >  - Adds support for Slamd64 and Bluewhite64 for the operatingsystem >   fact >  - Adds support for Slamd64 and Bluewhite64 for the >   operatingsystemrelease fact +1 The duplication is a bit of a code smell, we probably should improve this fact some l

Re: [Puppet-dev] [PATCH/facter 1/3] Discussion on ec2 facts - #2346

+1 been pending for too long On 8 March 2011 10:28, James Turnbull wrote: > From: Paul Nasrat > > The EC2 fact is completely broken at the moment: > > * Timeout::Error isn't caught by rescue (due to how it inherits) > * The issue of wrong open semantics outlined here,

Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #5485 - Removed trailing line for selinux_mode fact

On 7 March 2011 09:25, James Turnbull wrote: > > Signed-off-by: James Turnbull This fact probably could do with a unittest - there is selinux_spec.rb already and you should be able to add the missing test as you are touching it. Perhaps use Resolution::Exec rather than %x{} We also should enf

Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #6611 - Fixed broken HPVM test and rationalised test structure

I don't have hpux access to test, but look sane +1 On 6 March 2011 19:52, James Turnbull wrote: > > Signed-off-by: James Turnbull > --- > Local-branch: tickets/master/6611 >  spec/unit/virtual_spec.rb |   23 --- >  1 files changed, 12 insertions(+), 11 deletions(-) > > diff

Re: [Puppet-dev] How much "Do What I Mean" magic should we embed in network facts?

On 15 February 2011 20:32, Daniel Pittman wrote: > G'day. > > While Matt and I were pairing on getting IPv6 support into facter we > ran across some code that, on Darwin, would try and DWIM out the > "main" address of the system.  Specifically, it assumed that the > "main" IP address of a machine

Re: [Puppet-dev] Re: How much "Do What I Mean" magic should we embed in network facts?

On 15 February 2011 21:43, Richard Crowley wrote: > While Matt and I were pairing on getting IPv6 support into facter we > ran across some code that, on Darwin, would try and DWIM out the > "main" address of the system. Specifically, it assumed that the > "main" IP address of a machine was the one

Re: [Puppet-dev] [PATCH] Adds IPv6 related facts to facter's core.

On 5 February 2011 15:16, Cody Herriges wrote: >  The following patch provides an ipaddress6 fact to report IP addresses >  that follow the IPv6 standard, RFC 2460.  Basic code structure was modeled >  after the already current ipaddress facts available in facter core and are >  not intended to ma

Re: [Puppet-dev] [PATCH 1/3] Refactor #6044 -- port testing to rspec2

On 1 February 2011 01:57, Daniel Pittman wrote: > On Sun, Jan 30, 2011 at 09:28, Paul Nasrat wrote: >> On 28 January 2011 18:44, Daniel Pittman wrote: >>> From: Daniel Pittman >>> >>> We have moved to rspec2 for puppet, and facter should fo

Re: [Puppet-dev] [PATCH 1/3] Refactor #6044 -- port testing to rspec2

On 28 January 2011 18:44, Daniel Pittman wrote: > From: Daniel Pittman > > We have moved to rspec2 for puppet, and facter should follow suit. +1 with minor query > --- >  Rakefile                            |   14 -- >  spec/Rakefile                       |   18 -- >

Re: [Puppet-dev] [PATCH 2/3] Refactor #6044 -- require spec_helper with a consistent path.

On 28 January 2011 18:44, Daniel Pittman wrote: > From: Daniel Pittman > > Because we pull in spec_helper in individual tests, we need to use a > consistent path or Ruby will evaluate it multiple times.  Make the path > consistent by expanding it before require. +1 > --- >  spec/integration/f

Re: [Puppet-dev] [PATCH 3/3] Refactor #6044 -- use _spec.rb as the pattern for spec tests.

On 28 January 2011 18:44, Daniel Pittman wrote: > From: Daniel Pittman > > Rename all the spec tests to follow the rspec convention of *_spec.rb rather > than unadorned *.rb; this also makes it easier to work with them consistently > without using the Rakefile support that customizes that. +1 >

Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #5873 - Xen virtual fact permissions error fixed

+! On 20 January 2011 03:05, James Turnbull wrote: > > Signed-off-by: James Turnbull > --- > Local-branch: tickets/master/5873 >  lib/facter/virtual.rb |    6 +++--- >  1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/lib/facter/virtual.rb b/lib/facter/virtual.rb > index a8afb60

Re: [Puppet-dev] [PATCH] (#5699) Facter does not work properly with zLinux (s390x)

On 28 December 2010 12:04, Hector Rivas Gandara wrote: > Modified the facts processorN, processorcount, is_virtual and virtual: > >  * is_virtual=true and virtual=.zlinux. if architecture=s390x >  * /proc/cpuinfo has diferent syntax, matching /processor\s+(\d+):\s+(.*)/ IIRC both LPAR and z/vm ar

Re: [Puppet-dev] [PATCH/puppet 2/2] maint: Add vim swap files to .gitignore

On 7 January 2011 17:12, Daniel Pittman wrote: > On Jan 7, 2011 8:53 AM, "Matt Robinson" wrote: >> On Fri, Jan 7, 2011 at 8:45 AM, Paul Nasrat wrote: >> > On 6 January 2011 23:22, Matt Robinson wrote: >> >> Paired-with: Jesse Wolfe

Re: [Puppet-dev] [PATCH/puppet 2/2] maint: Add vim swap files to .gitignore

On 6 January 2011 23:22, Matt Robinson wrote: > Paired-with: Jesse Wolfe > > Signed-off-by: Matt Robinson > --- >  .gitignore |    1 + >  1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/.gitignore b/.gitignore > index 1e6b959..a208237 100644 > --- a/.gitignore > +++ b/.gitignore

Re: [Puppet-dev] Re: [PATCH/facter 1/1] (#5086) Try using kstat before falling back to 'who -b' to determine uptime.

On 26 December 2010 15:20, Jacob Helwig wrote: > On Tue, 21 Dec 2010 13:27:04 -0500, Jacob Helwig wrote: >> >> 'who -b' doesn't report the year of the last system boot on (at least) >> Solaris 10, and OpenSolaris 2009.06.  Try using 'kstat -p >> unix:::boot_time', which reports as seconds since th

Re: [Puppet-dev] [PATCH/facter 1/1] (#5666) windows support for facter/id.rb

Sure well +1 for this and we can always add more specific facts. I'll merge for next post Xmas Paul On Dec 24, 2010 6:09 PM, "Nigel Kersten" wrote: > On Fri, Dec 24, 2010 at 12:41 AM, Paul Nasrat wrote: > >> On 24 December 2010 02:52, William Van Hevelingen >&

Re: [Puppet-dev] [PATCH/facter 1/1] (#5666) windows support for facter/id.rb

On 24 December 2010 02:52, William Van Hevelingen wrote: > From: William Van Hevelingen Looks good - according to this: http://www.windowsitpro.com/article/tips/jsi-tip-7308-the-windows-xp-and-windows-server-2003-whoami-utility-.aspx It's new in XP/2003 server. Can someone from puppetlabs let

Re: [Puppet-dev] [PATCH/facter 1/1] (#1423) Memory facts for Solaris

On 3 December 2010 10:41, Dominic Cleal wrote: > On 02/12/10 23:27, Paul Berry wrote: >> On Tue, Nov 30, 2010 at 4:27 AM, Dominic Cleal > > wrote: >> >>     Add total memory from prtconf output, free from vmstat plus swap >>     free and >>     total from swap -l listing.

Re: [Puppet-dev] [PATCH/facter 1/1] (#2066) Make units optional

On 3 December 2010 10:54, Dominic Cleal wrote: > On 01/12/10 13:10, Paul Nasrat wrote: >> On 1 December 2010 10:49, Dominic Cleal wrote: >>> On 01/12/10 10:32, Dominic Cleal wrote: >>>> Memory and swap values are now given in standard units via additional facts >

Re: [Puppet-dev] [PATCH/facter 1/1] (#1423) Memory facts for Solaris

On 2 December 2010 23:27, Paul Berry wrote: > On Tue, Nov 30, 2010 at 4:27 AM, Dominic Cleal wrote: >> >> Add total memory from prtconf output, free from vmstat plus swap free and >> total from swap -l listing. >> >> Signed-off-by: Dominic Cleal >> --- >> Local-branch: tickets/master/1423 >>  li

Re: [Puppet-dev] [PATCH/facter 2/2] (#4754) Change is_virtual logic to not enumerate virtual types

On 30 November 2010 19:10, Matt Robinson wrote: > While looking at the patch for adding parallels to the virtual types > David Schmitt noticed that it might be easier just to list the types > that are NOT virtual since there's fewer of them. +1 Paul > > Paired-with: Nick Lewis > > Signed-off-by:

Re: [Puppet-dev] [PATCH/facter 1/1] (#2066) Make units optional

On 1 December 2010 10:49, Dominic Cleal wrote: > On 01/12/10 10:32, Dominic Cleal wrote: >> Memory and swap values are now given in standard units via additional facts >> (e.g. memorysize_mb) as well as the most appropriate unit as before. > > Please note that this conflicts with the patch I submi

Re: [Puppet-dev] [PATCH/puppet 1/1] Maint: made upstart tests more robust.

Does a true command ship by default on Win32? If not this will break the tests there. Unittests should be runnable - please confirm you have a windows box in your CI pipeline by default and the tests all pass on that platform with this change. Paul On Tuesday, November 23, 2010, Paul Berry wrot

Re: [Puppet-dev] [PATCH/facter 1/1] maint: Fix spec failures caused by having a space in the path to facter's source

On 22 November 2010 19:27, Nick Lewis wrote: > > Signed-off-by: Nick Lewis Execing cat in the tests is yucky, we should be able to run the tests on Win32 with the fixture data/stub data from commands. Rather than hack around with shell quoting can you instead rework the tests to be a bit more r

Re: [Puppet-dev] Best way to parse /etc/services

On 21 November 2010 11:01, Stefan Schulte wrote: > Hi, > > I wanted to write a resourcetype to manage ports in /etc/services. I did > write a type where you can do something like: > port { 'telnet', >  protocol => 'tcp', >  number    => '22', >  port_aliases => ['alias1','alias2'], > } I think th

Re: [Puppet-dev] [PATCH/facter 1/1] (#5325) Manufacturer and product name on SPARC

On 19 November 2010 09:37, Dominic Cleal wrote: > Use prtdiag output on Solaris/SPARC to determine manufacturer and productname > as > smbios is unavailable. I don't have a sparc box to test this against but +1 Paul > > Signed-off-by: Dominic Cleal > --- > Local-branch: ticket/master/5325 >  l

Re: [Puppet-dev] [PATCH/facter 1/1] (#4754) Add support for Darwin and Parallels VM to "virtual" fact

On 18 November 2010 14:07, David Schmitt wrote: > On 11/18/2010 11:13 AM, donavanm wrote: >> >> @@ -80,11 +103,11 @@ Facter.add("virtual") do >>  end >> >>  Facter.add("is_virtual") do >> -    confine :kernel =>  %w{Linux FreeBSD OpenBSD SunOS HP-UX} >> +    confine :kernel =>  %w{Linux FreeBSD Op

Re: [Puppet-dev] [PATCH/facter 1/1] (#4754) Add support for Darwin and Parallels VM to "virtual" fact

On 18 November 2010 10:13, donavanm wrote: > From: Donavan Miller > > Adds support for Parallels VM guest detection with existing operating > systems. Detects Parallels based on hardware vendor name and pci id. The > Parallels vendor id does not seem to be listed in most pci.ids. > > Adds resol

Re: [Puppet-dev] [PATCH/facter 1/1] Maint: add "Local-branch:" info to mails sent by "rake mail_patches"

+1 On 12 November 2010 18:27, Paul Berry wrote: > > Signed-off-by: Paul Berry > --- > Local-branch: maint/next/add_local_branch_to_mail_patches >  tasks/rake/mail_patches.rake |   13 - >  1 files changed, 12 insertions(+), 1 deletions(-) > > diff --git a/tasks/rake/mail_patches.rake

Re: [Puppet-dev] [PATCH/puppet 1/1] Maint: Move "Local-branch:" info below "---"

On 11 November 2010 18:21, Paul Berry wrote: > When running "rake mail_patches", moved the "Local-branch:" info lines > below the "---" line in the e-mail, so that if someone applies the > patch using "git am", the "Local-branch" notation won't show up in the > commit message. > Not sure if facte

Re: [Puppet-dev] [PATCH/facter 1/1] (#5016) is_virtual should be true on solaris zones

On 3 November 2010 22:41, Stefan Schulte wrote: > While the fact virtual recognised solaris zones before, the is_virtual > fact did not. Before everyone thinks I'm just grumpy - before coffee and exceedingly busy atm so a little terse. Thanks a lot for the patches, grateful to see contributors t

Re: [Puppet-dev] [PATCH/facter 1/1] Feature #5193 - Added conditional support for JSON

On 10 November 2010 06:34, Nigel Kersten wrote: > On Tue, Nov 9, 2010 at 10:22 PM, Paul Nasrat wrote: >> On 10 November 2010 00:16, Paul Berry wrote: >>> On Wed, Nov 3, 2010 at 8:04 PM, James Turnbull >>> wrote: >>>> >>>> From: John E. Vi

Re: [Puppet-dev] [PATCH/facter 1/1] (#4989) Add xendomains fact

On 10 November 2010 01:13, Paul Berry wrote: > On Mon, Oct 18, 2010 at 3:45 PM, Rein Henrichs wrote: >> >> Parses `/usr/sbin/xm list` and returns a comma-separated list of >> domains. Based on a patch submitted by Jonas Genannt. >> --- >> >>  Jonas, >> >>  Thanks for sending us your patch. I've m

Re: [Puppet-dev] [PATCH/facter 1/1] Feature #5193 - Added conditional support for JSON

On 10 November 2010 00:16, Paul Berry wrote: > On Wed, Nov 3, 2010 at 8:04 PM, James Turnbull > wrote: >> >> From: John E. Vincent >> >> >> Signed-off-by: James Turnbull >> --- >>  bin/facter |   22 -- >>  1 files changed, 20 insertions(+), 2 deletions(-) >> >> diff --git a/

Re: [Puppet-dev] Re: [PATCH/facter 1/1] JSON support. Works in 1.9.1. Warnings in 1.9.2. LoadError on 1.8.7 for some reason

On 4 November 2010 19:14, John E. Vincent wrote: > > On Nov 4, 12:59 pm, Markus Roberts wrote: >> > >> We need testing on 1.8.1 upwards. Do we not want json/pure rather than >> > >> json? >> >> > > i.e. PSON? >> >> > I really don't want to have to do embed that in facter. >> >> P -- >> >> Aw.  Bu

Re: [Puppet-dev] [PATCH/facter 1/1] JSON support. Works in 1.9.1. Warnings in 1.9.2. LoadError on 1.8.7 for some reason

On 4 November 2010 16:52, Markus Roberts wrote: > > > >> We need testing on 1.8.1 upwards. Do we not want json/pure rather than >> json? > > i.e. PSON? I really don't want to have to do embed that in facter. Paul -- You received this message because you are subscribed to the Google Groups "Pu

Re: [Puppet-dev] [PATCH/facter 1/1] JSON support. Works in 1.9.1. Warnings in 1.9.2. LoadError on 1.8.7 for some reason

On 4 November 2010 04:20, James Turnbull wrote: > From: John E. Vincent We need testing on 1.8.1 upwards. Do we not want json/pure rather than json? > Signed-off-by: James Turnbull > --- >  bin/facter                |    5 - >  lib/facter/application.rb |   13 + >  2 files cha

Re: [Puppet-dev] Re: No puppet developer patches to the puppet-dev list

On 28 October 2010 23:39, Teyo Tyree wrote: > Like to note a few things about our development shift that we > unfortunately did not communicate effectively in our initial email. > We are iterating on our internal development process in order to more > rapidly deliver complete features across our p

Re: [Puppet-dev] Re: No puppet developer patches to the puppet-dev list

On 29 October 2010 15:19, Nigel Kersten wrote: > > > On Fri, Oct 29, 2010 at 3:42 AM, R.I.Pienaar wrote: >> >> - "Teyo Tyree" wrote: >> >> > Would you all be interested knowing what we are working on each week? >> > Our iterations will tend to have a theme.  This week we are working >> > on

Re: [Puppet-dev] No puppet developer patches to the puppet-dev list

On 27 October 2010 21:10, Matt Robinson wrote: > We've gotten feedback that a lot of the patches that are sent to the > puppet-dev list aren't terribly useful to our community to read and > tend to overwhelm the conversation. -1. How was this survey carried out? It's pretty easy to filter mail a

Re: [Puppet-dev] [PATCH/facter 1/1] (#4989) Add xendomains fact

On 18 October 2010 23:45, Rein Henrichs wrote: > Parses `/usr/sbin/xm list` and returns a comma-separated list of > domains. Based on a patch submitted by Jonas Genannt. Looks good - is the output of xm list consistent across all known releases of xen? Paul > --- > >  Jonas, > >  Thanks for sen

Re: [Puppet-dev] [PATCH/facter 1/1] Feature #4575: win32 support for manufacturer, productname, & serialnumber

+1 Using WMI queries where we can makes sense On 19 October 2010 00:28, Rein Henrichs wrote: > From: William Van Hevelingen > > Signed-off-by: William Van Hevelingen > Signed-off-by: Rein Henrichs > --- >  lib/facter/manufacturer.rb      |    8 >  lib/facter/util/manufacturer.rb |  

[Puppet-dev] Re: [PATCH/facter 1/1] Make sure FreeBSD spec also works on systems that have /proc/cpuinfo.

On 7 October 2010 10:23, Paul Nasrat wrote: > From: Hans de Graaff > > > Signed-off-by: Paul Nasrat +1 tested on Linux machine. Paul -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group

[Puppet-dev] [PATCH/facter 1/1] Make sure FreeBSD spec also works on systems that have /proc/cpuinfo.

From: Hans de Graaff Signed-off-by: Paul Nasrat --- spec/unit/util/virtual.rb |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/spec/unit/util/virtual.rb b/spec/unit/util/virtual.rb index 1e31a2f..cc528d1 100644 --- a/spec/unit/util/virtual.rb +++ b/spec/unit/util

[Puppet-dev] [PATCH/facter 1/1] Issue #4889 Fact values should all be strings

Fix is_virtual fact to return strings rather than bools. Signed-off-by: Paul Nasrat --- lib/facter/virtual.rb |4 ++-- spec/unit/virtual.rb | 12 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/facter/virtual.rb b/lib/facter/virtual.rb index c14a715

Re: [Puppet-dev] [PATCH/facter 1/1] [#4583] Refactor uptime to use Resolution.exec

On 24 August 2010 22:28, Rein Henrichs wrote: > Resolution.exec used to ensure that any shell errors are suppressed. +1 As said in the bug this resolves the issue Paul -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this grou

Re: [Puppet-dev] Re: [PATCH/puppet] Fix Debian package / gem interactions in spec_helper

On 19 August 2010 13:30, Daniel Pittman wrote: > Daniel Pittman writes: > >> This works around the interaction of Debian packaged librspec-ruby and gems. >> Under Debian the library is available, but the gem support fails; this >> ignores >> the gem failure and carries on anyway. > > In case thi

Re: [Puppet-dev] [PATCH/facter 1/1] Resend - Discussion on ec2 facts - #2346

On 17 August 2010 19:50, Rein Henrichs wrote: > Excerpts from Paul Nasrat's message of Tue Aug 17 06:40:42 -0700 2010: >> The EC2 fact is completely broken at the moment: >> >> * Timeout::Error isn't caught by rescue (due to how it inherits) >> * The issue of wrong open semantics outlined here, th

Re: [Puppet-dev] [PATCH/facter 1/1] [#4289] operatingsystemrelease fact for oel, ovs

On 18 August 2010 23:58, Rein Henrichs wrote: > When Facter returns operatingsystem as "oel" or "ovs", the > operatingsystemrelease fact does not catch these properly, causing an > error. > > Specs added to catch failure and case statement updated to catch "oel" > and "ovs" as well as "OEL" and "O

Re: [Puppet-dev] [PATCH/facter 1/1] Resend - Discussion on ec2 facts - #2346

On 17 August 2010 21:27, Nigel Kersten wrote: > On Tue, Aug 17, 2010 at 1:03 PM, Jeff McCune wrote: >> On Tue, Aug 17, 2010 at 12:31 PM, Nigel Kersten wrote: >>> I've implemented local caching for my computational expensive and >>> infrequently varying facts, and I've been thinking about whether

[Puppet-dev] Re: [Puppet Users] ANNOUNCE: Facter 1.5.8rc1

On 17 August 2010 20:20, James Turnbull wrote: > For 40 days and 40 nights Facter wandered in the wilderness sustained > only by the occasional patch and bottle of Kool-Aid. Tanned and happy > Facter 1.5.8rc1 has now emerged from its desert retreat. Testing on various virtual environments and hos

[Puppet-dev] Facter next -> merge for 1.5.8RC1

Reviewing next branch for RC as discussed, I'm happy with all the changes up to 6edf3199a212e6b33f9e09edbb3cb34710710326, we should create a branch with the RC version bump and think about generating the tarballs, documentation and release notes. Paul -- You received this message because you are

[Puppet-dev] [PATCH/facter 1/1] Resend - Discussion on ec2 facts - #2346

owing patch fixes the first two, I'm not sure we want to take the timeout hit, we also want to add tests as even simple ruby code can get logic errors such as the open(). Signed-off-by: Paul Nasrat --- lib/facter/ec2.rb |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff -

Re: [Puppet-dev] [PATCH/facter 2/2] [#2330] Update uptime calculation to use /bin/cat

On 6 August 2010 17:55, Paul Berry wrote: > On Fri, Aug 6, 2010 at 2:23 AM, Paul Nasrat wrote: >> >> Random thought for 1.6 or later we could have a ProcFile and Sysctl >> specific class (and dmidecode) to encapsulate the complexities of >> different platforms/versio

Re: [Puppet-dev] [PATCH/facter 1/2] [#2330] Uptime should not make redundant system calls

On 6 August 2010 00:35, Rein Henrichs wrote: > From: Rein Henrichs > > Rewrite of uptime facts and supporting utility methods. Works on unix, > BSD, windows. No longer makes redundant system calls. +1, tested locally > > Uses Facter::Util::Uptime utility methods: > > * Implemented uptime_seconds

Re: [Puppet-dev] [PATCH/facter 2/2] [#2330] Update uptime calculation to use /bin/cat

On 6 August 2010 00:35, Rein Henrichs wrote: > * Per #4466, Ruby has trouble reading files in /proc [1]. The >  alternative is to use `bin/cat`. > > * Also refactored methods to explicitly redirect standard error to >  /dev/null for *nix and BSD system calls. +1 Random thought for 1.6 or later w

Re: [Puppet-dev] [PATCH/facter 1/1] [#2330] Uptime should not make redundant system calls

On 3 August 2010 23:03, Rein Henrichs wrote: > From: Rein Henrichs > > Rewrite of uptime facts and supporting utility methods. Works on unix, > BSD, windows. No longer makes redundant system calls. > > Uses Facter::Util::Uptime utility methods: > Thanks for this, not had time to look in anger bu

Re: [Puppet-dev] Patch: Implement kiB versions to all existing memory facts

On 8 July 2010 09:07, Kai wrote: > In an earlier thread on puppet-users there was a request for a patch. > This is what I could come up with without discussing much. > > Points that I can think of: > > - Perhaps a suffix of 'KiB' is better in this world where kB could be > interpreted as 1000 byte

Re: [Puppet-dev] [PATCH/facter 2/2] Fix #4352 - Support for detecting KVM virtuals on FreeBSD

On 25 July 2010 23:50, Jiri Kubicek wrote: > There was no support for detecting FreeBSD running in KVM as a virtual in > facter. This patch detects KVM by getting "hw.model" kernel state via sysctl. > Jails running in KVM are also correctly detected as "jail" not "kvm". Looks good, as with othe

Re: [Puppet-dev] [PATCH/facter 1/2] Fix #4352 - Support for detecting virtuals (jails) on FreeBSD

On 25 July 2010 23:50, Jiri Kubicek wrote: > There was no support for detecting FreeBSD jails as a virtual in facter. This > patch detects jail by getting "security.jail.jailed" kernel state via sysctl. Thanks, on a scan looks good, but I'll try test later today. Paul > > Signed-off-by: Jiri Ku

Re: [Puppet-dev] [PATCH/puppet 1/1] Fixes #3395 - CR+LF line endings in manifests cause syntax error

On 15 June 2010 18:26, James Turnbull wrote: > Thanks to Alan Barrett for the patch I know it's a trivial change but shouldn't it have a test. Paul > Signed-off-by: James Turnbull > --- >  lib/puppet/parser/lexer.rb |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a

Re: [Puppet-dev] [PATCH/puppet 1/1] [#3994] rename the specs to have _spec.rb at the end

On 13 June 2010 18:38, Jesse A Wolfe wrote: > +1, I've certainly been bitten by this. > an executable that fails because you're in the wrong directory feels > brittle, and I'm in favor of any change that makes the tests less likely to > fail for surprising reasons. > (an alternate suggestion would

Re: [Puppet-dev] [PATCH/facter 1/1] WIP - Adding HP-UX support to Facter's IP facts

On 12 June 2010 00:54, James Turnbull wrote: > > Signed-off-by: James Turnbull > --- >  lib/facter/util/ip.rb                         |   17 +++- >  spec/unit/data/hpux_ifconfig_single_interface |    2 + >  spec/unit/data/hpux_netstat_all_interfaces    |    6 +++ >  spec/unit/util/ip.rb      

Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #3939 - Rescue action for swap -l on AIX

2010/6/10 Héctor Rivas Gándara : > I think it simply could detect that the command (swap -l ) failed and > raise an exception with the output (or first line of the output). Potentially yes, we should change how util.exec works and enable logging to user/exception passing to lib callers. However th

Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #3939 - Rescue action for swap -l on AIX

On 10 June 2010 07:16, James Turnbull wrote: > > Signed-off-by: James Turnbull -1 Hmm, there are a whole bunch of facts/commands that require root or behave differently. I'd rather see this implemented as a confine. > --- >  lib/facter/memory.rb |   14 +- >  1 files changed, 9 inse

[Puppet-dev] Re: [PATCH/facter 1/1] Enable TLD for dnsdomainname

On 27 May 2010 13:45, Paul Nasrat wrote: > This addresses #3356 and supports an arbitrary TLD with hosts in. > > Signed-off-by: Paul Nasrat > > Actually I want to write a whole bunch of tests before I change anything here. Paul -- You received this message because you are su

[Puppet-dev] [PATCH/facter 1/1] Enable TLD for dnsdomainname

This addresses #3356 and supports an arbitrary TLD with hosts in. Signed-off-by: Paul Nasrat --- lib/facter/domain.rb |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/facter/domain.rb b/lib/facter/domain.rb index 5dfead0..a04d2b8 100644 --- a/lib/facter/domain.rb

Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #3393 - Updates to Facter for MS Windows

On 30 April 2010 14:32, David Schmitt wrote: > On 4/30/2010 10:45 AM, James Turnbull wrote: > > The following piece has a hole that triggers a spec fail on windows. > Shell-builtins are not checked although they would work when executed. I've > investigated a bit and the problem is, that ruby's

Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #3403 - Added fact to query vlans; added spec test

On 24 April 2010 06:38, James Turnbull wrote: > From: Jonas Genannt > > > Signed-off-by: James Turnbull > --- > lib/facter/util/vlans.rb | 25 + > lib/facter/vlans.rb |8 > spec/unit/data/linux_vlan_config |6 ++ > spec/unit/u

Re: [Puppet-dev] fixes for #3740

On 7 May 2010 08:21, Marc Fournier wrote: > Hello, > > I'm not sure to understand the use of these trailing dots I removed with > the > 2nd patch. As there isn't many tests for this function, maybe this breaks > something else and needs more work. If I have time over the weekend I'll try get a

Re: [Puppet-dev] [PATCH/facter 2/2] Fixed failing test introduced by previous commit

On 7 May 2010 08:21, Marc Fournier wrote: > > Signed-off-by: Marc Fournier > +1 Paul -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to puppet-...@googlegroups.com. To unsubscribe from this group, send

Re: [Puppet-dev] [PATCH/facter 1/2] Fixes #3740 - split dmi output on regex

On 7 May 2010 08:21, Marc Fournier wrote: > Splitting dmi output on the string "/^Handle/" didn't work, and > caused the function to match the wrong key if it was found more > than once. > The intended behaviour of the function is restored by splitting > the dmi output on the regex /^Handle/. >

[Puppet-dev] [PATCH/facter 1/1] Fix virtual unit test on non-linux by stubbing kernel

Signed-off-by: Paul Nasrat --- spec/unit/virtual.rb |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/spec/unit/virtual.rb b/spec/unit/virtual.rb index fe9988e..7dbd146 100644 --- a/spec/unit/virtual.rb +++ b/spec/unit/virtual.rb @@ -50,6 +50,7 @@ describe "is_vi

Re: [Puppet-dev] James Turnbull (finally) joins Puppet Labs

On 12 April 2010 04:58, Luke Kanies wrote: > We're very excited to announce that after years of being a critical > contributor to Puppet, including writing the Puppet Book, James Turnbull is > joining Puppet Labs as Director of Operations, where he'll be responsible > for infrastructure, support,

Re: [Puppet-dev] Re: [PATCH/facter 1/1] Fixes #3445.

On 30 March 2010 09:52, Pavol Dilung wrote: > Hi Luke, > > yep, those patches are same. I messed up the Subject in first post so > I've repost it again. Sorry for that ;) OK cool - I can test here at work and validate. My home internet should be back tomorrow (but at puppet meet in evening) so ho

[Puppet-dev] London Puppet Meet - Wednesday 31 March

Meet up following training, open to all, we'll meet at The Green Man pub again, I get off about 18h so probably there about 18:30 but feel free to get there earlier if the class finishes up. Green Man 36 Riding Hood St London W1W 7EP http://www.thegreenmanw1.co.uk/ It's 4 mins by google maps wal

Re: [Puppet-dev] [PATCH/facter 1/1] Fix for #3411 install.rb should not put "." first in the tmp_dirs

On 23 March 2010 10:51, Martin Englund wrote: > Signed-off-by: Martin Englund > --- >  install.rb |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/install.rb b/install.rb > index 1280f04..d1b3f18 100755 > --- a/install.rb > +++ b/install.rb > @@ -212,7 +212,7 @@ def

Re: [Puppet-dev] [PATCH/facter 1/1] Fix for #3411 install.rb should not put "." first in the tmp_dirs

On 23 March 2010 17:09, Markus Roberts wrote: > Martin -- > > Any reason for the seeming duplication of bugs and patches? Wasn't one against puppet and one against facter? Paul -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to t

Re: [Puppet-dev] Idea about sourcing facts from other languages

On 11 March 2010 18:12, Michael DeHaan wrote: >> >> It's already on the roadmap and as an issue, but we need to fix facter >> HEAD first. > > Revisiting the facter bugs list, I don't see it as particularly in bad > shape now that this fact is reverted. Yup I want to get 1.5.8 rc1 out this w/e (wh

Re: [Puppet-dev] Idea about sourcing facts from other languages

On 10 March 2010 06:41, Luke Kanies wrote: > > On Mar 9, 2010, at 10:35 PM, Paul Nasrat wrote: > >> On 10 March 2010 03:56, Nigel Kersten wrote: >>> >>> On Tue, Mar 9, 2010 at 5:52 PM, Luke Kanies >>> wrote: >>>>

Re: [Puppet-dev] Idea about sourcing facts from other languages

On 10 March 2010 03:56, Nigel Kersten wrote: > On Tue, Mar 9, 2010 at 5:52 PM, Luke Kanies wrote: >> On Mar 9, 2010, at 5:09 AM, Michael DeHaan wrote: >> {  "facts": {  "network": {    "interface": "eth0",    "ip": "192.168.0.1",    "netmask": "255.255.255.0",  

Re: [Puppet-dev] [PATCH] Add shell glob support to puppetrun, and also groups using /etc/puppet/hostgroups.txt (JSON format).

On 9 March 2010 22:08, Michael DeHaan wrote: > Also cleaned up a few error messages (unrelated) > --- >  lib/puppet/application/puppetrun.rb |   12 ++- >  lib/puppet/daemon.rb                |    2 +- >  lib/puppet/network/server.rb        |    2 +- >  lib/puppet/util/runner.rb           |   5

Re: [Puppet-dev] [PATCH/facter 1/1] Revert "use popen3 in Resolution.exec"

On 9 March 2010 19:33, Michael DeHaan wrote: > Excellent.  I also hope to help some with the code refactoring and support > for new datastructure types. > > I agree bugs should come first, so those too :) > If you're doing this, we should do a testing branch and target for 1.6 Also, I'm a big f

Re: [Puppet-dev] [PATCH/facter 1/1] Revert "use popen3 in Resolution.exec"

On 9 March 2010 18:13, Markus Roberts wrote: > > Doh, yes, thanks.  I was reading that on the train with screen glare and > missed some of the "-' signs. I've commited this now, and have started working through the 1.5.8 bug list. Paul -- You received this message because you are subscribed t

Re: [Puppet-dev] [Feedback Wanted] Puppetrun and shell globs

On 8 March 2010 21:03, Michael DeHaan wrote: > On Mon, Mar 8, 2010 at 4:01 PM, Paul Nasrat wrote: >> On 8 March 2010 18:54, Michael DeHaan wrote: >>> These two patches are a basic attempt to enhance Puppetrun to support >>> shell globs. >>> >> >>

Re: [Puppet-dev] [Feedback Wanted] Puppetrun and shell globs

On 8 March 2010 18:54, Michael DeHaan wrote: > These two patches are a basic attempt to enhance Puppetrun to support > shell globs. > Can you configure your mailer to send inline/use git mail_patches so they're not attachments for easier review. Paul -- You received this message because you ar

Re: [Puppet-dev] Idea about sourcing facts from other languages

On 8 March 2010 20:58, Michael DeHaan wrote: > Some of us have been talking about this for a while and I'm thinking > about knocking this out soon. > > The idea is you should be able to write facts in any language, and > this lowers the barrier to entry for Puppet extensions from those > who don't

Re: [Puppet-dev] [PATCH/facter 1/1] Revert "use popen3 in Resolution.exec"

On 2 March 2010 18:52, Markus Roberts wrote: > > > On Sun, Feb 28, 2010 at 5:52 AM, Paul Nasrat wrote: >> >> This reverts commit 33fb7709404e706801683e6c47ab7a0a5a1884b1. >> >> This has broken master for some facts (eg OS X facts), it also breaks >> facter

  1   2   3   4   >