Please review pull request #793: (#14440) Fix rake manpage generation in master opened by (cprice-puppet)

Description:

This commit does some hacky initialization things
which, in an ideal world, would be handled
by our API rather than spilling out to the calling
code. However, for now, these initialization calls
are necessary in order to get rake manpage generation
working.

  • Opened: Wed May 16 20:40:44 UTC 2012
  • Based on: puppetlabs:master (bcdd35c07327d8eb7f22c6779fe1b2e2319d2a41)
  • Requested merge: cprice-puppet:bug/master/14440-rake-manpages (478d77f9f6649e52148c6f105feb569aa22ac908)

Diff follows:

diff --git a/tasks/rake/manpages.rake b/tasks/rake/manpages.rake
index 460521c..777f3b1 100644
--- a/tasks/rake/manpages.rake
+++ b/tasks/rake/manpages.rake
@@ -5,6 +5,13 @@ task :gen_manpages do
   require 'puppet/face'
   require 'fileutils'
 
+  # TODO: this line is unfortunate.  In an ideal world, faces would serve
+  #  as a clear, well-defined entry-point into the code and could be
+  #  responsible for state management all on their own; this really should
+  #  not be necessary.  When we can, we should get rid of it.
+  #  --cprice 2012-05-16
+  Puppet.initialize_settings()
+
   helpface = Puppet::Face[:help, '0.0.1']
   manface  = Puppet::Face[:man, '0.0.1']
 

    

--
You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To post to this group, send email to puppet-dev@googlegroups.com.
To unsubscribe from this group, send email to puppet-dev+unsubscr...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.

Reply via email to