Re: [Puppet-dev] [PATCH/facter 1/1] (#7039) Pre-load all facts when requesting a single fact

2011-04-12 Thread Jacob Helwig
On Tue, 12 Apr 2011 12:27:02 -0700, Luke Kanies wrote: > > I think this is a good change, but it might be worth only doing this > if the fact returns nil without it. > > That is, if the fact is in an appropriately named file, it's fast, and > if not, we take the slower route of loading everything

Re: [Puppet-dev] [PATCH/facter 1/1] (#7039) Pre-load all facts when requesting a single fact

2011-04-12 Thread Luke Kanies
I think this is a good change, but it might be worth only doing this if the fact returns nil without it. That is, if the fact is in an appropriately named file, it's fast, and if not, we take the slower route of loading everything. -- http://puppetlabs.com/ | +1-615-594-8199 | @puppetmasterd On

[Puppet-dev] [PATCH/facter 1/1] (#7039) Pre-load all facts when requesting a single fact

2011-04-12 Thread Jacob Helwig
Since multiple facts can be defined in a single file and we have no way of knowing which "additional" facts are defined in which files, we pre-load all facts when we're looking for specific one. Paired-with: Max Martin Signed-off-by: Jacob Helwig --- Local-branch: tickets/master/7039-multiple-f