Re: [Puppet-dev] [PATCH/puppet 1/3] (#5660) New Type to handle /etc/services entries

2011-03-31 Thread Jacob Helwig
On Thu, 31 Mar 2011 08:16:31 -0400, Trevor Vaughan wrote: > > I don't like 'port', but I'm having a hard time coming up with a good > alternate. > > sys_service? > > The man page says "The Internet network services list" so perhaps > net_svc or net_service? > network_service, or net_service a

Re: [Puppet-dev] [PATCH/puppet 1/3] (#5660) New Type to handle /etc/services entries

2011-03-31 Thread James Turnbull
Trevor Vaughan wrote: > I don't like 'port', but I'm having a hard time coming up with a good > alternate. > > sys_service? > > The man page says "The Internet network services list" so perhaps > net_svc or net_service? > I like net_service. James -- James Turnbull Puppet Labs 1-503-734-857

Re: [Puppet-dev] [PATCH/puppet 1/3] (#5660) New Type to handle /etc/services entries

2011-03-31 Thread Trevor Vaughan
I don't like 'port', but I'm having a hard time coming up with a good alternate. sys_service? The man page says "The Internet network services list" so perhaps net_svc or net_service? Trevor On Wed, Mar 30, 2011 at 6:44 PM, Nigel Kersten wrote: > On Tue, Mar 29, 2011 at 12:56 PM, Stefan Schult

Re: [Puppet-dev] [PATCH/puppet 1/3] (#5660) New Type to handle /etc/services entries

2011-03-30 Thread Nigel Kersten
On Tue, Mar 29, 2011 at 12:56 PM, Stefan Schulte wrote: > Thank you for all your comments so far. Thank you for your code! :) I would like us to have a public think about whether "port" is an appropriate name for this though. -- Nigel Kersten Product, Puppet Labs @nigelkersten -- You recei

Re: [Puppet-dev] [PATCH/puppet 1/3] (#5660) New Type to handle /etc/services entries

2011-03-29 Thread Stefan Schulte
On Mon, Mar 28, 2011 at 02:12:48PM -0700, Jacob Helwig wrote: > On Tue, 22 Mar 2011 23:35:10 +0100, Stefan Schulte wrote: > [...] > The original version also allowed 'ddp' (even though it wasn't > documented). Should this version allow it, too? I just want to make > sure this change is intentiona

Re: [Puppet-dev] [PATCH/puppet 1/3] (#5660) New Type to handle /etc/services entries

2011-03-28 Thread Nigel Kersten
On Tue, Mar 22, 2011 at 3:35 PM, Stefan Schulte < stefan.schu...@taunusstein.net> wrote: > This new type "port" handles entries in /etc/services. It uses multiple > key_attributes (name and protocol), so you are able to add e.g. > multiple telnet lines for tcp and udp. Sample usage > Is "port" th

Re: [Puppet-dev] [PATCH/puppet 1/3] (#5660) New Type to handle /etc/services entries

2011-03-28 Thread Markus Roberts
> +def self.title_patterns > + [ > +# we have two title_patterns "name" and "name:protocol". We won't > use > +# one pattern (that will eventually set :protocol to nil) because > we > +# want to use a default value for :protocol. And that does only > work > +

Re: [Puppet-dev] [PATCH/puppet 1/3] (#5660) New Type to handle /etc/services entries

2011-03-28 Thread Jacob Helwig
On Tue, 22 Mar 2011 23:35:10 +0100, Stefan Schulte wrote: > [...] > + The second way is the prefered way if you want to specifiy a port that > + uses both tcp and udp as a protocol. You need to define two resources > + for such a port but the resource title still has to be uniq.

[Puppet-dev] [PATCH/puppet 1/3] (#5660) New Type to handle /etc/services entries

2011-03-22 Thread Stefan Schulte
This new type "port" handles entries in /etc/services. It uses multiple key_attributes (name and protocol), so you are able to add e.g. multiple telnet lines for tcp and udp. Sample usage port { 'telnet': number => '23', protocol=> 'tcp', description => 'Telnet'

[Puppet-dev] [PATCH/puppet 1/3] (#5660) New Type to handle /etc/services entries

2010-12-23 Thread Stefan Schulte
This new type "port" handles entries in /etc/services. It uses multiple key_attributes name and protocol, so you are able to add e.g. multiple telnet lines for tcp and udp. Sample usage port { 'telnet': number => '23', protocol=> 'tcp', description => 'Telnet' }