So, I've got a couple of comments on this patch series.
It really looks like all of this should be one commit, except for moving
"defaultfor :operatingsystem => :freebsd" from ports.rb to freebsd.rb
(which should be in its own commit). Not a killer, but would certainly
make it easier to review si
I realized I forgot to include the ticket number in my last email about
including ticket numbers.
I believe this patch series was for #4996.
On Mon, Apr 25, 2011 at 11:45 AM, Matt Robinson wrote:
> Thanks for mailing that Russell, it's easier for us to keep track of what
> we still need to revi
Thanks for mailing that Russell, it's easier for us to keep track of what we
still need to review if it gets sent to the list since we've been keeping
track of patches in patchwork:
https://patchwork.puppetlabs.com/project/puppet/list/
That said, it's also really helpful if your commit messages in
* Use port origin as resource name
* Use port index from package site to determine package to use for a
given origin
* Promote as default package provider. Demote portupgrade provider.
Signed-off-by: Russell Jackson
---
lib/puppet/provider/package/freebsd.rb | 161
