On 18/02/11 18:26, Luke Kanies wrote:
> Thanks a ton for doing this.
>
> I really only have one comment below, and it's about stubs vs. real objects,
> which we've changed our tune on recently.
[snip]
>> +@resource = stub 'resource'
>> +@provider = provider_class.new(@resource)
>> +
>> +
Those tests look pretty good to me - and where they don't it is because you
followed our bad example, so no complaints from me there. ;)
Thank you so much for writing those tests to accompany the code. It makes it
easier for us to be confident that we will not regress your fix later.
Regards,
Thanks a ton for doing this.
I really only have one comment below, and it's about stubs vs. real objects,
which we've changed our tune on recently.
On Feb 18, 2011, at 1:44 AM, Dominic Cleal wrote:
>
> Signed-off-by: Dominic Cleal
> ---
> Local-branch: tickets/master/6324
> spec/unit/provider
Signed-off-by: Dominic Cleal
---
Local-branch: tickets/master/6324
spec/unit/provider/service/smf_spec.rb | 133
1 files changed, 133 insertions(+), 0 deletions(-)
create mode 100755 spec/unit/provider/service/smf_spec.rb
diff --git a/spec/unit/provider/servic
